Steps to reproduce

1. Open the project directory
2. Open a terminal in the project directory
3. Run command node quran-cli.js -z in terminal

Expected behavior (correct)

A warning message should be displayed to the user that he used an undefined flag and display the usage guide alongside the message.

Current behavior (bug)

Throw an Exception.

Environment

ubuntu 22.04

Relevant logs and/or media (optional)

Write here or upload an image/video

/home/we2am/Desktop/Github/Quran-cli/node_modules/command-line-args/dist/index.js:1377
        throw err
        ^

UNKNOWN_OPTION: Unknown option: -z
    at Object.commandLineArgs [as default] (/home/we2am/Desktop/Github/Quran-cli/node_modules/command-line-args/dist/index.js:1374:21)
    at parse (/home/we2am/Desktop/Github/Quran-cli/node_modules/ts-command-line-args/dist/parse.js:60:49)
    at Function.CommandLine.getArgs (/home/we2am/Desktop/Github/Quran-cli/utilities/parser.js:9:53)
    at Object.<anonymous> (/home/we2am/Desktop/Github/Quran-cli/quran-cli.js:6:33)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
    at internal/main/run_main_module.js:17:47 {
  optionName: '-z'
}

Root Cause Analysis

Invalid flags not handled.

Other Comments

Steps to reproduce

1. Open the project directory
2. Open a terminal in the project directory
3. Run command node quran-cli.js -d -1 in terminal

Expected behavior (correct)

The program should not run and display a warning message informing to the user of the valid radio range

the message that should be displayed:

Current behavior (bug)

The program doesn't run at all

Environment

ubuntu 22.04

Root Cause Analysis

Not Known Yet

Steps to reproduce

1. Open the project directory
2. Open a terminal in the project directory
3. Run command python3 quran_cli.py -rd 0 in terminal
4. Wait until the radio works
5. press CTRL + C to kill the process

Expected behaviour (correct)

The process should be safely(exited without exception)

Current behaviour (bug)

Exit with Exception

Environment

ubuntu 22.04

Relevant logs and/or media (optional)

Write here or upload an image/video

Radio Name:  ---Amazing short Recitations---
 (+) Audio --aid=1 (mp3 2ch 44100Hz)
AO: [pulse] 44100Hz stereo 2ch float
A: 00:00:01 / 00:00:13 (8%) Cache: 11s/408KB
File tags:
 icy-title: 339-محمد حكمي - نرفع درجات من نشاء
A: 00:00:03 / 00:00:19 (20%) Cache: 15s/552KB

Exiting... (Quit)
Traceback (most recent call last):
  File "/home/we2am/Desktop/Github/Quran-cli/quran_cli.py", line 24, in <module>
    radioMode(radioIndex)
  File "/home/we2am/Desktop/Github/Quran-cli/modes/radioMode.py", line 86, in radioMode
    runRadio(radioIndex)
  File "/home/we2am/Desktop/Github/Quran-cli/modes/radioMode.py", line 70, in runRadio
    runFromURL(getRadioURL(radioIndex))
  File "/home/we2am/Desktop/Github/Quran-cli/utilities/helperFunctions.py", line 38, in runFromURL
    subprocess.call(["mpv", url])
  File "/usr/lib/python3.10/subprocess.py", line 347, in call
    return p.wait(timeout=timeout)
  File "/usr/lib/python3.10/subprocess.py", line 1204, in wait
    return self._wait(timeout=timeout)
  File "/usr/lib/python3.10/subprocess.py", line 1938, in _wait
    (pid, sts) = self._try_wait(0)
  File "/usr/lib/python3.10/subprocess.py", line 1896, in _try_wait
    (pid, sts) = os.waitpid(self.pid, wait_flags)
KeyboardInterrupt

Root Cause Analysis

the audio player was displayed and closing the process was causing exceptions due to closing the player

Other Comments

solved in issue commit: remove audio diplay

Reproduction: 1- In cmd or powershell: run any playback command q-cli -d 0 2- Immediate output: Finished playing while playback is continued in the background 3- Can't Ctrl-c to stop, have to kill process with powershell -c "kill -Name mpv" On linux (WSL) Ctrl-c works just fine

My Build: 1- Windows 10 21H2 (19044.1766) 2- mpv installed using scoop 3- package installed using npm install @quran-cli/q-cli -g in admin mode powershell

Provide a way to pause and stop the playing without just brutely killing the process may be like this ~ ❯ ps -ef | grep mpv | grep -v grep | awk '{print $2}' | xargs -n1 kill -9

We should add more detailed instructions for installing both MPV and node on windows. A script for installing both would be better of course. The same applies to other Linux distros.