Hey,

When I use this plugin I'm getting this error in my console:

Through a little bit of Googling I came across this same error here https://github.com/vuejs/vitepress/issues/1143 and so I'm lead to believe that it is something to do with minifying the HTML when used with Vite and Vue.

Passing true to a key for the configuration object doesn't actually perform compression for that item, and is considered the same as false. Either change the type description to reflect that only a configuration object or false can be passed, or accept true as argument to use the defaults.

Example:

import { defineConfig } from 'astro/config'
import compress from 'astro-compress'

// https://astro.build/config
export default defineConfig({
	integrations: [
		compress({
			css: false,
			html: true, // note `true` is passed here
			js: false,
			img: false,
			svg: false
		})
	]
})

This doesn't result in the HTML being compressed, and it not flagged as invalid by typescript, because the type definition goes:

export interface Options {
    [key: string]: any;
    /**
     * Astro build path.
     * @default "./dist/"
     */
    path?: string;
   // abbreviated
    /**
     * [html-minifier-terser] options.
     */
    html?: boolean | HTML; // should be `false | HTML` if this is the inteded behavior
   // abbreviated
}

Is there a setting that can show me a bit more debug info on why it can not compress the file? working on Astro rc 7 / Windows

Error: Cannot compress file ./dist/index.html!
Error: Cannot compress file ./dist/admin/index.html!
Error: Cannot compress file ./dist/contact/index.html!
Error: Cannot compress file ./dist/about/index.html!
Error: Cannot compress file ./dist/es/index.html!
Error: Cannot compress file ./dist/events/index.html!
Error: Cannot compress file ./dist/menu/index.html!
Error: Cannot compress file ./dist/es/about/index.html!
....
Successfully compressed a total of 0 HTML files for 0 Bytes.

Since I upgraded from 1.1.7 to 1.1.12 the comments from the HTML are not being removed.

I get NaN undefined and comments from the html are not removed. Spacing is removed but not comments.

Astro version: "astro": "^1.6.11"

07:18:03 AM [build] Waiting for the astro-compress integration...
Successfully compressed a total of 7968 HTML files for NaN undefined.
Successfully compressed a total of 8 JS files for NaN undefined.
Successfully compressed a total of 20 SVG files for NaN undefined.

Here my astro.config:

import { defineConfig } from "astro/config";
import sitemap from "@astrojs/sitemap";
import compress from "astro-compress";
import prefetch from '@astrojs/prefetch';

import { SITE_URL, SERVER_PORT } from "./src/config";

export default defineConfig({
  site: SITE_URL,
  vite: {
    server: {
      watch: {
        ignored: ["/dist/**", "/db/**", "/src/pages/days/*.md"],
      },
    },
    logLevel: 'silent'
  },
  publicDir: "./assets",
  server: {
    port: SERVER_PORT,
    // host: true
  },
  integrations: [
    prefetch(),
    sitemap(),
    compress({
      css: false,
      html: {
        removeComments: true,
        maxLineLength: 1000,
        quoteCharacter: '"',
        removeAttributeQuotes: true
      },
      img: false,
      js: true,
      svg: true,
      logger: 1,
    }),
  ],
});

Here a gist of the html I am trying to compress: https://gist.github.com/fabriziogiordano/83f68463ad32c9f9361cb642041a9cbb

I tried different versions and it seems it is starting from astro version 1.1.8

I'd typed npm install -D -E astro-compress but got error like this :

[##################] - reify:css-tree: timing reifyNode:node_modules/
> [email protected] install
> (node install/libvips && node install/dll-copy && prebuild-install) || (node install/can-compile && node-gyp rebuild && node install/dll-copy)

sharp: Downloading https://github.com/lovell/sharp-libvips/releases/download/v8.13.3/libvips-8.13.3-android-arm64v8.tar.br
sharp: Installation error: Prebuilt libvips 8.13.3 binaries are not yet available for android-arm64v8
sharp: Please see https://sharp.pixelplumbing.com/install for required dependencies
npm ERR! code 1
npm ERR! path /data/data/com.termux/files/home/samxuling.github.io/node_modules/sharp
npm ERR! command failed
npm ERR! command sh -c -- (node install/libvips && node install/dll-copy && prebuild-install) || (node install/can-compile && node-gyp rebuild && node install/dll-copy)

It say Prebuilt libvips 8.13.3 binaries are not yet available for android-arm64v8 Is the download address incorrect? 🤔 When I navigated to https://github.com/lovell/sharp-libvips/releases/download/v8.13.3/libvips-8.13.3-android-arm64v8.tar.br GitHub say 404

Hey! :) Maybe this is an error with the html minimizer, but I dont get any errors / logs, that's why im posting this here.

Im using a minimal project with "astro": "^1.6.5" and "astro-compress": "^1.1.1"

I noticed that html files are ignored while compressing if any script contains arrow functions used like this:

<script>
    const sayHello = () => {
        console.log("Hello World");
    }
    sayHello();
</script>

However it's getting compressed with this script, which I thought was kinda weird:

<script>
    (() => {
        console.log("Hello World");
    })()

    function initializeTheme() {
        console.log("Hello World");
    }

    initializeTheme();
</script>

Whats even funnier is, that the following script (arrow function with parameters) is working too:

<script>
    const sayHello = (name) => {
        console.log(`Hello ${name}`);
    }
    sayHello("World");
</script>

To be more clear, the compressor doesn't work if any script contains arrow functions without parameters :D

Hi Guys, I've an issue using this plugin on build. It's might be compatibility issue with Deno Adapter. Here is the evidences:

Details:

❯ pnpm run build

> @apps/[email protected] build /Users/rio/Projects/JS/web/apps/astro-blog
> astro build

11:02:51 PM [build] output target: server
11:02:51 PM [build] deploy adapter: @astrojs/deno
11:02:51 PM [build] Collecting build info...
11:02:51 PM [build] Completed in 280ms.
11:02:51 PM [build] Building server entrypoints...

🌼 daisyUI components 2.33.0  https://github.com/saadeghi/daisyui
  ✔︎ Including:  base, components, themes[1], utilities
  
11:02:54 PM [build] Completed in 2.23s.

 building client 
Completed in 295ms.


 finalizing server assets 

11:02:54 PM [build] Rearranging server assets...
@astrojs/sitemap: Skipped!
No pages found! We can only detect sitemap routes for "static" builds. Since you are using an SSR adapter, we recommend manually listing your sitemap routes using the "customPages" integration option.

Example: `sitemap({ customPages: ['https://example.com/route'] })`

Compressed about.39dc5942.css for 1 Bytes (1.61% reduction).
Compressed about.d36aaeb4.css for 2.36 KB (5.69% reduction).
Compressed blog.0b6c13c9.css for 1 Bytes (0.28% reduction).
Successfully compressed a total of 3 CSS files for 2.37 KB.
Compressed client.8e9befd7.js for 1.1 KB (0.79% reduction).
Compressed entry.mjs for 495.85 KB (50.75% reduction).
Successfully compressed a total of 2 JS files for 496.95 KB.
Compressed favicon.svg for 84 Bytes (9.62% reduction).
Successfully compressed a total of 1 SVG file for 84 Bytes.
✘ [ERROR] Could not resolve "stream"

    dist/server/entry.mjs:73:87825:
      73 │ ...ct.createElement("div")}),t,n,{}),r)throw r;return a}async function getNodeWritable(){let{Writable:e}=await import("stream");return e}async function renderToStaticMarkup$1(e,t,{default:n,...r},a){delete t.class;const o={};for(const[e,t]o...
         ╵                                                                                                                       ~~~~~~~~

  The package "stream" wasn't found on the file system but is built into node. Are you trying to
  bundle for node? You can use "platform: 'node'" to do that, which will remove this error.

 error   Build failed with 1 error:
  dist/server/entry.mjs:73:87825: ERROR: Could not resolve "stream"
  File:
    dist/server/entry.mjs
  Code:
      1623 |   }).join("");
    > 1624 |   let error = new Error(`${text}${summary}`);
           |               ^
      1625 |   error.errors = errors;
      1626 |   error.warnings = warnings;
      1627 |   return error;
    
  Stacktrace:
Error: Build failed with 1 error:
dist/server/entry.mjs:73:87825: ERROR: Could not resolve "stream"
    at failureErrorWithLog (/Users/rio/Projects/JS/web/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:1624:15)
    at /Users/rio/Projects/JS/web/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:1266:28
    at runOnEndCallbacks (/Users/rio/Projects/JS/web/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:1179:65)
    at buildResponseToResult (/Users/rio/Projects/JS/web/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:1264:7)
    at /Users/rio/Projects/JS/web/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:1377:14
    at /Users/rio/Projects/JS/web/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:678:9
    at handleIncomingPacket (/Users/rio/Projects/JS/web/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:775:9)
    at Socket.readFromStdout (/Users/rio/Projects/JS/web/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:644:7)
    at Socket.emit (node:events:527:28)
    at Socket.emit (node:domain:475:12)
    at addChunk (node:internal/streams/readable:315:12)
    at readableAddChunk (node:internal/streams/readable:289:9)
    at Socket.Readable.push (node:internal/streams/readable:228:10)
    at Pipe.onStreamRead (node:internal/stream_base_commons:190:23)

 ELIFECYCLE  Command failed with exit code 1.

Thank you, :)

https://github.com/one-suedwest/onesw-website/blob/main/src/pages/index.astro

If you look at that file at line 73, astro-compress will remove the space between the "<HiddenField />" and "an"

You can just clone that project and run "npm run build" and then open the generated index.html and you will see the issue.

I did not investigate this further, so i am sorry for the bad bug description.

I made sure that the problem does not exist when removing compress() from the vite config, so i am pretty sure that the issue is with astro-compress.

For some reason it insists on removing type="text" on inputs.

Now while I understand why it may do this as if your not specifying it as anything specific the generic fallback is text, but in my case it leads to this pretty annoying css bug for my contact page.

With Compress Active:

    <div class="col-12">
        <label class="js-input-group">Name <input data-required="" name="name" placeholder="Fill in your name" /> <span class="form__error"></span></label>
    </div>
    <div class="col-12">
        <label class="js-input-group">Email <input data-required="" name="email" placeholder="Fill in your email" /> <span class="form__error"></span></label>
    </div>

Without Compress:

    <div class="col-12">
        <label class="js-input-group">
            Name
            <input type="text" name="name" data-required="" placeholder="Fill in your name" />
            <span class="form__error"></span>
        </label>
    </div>

    <div class="col-12">
        <label class="js-input-group">
            Email
            <input type="text" name="email" data-required="" placeholder="Fill in your email" />
            <span class="form__error"></span>
        </label>
    </div>

I'm not really sure why it does this as I don't really see it doing much to reduce size.

Would it be possible to make this opt-out or opt-in in the config ?

from https://github.com/astro-community/astro-compress/issues/11

I'll take a closer look at the comments one another time. But it is set to false for now in v0.0.17

Hey, really neat plugin! Is there any way to exclude a single file or directory or pattern?

For example I want to exclude my favicon.png file from being compressed, but all other images should be compressed.

Is there any way to do so currently? Couldn't find anything in the docs, hence raising an issue.

Thanks

Hi,

We're having an issue on a build where astro-compress is reordering the CSS class declarations for a few DIVs where the order is critical to the responsive nature of the element. The site is using Bootstrap where class ordering for showing/hiding an DOM element on mobile matters. Compress is reordering all classes to be alphabetical (from what we're noticing which breaks our logic). Is there a way to disable this type of cleanup process?

Thanks!

Currently compressing animated webp result in a still image instead of the animation.

Any way to supply an regexp to match animated webp files would be brilliant.

Love this package!

But not the performance, especially when using it with lots of image files :(

It doesn't seem to be compressing in parallel.

A "make parallel" improvement to Astro's build command was made here. Perhaps something similar could be done here to improve the performance.

From a quick look at the code, perhaps the current bottleneck somewhere here?

Happy to take a stab at making some improvements on this once I can free-up some time.

It would be nice if there would a cache folder where the already compressed images are in so they won't need a new compression. It takes long to do the images on my website currently so deployment is slower.