What I do?

mkdir demo-practica
cd demo-practica
git init . # To avoid "Command failed: npx turbo run build" due to missing .git and speedup install
npx @practica/create-node-app immediate --install-dependencies

It returns the following

❣️ Command failed: npx turbo run build
order-service:build: ERROR: command finished with error: command (services/order-service) npm run build exited (2)
command (services/order-service) npm run build exited (2)

• Packages in scope: @practica/configuration-provider, @practica/error-handling, @practica/jwt-token-verifier, @practica/logger, @practica/validation, order-service
• Running build in 6 packages
@practica/configuration-provider:build: cache miss, executing 8bc8fcc61119b8e7
@practica/validation:build: cache miss, executing 88eb730c59e11ded
@practica/jwt-token-verifier:build: cache miss, executing f3ee7b28707cce64
@practica/jwt-token-verifier:build: 
@practica/jwt-token-verifier:build: > @practica/[email protected] build
@practica/jwt-token-verifier:build: > tsc
@practica/jwt-token-verifier:build: 
@practica/configuration-provider:build: 
@practica/configuration-provider:build: > @practica/[email protected] build
@practica/configuration-provider:build: > tsc
@practica/configuration-provider:build: 
@practica/validation:build: 
@practica/validation:build: > @practica/[email protected] build
@practica/validation:build: > tsc
@practica/validation:build: 
@practica/logger:build: cache miss, executing 910860c0ba87745c
@practica/logger:build: 
@practica/logger:build: > @practica/[email protected] build
@practica/logger:build: > tsc
@practica/logger:build: 
@practica/error-handling:build: cache miss, executing f45817537faf2b9a
@practica/error-handling:build: 
@practica/error-handling:build: > @practica/[email protected] build
@practica/error-handling:build: > tsc
@practica/error-handling:build: 
order-service:build: cache miss, executing 2e3fe06d10230f3f
order-service:build: 
order-service:build: > [email protected] build
order-service:build: > tsc
order-service:build: 
order-service:build: domain/new-order-use-case.ts(43,3): error TS2578: Unused '@ts-expect-error' directive.
order-service:build: domain/order-schema.ts(1,8): error TS1192: Module '"/home/thomasg/own-projects/demo-practica/default-app-name/services/order-service/node_modules/@practica/validation/index"' has no default export.
order-service:build: entry-points/api/server.ts(18,5): error TS2578: Unused '@ts-expect-error' directive.

 Tasks:    5 successful, 6 total
Cached:    0 cached, 6 total
  Time:    4m14.391s 

Then, I do

cd services/order-service/
npm i
npm run start:dev

It crashs at it inherits from the issues from the first run

> [email protected] start:dev
> PORT=0 PRETTY_PRINT=true nodemon start.ts

[nodemon] 2.0.16
[nodemon] to restart at any time, enter `rs`
[nodemon] watching path(s): *.*
[nodemon] watching extensions: ts,json
[nodemon] starting `ts-node start.ts`
/home/thomasg/own-projects/demo-practica/default-app-name/services/order-service/node_modules/ts-node/src/index.ts:820
    return new TSError(diagnosticText, diagnosticCodes);
           ^
TSError: ⨯ Unable to compile TypeScript:
entry-points/api/server.ts:18:5 - error TS2578: Unused '@ts-expect-error' directive.

18     // @ts-expect-error TODO: fix this
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    at createTSError (/home/thomasg/own-projects/demo-practica/default-app-name/services/order-service/node_modules/ts-node/src/index.ts:820:12)
    at reportTSError (/home/thomasg/own-projects/demo-practica/default-app-name/services/order-service/node_modules/ts-node/src/index.ts:824:19)
    at getOutput (/home/thomasg/own-projects/demo-practica/default-app-name/services/order-service/node_modules/ts-node/src/index.ts:1014:36)
    at Object.compile (/home/thomasg/own-projects/demo-practica/default-app-name/services/order-service/node_modules/ts-node/src/index.ts:1322:43)
    at Module.m._compile (/home/thomasg/own-projects/demo-practica/default-app-name/services/order-service/node_modules/ts-node/src/index.ts:1454:30)
    at Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Object.require.extensions.<computed> [as .ts] (/home/thomasg/own-projects/demo-practica/default-app-name/services/order-service/node_modules/ts-node/src/index.ts:1458:12)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19) {
  diagnosticCodes: [ 2578 ]
}
[nodemon] app crashed - waiting for file changes before starting...

PS: I'm a TypeScript noob so maybe obvious.

Update: version of Node = v16.13.0 using nvm on a Ubuntu 18.04 64 bits

This PR was automatically created by Snyk using the credentials of a real user.

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

• Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
  • src/code-templates/services/order-service/package.json
  • src/code-templates/services/order-service/package-lock.json

Vulnerabilities that will be fixed

With an upgrade:

Severity | Priority Score (*) | Issue | Breaking Change | Exploit Maturity :-------------------------:|-------------------------|:-------------------------|:-------------------------|:------------------------- | 636/1000
Why? Recently disclosed, Has a fix available, CVSS 7 | SQL Injection
SNYK-JS-SEQUELIZE-2959225 | No | No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information: 🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:

🦉 SQL Injection

Phase 1 of https://github.com/practicajs/practica/issues/12

• Update the syntax
• Fix types

Open issue: Some props in interactive-cli.tsx don't exist in the definition files, one of them is wrong, we need to find out which and fix then

I followed all the steps but on npm start i got this error:

npm start                                                                                                                                                              🔮  20:34:21

> [email protected] start
> PORT=3000 PRETTY_PRINT=false node .dist/start.js

node:internal/modules/cjs/loader:361
      throw err;
      ^

Error: Cannot find module '/Users/admin/evenzero/s4NDb0x/default-app-name/node_modules/@practica/logger/.dist/logger.wrapper.js'. Please verify that the package.json has a valid "main" entry
    at tryPackage (node:internal/modules/cjs/loader:353:19)
    at Function.Module._findPath (node:internal/modules/cjs/loader:566:18)
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:919:27)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/Users/admin/evenzero/s4NDb0x/default-app-name/services/order-service/.dist/start.js:3:18)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32) {
  code: 'MODULE_NOT_FOUND',
  path: '/Users/admin/evenzero/s4NDb0x/default-app-name/node_modules/@practica/logger/package.json',
  requestPath: '@practica/logger'
}
npm ERR! Lifecycle script `start` failed with error:
npm ERR! Error: command failed
npm ERR!   in workspace: [email protected]
npm ERR!   at location: /Users/admin/evenzero/s4NDb0x/default-app-name/services/order-service

OS: OSX 12.5.1 NODE: 16.15.0

🎯 Goal: - The ops/dev should be able to filter out logs and see all the entries of the same request. To achieve this, a unique correlation-id should be added to every request's log statement

🤔 Things to consider:

• The implementation should minimally impact the majority of the code: Probably just an initialization when a request starts, then the logger should try to identify whether some store/context/request-id exists and append to logs
• The standard mechanism in Node.js to achieve this is AsyncLocalStorage, we may use it directly or choose a library that abstracts it. If choosing a library, we may prefer those who use AsyncLocalStorage under the hood and follow our vendor pick guidelines
• Outgoing HTTP requests should contain the correlation id so other Microservice can reuse the same id
• This might have impact on performance - Could be useful to benchmark before and after

🏎 Quick iteration: There are many optimization and testing that can be done here. Let's start with a quick and simple iteration that contains the basics - Initialize a unique id on request start, ensure it's included in all the log entries of the request

This is to partially address #12 issue with a small scope for now. I also added the node-notifier package as a dev dependency because while it's listed as an option peer dependency when I ran the tests it caused an error indicating it was required. I hope this is ok but please let me know if there is a more appropriate approach to resolve that.

Hi, I guess you changed the location of some of your images, just a pr to fix them. got here from https://medium.com/autodesk-tlv/lerna-has-gone-which-monorepo-is-right-for-a-node-js-backend-fc075cad51b0

Added new color variation that fit dark and light theme as well. Design is not my strong side so if you think we need other colors, you are welcome to write the hex code. @goldbergyoni

🎯 Goal: - Boost the developer testing experience with reporters that show useful info: The slowest tests and those that were skipped. This might lead to an action by the viewer

🤔 More details:

• Jest slow test reporter
• Jest skipped test reporter
• Remember to test it, trigger a slow test and a skipped one

p.s. Share a picture here of the reports when done?

🎯 Goal: - Currently we generate code by just copying the code-templates folder. We need to run the code files through a templating library so it can be modified based on the user requests. In the future, this will rich logic (e.g., change web framework, avoid requiring files), for now we wish to start with a small step

✅Requirements:

• Add new CLI flag that we accept: --emit-best-practices (file: ./src/code-generator/cli-entry-point.ts). The code contains sections with 'best practices comments' that highlight good practices in the code. The user might want or avoid these parts in the code (see the file global-setup,. line 22)
• Choose a templating library like handlebars or other. Ensure to pick a very popular one
• Wrap these 'Best Practices' parts in the code with a conditional expression that your templating library provide. Example with handlebar
• Try generating code w/o this flag and ensure the output code is as expected
• Write tests against this new functionality. Too complex for now? You may defer this task or just ask for advice

• --orm flag can be set to prisma or sequelize
• Code generator is refactored to support various future features
• Component tests of generator
• Including one more entity/table to show association/relations - Country table
• Started to document the ORM decision and blog post (not ready)
• Repository pattern - the DAL entry point returns and gets POJO
• Sequelize is now strongly typed

• A dockerfile according to official Turborepo docs
• Change all internal deps to'*' instead to a specific version
• Remove all package-lock files, except for root

This PR doesn't handle production build - dev dependencies stay inside the docker, also source TS code.

(Also, need to review devDeps for all libraries, I believe some are wrong).

When validating input, it's also the right place to coerce value to their right domain type

For example, when getting req.body.userId - it's string by default, inside our domain it should be a number

Ajv supports this: https://ajv.js.org/coercion.html

Like any other decision, we wish to have a discussion and always compare the various options here

Which Node.js ORM should use? What important dimension should be evaluated?

Like any other decision, we wish to have a discussion and always compare the various options here

Which Node.js image our Dockerfile should inherit from? What important dimension should be evaluated?