Hi

This plugin doesn't seem to work with custom base path feature of Obsidian Git plugin. When it is set to a child folder and it is ran by Show Git Diff View command, it results in an error.

In my case, the child folder name is Subfolder and the custom base path option is set as such.

As you mention in the README.md, the diffs produced from the File Recovery snapshots are often more helpful than the diffs produced from Obsidian Sync versions since they're less frequent. The same is true of Git commits to a larger extent, since a Git commit is only produced when the user intentionally makes one - the revision history is deliberately curated and annotated with descriptive messages, rather than automatically generated at set intervals.

Hence it'd be really nice to see diffs and history produced by asking Git how the active file has changed! This oddly enough isn't a feature of the existing Obsidian Git plugin, despite being a common operation that you can perform using Git integration in various text editors and IDEs.

I don't know how well it'll work on mobile, nor whether you'd need to rely on Obsidian Git being present, but it'd still be a really nice feature to have on desktop. 🐱

more like added upon the existing css instead of properly modifying it, so it's a bit of a quick-and-dirty solution, but it improves the visuals tremendously, already. Should be integrated better with the existing css at some point in the future.

Now it can only be used on the horizontal screen on mobile devices, which is not convenient enough. Is it possible to optimize the interface of mobile devices?

https://github.com/kometenstaub/obsidian-version-history-diff/blob/d9b5f8fbe0dab345eb05c5bf43d8375dfb49b228/src/abstract_diff_view.ts#L173

There is no need to find the div, only its index.

Hi, thanks for creating this plugin, I love how changes are presented (left and right column for comparison).

I am using git diff and wonder why is Obsidian Git plugin required for this one to work? Isn't it enough that there is git in the folder? I would appreciate some explanation on how this works.

I got a vault which contains several sub-vaults. And I plan to enable git version control for that. Obsidian Git and this plugin were installed in root vault and working great. I was able to do backups and do diffs on any vault file. Now I want to do the same in the sub-vaults by installed the two plugins there. But I got mixed results there. First the diff by this plugin is failing with following error log.

plugin:obsidian-git:30828 git obsidian error: fatal: ambiguous argument 'path/to/note.md': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

plugin:obsidian-git:23818 Uncaught (in promise) Error: fatal: ambiguous argument 'path/to/note.md': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

    at Object.action (plugin:obsidian-git:23818:25)
    at PluginStore.exec (plugin:obsidian-git:23843:25)
    at eval (plugin:obsidian-git:21430:43)
    at new Promise (<anonymous>)
    at GitExecutorChain.handleTaskData (plugin:obsidian-git:21428:16)
    at GitExecutorChain.eval (plugin:obsidian-git:21412:44)
    at Generator.next (<anonymous>)
    at fulfilled (plugin:obsidian-git:20261:24)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
action @ plugin:obsidian-git:23818
exec @ plugin:obsidian-git:23843
eval @ plugin:obsidian-git:21430
handleTaskData @ plugin:obsidian-git:21428
eval @ plugin:obsidian-git:21412
fulfilled @ plugin:obsidian-git:20261
processTicksAndRejections @ node:internal/process/task_queues:96
await in processTicksAndRejections (async)
e.open @ app.js:1
openGitDiffModal @ plugin:obsidian-version-history-diff:452
eval @ plugin:obsidian-version-history-diff:452
TB @ app.js:1
e.executeCommand @ app.js:1
e.executeCommandById @ app.js:1
eval @ plugin:cmdr:7
e.handleEvent @ app.js:1

On the other hand, the diff command in Git plugin worked fine.

Please let me know if there is any workaround or fix to make it working.

Thx

Hello

Show Git Diff view for active file works well without an issue. However, Show Sync history for active file and Show Sync diff view for active file don't work at all showing an empty window. (BTW, I don't exactly know what they do actually)

The developer's console shows the following error:

Uncaught (in promise) TypeError: Cannot read properties of null (reading 'listHistory')
    at t.<anonymous> (app.js:1:1970557)
    at app.js:1:235078
    at Object.next (app.js:1:235183)
    at s (app.js:1:233922)

Obsidian Git version : 1.28.0 Version History Diff version : 2.0.5 Obsidian App version : 0.15.9 OS : Windows 10 21H2

I use Syncthing to sync between devices. Is it possible to view different versions of the files? Or at least let me open two files on my own in Obsidian and diff them?

After renaming a file with git mv, clicking on an old version for getting the file content of that version yields this error.

I would need a way to determine what the file name was before the renaming. The git log API does not provide any info concerning this.

Fixing this should work by refactoring the git view to not work on file contents, and instead use the hashes to get the diffs.

cc @Vinzent03 - What is your take on that?