framework-agnostic styled alert system for javascript

Hey,

I needed to add support for changing the order of the prompt / confirm buttons, so I made it a param "reverseButtons", that if passed as true, will make the buttons be rendered in the opposite order.

I also cleaned up the code a bit, and made it validate with JSLint, which I think is a good way of ensuring code readability and bug-freeness.

What do you think?

-Carlos

Hi I am planning to integrate this library. Some of my users still uses IE8. what is the plan and when you are adding the support for IE8 ?

Thanks -Divagar

Wrong behavior when press Enter or Space in FF and Chrome:

• Alert doesn't close in both browsers.
• Confirm doesn't close in FF pressing Enter or Space.
• When press Enter in Chrome prompt canceled. In FF it's OK.

Hey,

I was testing smoke.js on a pre-prodution website and I noticed that it was taking a long time for the dialogs to be available because of a DNS problem with our pre-production CDN. This was because window.onload was being used, and that only fires after the last asset is loaded.

I decided to use a very minimal DOMContentLoaded cross-browser library made by Diego Perini (https://github.com/dperini/ContentLoaded), it's also MIT licensed, so it's compatible) to fix this problem.

This way, smoke dialogs are available as soon as the DOM is ready.

Since I put it in a self-calling lambda, the global namespace won't be polluted, and only window.smoke will be defined.

I also fixed a couple of tabs mixed with spaces indentation issues.

Hope you don't mind the usage of an external library, it's very minimal and doesn't pollute the global namespace.

Carlos

Hi there. I changed your basic layout to support multiple messages (stacked). Now you don't need to init a container. Each message builds one smoke-container with a timestamp-based id. You must minify the js again.

Is it possibile to set a default value for "ok" and "cancel" buttons?

I notice that in your code ( https://github.com/hxgf/smoke.js/blob/master/smoke.js#L52 ) you have "OK" and "Cancel" labels, is it possible to overwrite this?

I have a smoke.confirm dialog with ok and cancel buttons. I would like to force users to click on ok or cancel buttons only - not allow them to click on the background or anywhere else on the page.

Is this possible?

IE6/7/8 are still browsers that are used today. (Unfortunately) Alerts and user messages are important, even a simple 'alert()' will suffice here :)

What do you think?

I needed these features in a project I'm working on and I thought they'd be useful for the general public:

• You can pass a "value" param (along with the other options, such as the button labels) when calling smoke.prompt and the input will be pre-filled with it.
• You can pass a callback as the third parameter for smoke.alert (thus, not breaking backwards-compatibility), and the callback will be called whenever the alert is closed

I tried to use smoke.js in my project but hit problems where it would silently fail if I tried to show a smoke.alert immediately. I was triggering from document.ready(), but it seems I need to wait for window.load() before using smoke.js.

It might help others if this were documented somewhere. Thanks.

The readme should include a list of browsers this script is intended to work with; this way we'll if a incompatibility issue found is a bug or not a feature.

Just simply replace button_1, button_2, button_3 with array:

		buttons: [
						{value : '11', name: "Option 33"},
						{value : '20', name: "Option 66"},
						{value : '61', name: "Option 91"},
						{value : '42', name: "Option 55"},
						{value : '99', name: "Option 42"}
					]

callback handler returns reference to the button. value can be accessed by reading data-quiz-value property

smoke.quiz("Select an option:", function(e){ if (e == 1){

}

}, { options: [ {value: 1, label: "Option 1"}, {value: 2, label: "Option 2"}, {value: 3, label: "Option 3"} ], button_cancel: "Nothing" });

The quiz function is useless for me because I cannot display more than 3 options. The list of options should be customizable. For instance, the quiz function could receive a parameter options = [{value: 1, label: "Option 1"}, {value: 2, "Option 2"}]

Hi,

the bower.json file contains the main field which should not be used as desciption. Instead of a description it should list the main files (once per type) See: https://github.com/bower/spec/blob/master/json.md

Pull request: https://github.com/hxgf/smoke.js/pull/60

Hi,

the minified version is missing a semicolon at the end.

You fixed that once by a0cce74f3da89a65139f19de795e3d3c1d8640e1 but the semicolon is missing again in release 0.1.3 and master branch. I dont know how you are generating the minified version cause there is no script so you have to fix that.

It can cause errors if you concat multiple js scripts and smoke.js is followed by another one.

18133Uncaught TypeError: (intermediate value)(intermediate value)(intermediate value)(...) is not a function