RE: #447

OK, I've regressed on generators quite a bit. I was considering the generator for react-native-elements and it seemed kinda complicated, so I figured, let's go in-house! So I was considering maps. But woah... that's a thick one.

After talking with @kevinvangelder - we realized this was starting too high. People want to change our screen generators, and our screen generators should be overridable, and should work the same way as a map generator etc.

Here's the proposed first generator concept workflow: In this example, a user does NOT have screen generators, but does have the latest ignite. (Now obviously some generators, like screens should already be there)

Adding a generator

1. User types ignite add screen-generators
2. Ignite looks for an npm package named ignite-screen-generators and installs it.
3. Ignite then runs the initialize function on that package.
4. The initialize function then adds the supported generators to the .ignite file's available generators section. (Enforcing friendly overwriting is key)
5. Any application changes are then made (adding permissions, npm i, npm link etc)

The app is then ready.

Using a generator that has been installed.

1. User types ignite generate Screen TacosLocos
2. The generate command checks local generators from .ignite file
3. CLI calls the given generator (this will take some research as generators ALSO have a naming convention, which we will need to assuage).
4. The given generator then runs with all params passed along.

Feedback please, and then I plan on implementing this.

I don't have any screen (except launch Screen with Rocket icon) when I create ignite new myapp I choose all yes on generate CLI Screen (already choose dev mode) But i don't have "OPEN DEVSCREENS" button like a in this vdo (Building a React Native App in Under 15 Minutes)

Running ignite new ignite_app on windows produces the following error:

   🔥 Igniting app
   ☕️ Baking CocoaPods

C:\Users\User\scoop\persist\nodejs-lts\bin\node_modules\ignite-cli\node_modules\gluegun\build\index.js:13
    throw up;
    ^
yarn run v1.22.5
,error Command "format" not found.
,info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

(Use `node --trace-uncaught ...` to show where the exception was thrown)

Steps to reproduce

1. Run: ignite new ignite_app

<Navigator> is sun-setting.

<NavigatorExperimental> is transitioning in (the name will change).

I'm hearing nothing but great things about it. Redux like apparently.

Anyone up for spiking it through before its officially released? This is my only hesitation in picking a 3rd party library @ryanlntn for Navigation routing & presentation.

It's all about to change.

I ran ignite new app and got the following error:

`✔︎ Linking with rnpm fs.js:584 return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode); ^

Error: ENOENT: no such file or directory, open 'dmx-native-mobile-redux/android/app/src/main/AndroidManifest.xml' at Error (native) at Object.fs.openSync (fs.js:584:18) at Object.fs.readFileSync (fs.js:431:33) at Object.insertInFile (/Users/erose2/.nvm/versions/node/v5.4.0/lib/node_modules/generator-react-native-ignite/utilities.js:21:27) at performInserts (/Users/erose2/.nvm/versions/node/v5.4.0/lib/node_modules/generator-react-native-ignite/app/index.js:60:13) at AppGenerator._updateAndroidManifest (/Users/erose2/.nvm/versions/node/v5.4.0/lib/node_modules/generator-react-native-ignite/app/index.js:328:7) at ChildProcess. (/Users/erose2/.nvm/versions/node/v5.4.0/lib/node_modules/generator-react-native-ignite/app/index.js:378:18) at emitTwo (events.js:87:13) at ChildProcess.emit (events.js:172:7) at maybeClose (internal/child_process.js:821:16)`

It would be great to be able to use Expo with Ignite.

Is it possible to write a boilerplate that combines the ignite-ir-boilerplate-2016 with what create-react-native-app generates?

I installed the react-native-cli and did a react-native init testApp followed by react-native run-ios and all the world was good :)

Then I cd ~ && npm install react-native-ignite -g followed by ignite new testApp which had me left with this:

$ ignite new testApp
This command requires yo to be installed.
Installing yo...
(node:55281) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
npm WARN deprecated [email protected]: this package has been reintegrated into npm and is now out of date with respect to npm
/Users/walther/.node/bin/yo-complete -> /Users/walther/.node/lib/node_modules/yo/lib/completion/index.js
/Users/walther/.node/bin/yo -> /Users/walther/.node/lib/node_modules/yo/lib/cli.js

> [email protected] postinstall /Users/walther/.node/lib/node_modules/yo
> yodoctor


Yeoman Doctor
Running sanity checks on your system

✔ Global configuration file is valid
✔ Node.js version
✔ No .bowerrc file in home directory
✔ No .yo-rc.json file in home directory
✔ npm version
✔ NODE_PATH matches the npm root

Everything looks all right!
/Users/walther/.node/lib
└── [email protected] 

🔥 Setting testApp on FIRE! 🔥
-----------------------------------------------
  (                  )   (                   
  )\ )   (        ( /(   )\ )    *   )       
 (()/(   )\ )     )\()) (()/(  ` )  /(   (   
  /(_)) (()/(    ((_)\   /(_))  ( )(_))  )\  
 (_))    /(_))_   _((_) (_))   (_(_())  ((_) 
 |_ _|  (_)) __| | \| | |_ _|  |_   _|  | __|
  | |     | (_ | | .` |  | |     | |    | _| 
 |___|     \___| |_|\_| |___|    |_|    |___|
-----------------------------------------------

An unfair headstart for your React Native apps.
https://infinite.red/ignite

-----------------------------------------------
Igniting testApp

𝗫 Missing react-native - 'npm install -g react-native-cli'
$ npm list react-native-cli
/Users/walther
└── [email protected] 

$ 

Finally I tried to verify that the react-native-cli was actually there - which npm list react-native-cli seems to support ? So now I'am at a loss as to what next, debugging-wise?

Oh - and ignite doctor tells me this:

$ ignite doctor
/Users/walther/.node/lib/node_modules/react-native-ignite/node_modules/ramda/dist/ramda.js:4307
                return str.trim();
                          ^

TypeError: Cannot read property 'trim' of null
    at Object.trim (/Users/walther/.node/lib/node_modules/react-native-ignite/node_modules/ramda/dist/ramda.js:4307:27)
    at Object.f1 [as trim] (/Users/walther/.node/lib/node_modules/react-native-ignite/node_modules/ramda/dist/ramda.js:446:27)
    at Command.<anonymous> (/Users/walther/.node/lib/node_modules/react-native-ignite/index.js:116:36)
    at Command.listener (/Users/walther/.node/lib/node_modules/react-native-ignite/node_modules/commander/index.js:301:8)
    at emitTwo (events.js:106:13)
    at Command.emit (events.js:191:7)
    at Command.parseArgs (/Users/walther/.node/lib/node_modules/react-native-ignite/node_modules/commander/index.js:615:12)
    at Command.parse (/Users/walther/.node/lib/node_modules/react-native-ignite/node_modules/commander/index.js:458:21)
    at Object.<anonymous> (/Users/walther/.node/lib/node_modules/react-native-ignite/index.js:133:21)
    at Module._compile (module.js:541:32)
$ 

First of all - absolutely awesome love what you guys have done here.

I have noticed your Saga's use yield call rather than yield fork. It is my understanding this is not the right practice unless you are using the newer "takeEvery" because any actions that occur before the call has completely finished will not be received - in this case fork should instead be used.

I could be incorrect but this is how I had to set things up in our React App otherwise many issues would arise. Perhaps either the new takeEvery commands should be used or the generator / example should show fork to be inline with the Saga best practices?

Granted I understand something like "logiN' isn't gonna receive multiple calls like this, but for a boilerplate that is meant to teach best practices, I can see how this would end up causing someone that is newer to Sagas have issues that are fairly hard to debug / understand.

// a daemonized version which waits for LOGIN_ATTEMPT signals
export function * watchLoginAttempt () {
  // daemonize
  while (true) {
    // wait for LOGIN_ATTEMPT actions to arrive
    const { username, password } = yield take(Types.LOGIN_ATTEMPT)
    // call attemptLogin to perform the actual work
    yield call(attemptLogin, username, password)
  }
}

Changes To:

// a daemonized version which waits for LOGIN_ATTEMPT signals
export function * watchLoginAttempt () {
  // daemonize
  while (true) {
    // wait for LOGIN_ATTEMPT actions to arrive
    const { username, password } = yield take(Types.LOGIN_ATTEMPT)
    // call attemptLogin to perform the actual work
    yield fork(attemptLogin, username, password)
  }
}

What's going on? ignite-cli cannot init/new project

Steps to reproduce

1. just run npx ignite-cli new MyApp `

dengjianyuan@Jerrys-MacBook-Pro ~ npx ignite-cli new MyApp
· · · · · · · · · · · · · · · · · · 🔥 Ignite 🔥 · · · · · · · · · · · · · · · · · ·

█ Creating MyApp using Ignite 7.10.6
█ Powered by Infinite Red - https://infinite.red
█ Using ignite-cli with yarn
█ Bundle identifier: com.MyApp
────────────────────────────────────────────────

🔥 Igniting app
🖨  3D-printing a new React Native app
⠴ Unboxing npm dependencies

/Users/dengjianyuan/.npm/_npx/58859/lib/node_modules/ignite-cli/node_modules/gluegun/build/index.js:13 throw up; ^ warning expo > [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details. warning expo > expo-constants > [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details. warning expo > expo-file-system > [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details. warning expo > fbemitter > fbjs > [email protected]: core-js@<3.4 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js. warning react-native > @react-native-community/cli-platform-ios > xcode > [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details. warning react-native > react-native-codegen > jscodeshift > micromatch > snapdragon > [email protected]: See https://github.com/lydell/source-map-resolve#deprecated warning react-native > @react-native-community/cli > @react-native-community/cli-plugin-metro > metro-core > jest-haste-map > [email protected]: some dependency vulnerabilities fixed, support for node < 10 dropped, and newer ECMAScript syntax/features added warning react-native > @react-native-community/cli > @react-native-community/cli-plugin-metro > metro > metro-minify-uglify > [email protected]: support for ECMAScript is superseded by uglify-js as of v3.13.0 warning react-native > react-native-codegen > jscodeshift > micromatch > snapdragon > source-map-resolve > [email protected]: https://github.com/lydell/resolve-url#deprecated warning react-native > react-native-codegen > jscodeshift > micromatch > snapdragon > source-map-resolve > [email protected]: Please see https://github.com/lydell/urix#deprecated warning react-native > react-native-codegen > jscodeshift > micromatch > snapdragon > source-map-resolve > [email protected]: See https://github.com/lydell/source-map-url#deprecated warning @storybook/react-native-server > [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details. warning @storybook/react-native-server > webpack > watchpack > watchpack-chokidar2 > [email protected]: Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies warning @storybook/react-native-server > webpack > watchpack > watchpack-chokidar2 > chokidar > [email protected]: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2. warning @storybook/react-native-server > @storybook/core > react-dev-utils > fork-ts-checker-webpack-plugin > [email protected]: Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies warning @storybook/react-native-server > @storybook/core > webpack-dev-middleware > webpack-log > [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details. warning @storybook/react-native-server > @storybook/core > webpack-hot-middleware > [email protected]: The querystring API is considered Legacy. new code should use the URLSearchParams API instead. warning @storybook/react-native-server > webpack > node-libs-browser > url > [email protected]: The querystring API is considered Legacy. new code should use the URLSearchParams API instead. warning @storybook/react-native-server > @storybook/ui > @storybook/components > [email protected]: You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1 warning @storybook/react-native-server > @storybook/ui > @storybook/components > react-syntax-highlighter > [email protected]: Support has ended for 9.x series. Upgrade to @latest warning @storybook/react-native-server > @storybook/ui > @storybook/components > react-popper-tooltip > react-popper > [email protected]: You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1 warning @storybook/react-native-server > @storybook/ui > @storybook/components > react-syntax-highlighter > lowlight > [email protected]: Version no longer supported. Upgrade to @latest warning detox > tempfile > [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details. warning solidarity > gluegun > apisauce > [email protected]: Critical security vulnerability fixed in v0.21.1. For more information, see https://github.com/axios/axios/pull/3410 warning solidarity > gluegun > enquirer > [email protected]: Critical bug fixed in v3.0.1, please upgrade to the latest version. warning solidarity > gluegun > prompt-autocompletion > prompt-choices > [email protected]: Critical bug fixed in v3.0.1, please upgrade to the latest version. warning solidarity > gluegun > enquirer > prompt-question > prompt-choices > [email protected]: Critical bug fixed in v3.0.1, please upgrade to the latest version. warning "react-native > react-native-codegen > [email protected]" has unmet peer dependency "@babel/preset-env@^7.1.6". warning "reactotron-react-native > [email protected]" has incorrect peer dependency "react@^16.8.1". warning "reactotron-react-native > [email protected]" has incorrect peer dependency "react-native@^0.62.0". warning " > @rnx-kit/[email protected]" has unmet peer dependency "metro-config@>=0.58.0". warning "@rnx-kit/metro-config > @rnx-kit/[email protected]" has unmet peer dependency "metro-react-native-babel-preset@". warning "@storybook/react-native-server > @storybook/[email protected]" has unmet peer dependency "regenerator-runtime@". warning "@storybook/react-native > @storybook/addons > @storybook/api > @reach/[email protected]" has incorrect peer dependency "[email protected] || 16.x || 16.4.0-alpha.0911da3". warning " > [email protected]" has unmet peer dependency "webpack@>=2". warning " > [email protected]" has unmet peer dependency "jest-environment-node@>=25.0.0". warning " > [email protected]" has unmet peer dependency "mocha@>=6.0.0". error Command failed with exit code 1.

(Use node --trace-uncaught ... to show where the exception was thrown) `

npx ignite-cli doctor results: ~ npx ignite-cli doctor
`System platform darwin
arch x64
cpu 12 cores Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz directory dengjianyuan /Users/dengjianyuan

JavaScript (and globally-installed packages) node 14.17.0 /Users/dengjianyuan/.nvm/versions/node/v14.17.0/bin/node npm 6.14.13 /Users/dengjianyuan/.nvm/versions/node/v14.17.0/bin/npm
@tarojs/cli 3.3.9
@vue/cli 4.5.14
eBriefcase 0.0.5
expo-cli 4.13.0
npm 6.14.13
yarn 1.22.10
yarn 1.22.10 /Users/dengjianyuan/.nvm/versions/node/v14.17.0/bin/yarn create-strapi-app 3.6.3
ignite-cli 3.5.2
storybook 5.3.19
wml 0.0.83
pnpm - not installed

Ignite ignite-cli 7.10.6 /Users/dengjianyuan/.npm/_npx/75845/bin/ignite
ignite src build /Users/dengjianyuan/.npm/_npx/75845/lib/node_modules/ignite-cli/build

Android java 1.8.0_252 /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/bin/java android home - /Users/dengjianyuan/Library/Android/sdk

iOS xcode 13.1
cocoapods 1.10.1 /usr/local/bin/pod `

Error in create new app.

I'm new with Ignite, i want to create a new project and it gives me this error. Any solution?

Steps to reproduce

1. npx ignite-cli new APP

What's going on? undefined is not a function

Steps to reproduce init a new app and run

This happens both on Android and iOS

ignite doctor results: System platform darwin
arch x64
cpu 4 cores Intel(R) Core(TM) i5-3230M CPU @ 2.60GHz
directory /Users/kruyvanna/Projects/Learn/Ignite/Test

JavaScript node 8.9.1 /usr/local/bin/node
npm 5.6.0 /usr/local/bin/npm
yarn 1.3.2 /usr/local/bin/yarn

React Native react-native-cli 2.0.1
app rn version 0.50.4

Ignite ignite 2.0.0 /usr/local/bin/ignite

Android java 1.8.0_152 /usr/bin/java
android home - undefined

iOS xcode 9.2

Please verify the following:

• [ ] yarn test jest tests pass with new tests, if relevant
• [ ] README.md has been updated with your changes, if relevant

Describe your PR

There is a scripting tool called zx that is a hybrid between bash and node scripting. It has a lot of dev experience and productivity of gluegun.

To play around with it, I decided to implement some of the existing generators in ignite. This was relatively simple to do. And with this extension, you can even get syntax highlighting with the js strings.

This may be a nice alternative API for generators so that ignite users can update these scripts as a project grows.

Initially, I thought about creating an alternative typescript generator API that I create a proof of concept of. But the nice thing about using zx is that it would pretty much remove any maintenance cost with generators from ignite. Additionally, these scripts are portable, so they can dropped into existing projects.

I will leave this PR here for discussion and an artifact of that exploration

I think need to make additional props (to avoid using styles) for underline, strike, and italic (textDecorationLine), that's basic for text like bold.

A long time ago, when i used ignite version that include react native 0.62.x, the apk size just around 19-20mb, and when i released on playstore, its just 8-10mb. And now i cannot believe that the apk file over 50mb(on my project 66mb) for react native version 0.69. Do you guys have any ideals for reduce the apk file? This is what i did for reduce it:

• enable proguard
• enable r8(by default)
• enable engine hermes
• remove file not use(like image...)

And i think the reason come from expo core, should we remove expo module for react native CLI?

Per #2308, specifically this comment, it would be good to get type-checking on the $sizeStyles object.

Currently, we're using as TextStyle, which just coerces but doesn't typecheck the object.

@yulolimum had some ideas in this comment as well.

I remember seeing some sort of solution that involved an identity function that took a generic type, but I'm having trouble tracking it down. I'll post it here if I find it.

That's really confusing in one place use extraLarge in another place it's just xl. I think naming is much more intuitive in fonts.

I propose adding more x ) like xxxs and xxxl, for extra small and extra big sizes.

The current demo really is the best of all time.