What are the steps to reproduce?

Import the flow in: https://cookbook.nodered.org/mqtt/connect-to-broker, start any MQTT broker (e.g. Mosquitto) and deploy EDIT: The error is not evident with Mosquitto, as initially reported, but e.g. with https://github.com/martin-doyle/node-red-contrib-aedes.

What happens?

Every time the flow is deployed, the MQTT in node gets stuck for a while, then output: "Error stopping node: Close timed out"

What do you expect to happen?

The MQTT in node is immediately closed without errors and the flow is deployed without error and time wasting.

Please tell us about your environment:

• [ ] Node-RED version: 1.3.2
• [ ] Node.js version: 14.6.1
• [ ] npm version:
• [ ] Platform/OS: Win 10
• [ ] Browser: Chrome

Current Behavior

Hello, Short: Access to a GIT system using ssh-key based authentication seems to fail because the username contains the "@" character.

I use Header based authentication on node-red and my usernames have the format of an email adress (e.g. [email protected]). If we try to authenticate using ssh-key based authentication it failes.

Expected Behavior

Expected behaviour is, that ssh-key authentication works.

Steps To Reproduce

Set username (e.g. using reverse-proxy header variable to an email adress and try to fetch branches of a GIT system (e.g. gitea). Configure in the project an ssh based git access ssh://git@... or git@... Set User Email and Name, generate a key. Try to push to the git repo (or first fetch branches). It will fail.

There are only these log messages:

4 Nov 16:13:26 - [trace] runGitCommandWithAuth {}
4 Nov 16:13:26 - [trace] git["fetch","origin"]

What I tried: a) Manually try an ssh:

 ssh -i /home/nodered/.node-red/projects/.sshkeys/Firstname-secondname.lastname\@example.com_gitea_key [email protected]
LDAP Login enabled
PTY allocation request failed on channel 0
Hi there, Firstname-secondname.lastname_example.com! You've successfully authenticated with the key named TheHiveWorkflow, but Gitea does not provide shell access.
If this is unexpected, please log in with password and setup Gitea under another user.
Connection to [email protected] closed.

b) Copied private-key /home/nodered/.node-red/projects/.sshkeys/[email protected]_gitea_key to /home/nodered/.ssh/id_rsa ==> Everything works

c) I tried to output auth.key_path arround line 577 in: /usr/lib/node-red/node_modules/@node-red/runtime/lib/storage/localfilesystem/projects/git/index.js but it was not set (even it was configured):

Example flow

n.a.

Environment

• Node-RED version: 2.1.3
• Node.js version: v14.17.6
• npm version: 6.14.15
• Platform/OS: RHEL7
• Browser: Chrome
• git version: git version 2.31.1

• [ ] Bugfix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)

Proposed changes

Add proposed mqtt-control as specified here and discussed here

Implementation notes

I will keep this light as I know your time is limited...

There is one major difference from the spec - that is using msg.action (string) to simplify the action (as proposed in the forum thread). That means the associated properties are now in a separate object. This permits us to provide a visual cue on what the "actions" are. Additionally, there is a dynamic tip to which property is required when the user selects an action. Lastly, the built in help details what property is used.

Checklist

• [x] I have read the contribution guidelines
• [x] For non-bugfix PRs, I have discussed this change on the forum/slack team.
• [x] I have run grunt to verify the unit tests pass
• [ ] I have added suitable unit tests to cover the new/changed functionality

Demo flow to help test the functionality...

[{"id":"8c8b272.301f1d8","type":"inject","z":"4b3f21a3.ba434","name":"sub multiple [{test/test3},{test/test4},\"test/test5\"]","props":[{"p":"action","v":"subscribe","vt":"str"},{"p":"subscription","v":"[{\"topic\":\"test/test3\",\"datatype\":\"json\",\"qos\":0},{\"topic\":\"test/test4\",\"datatype\":\"utf8\",\"qos\":1},\"test/test5\"]","vt":"json"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","x":1300,"y":1380,"wires":[["d835cbd0.207b28"]]},{"id":"18724d21.34e9a3","type":"debug","z":"4b3f21a3.ba434","name":"MQTT messages","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","statusVal":"","statusType":"auto","x":1570,"y":2020,"wires":[]},{"id":"15399895.933047","type":"inject","z":"4b3f21a3.ba434","name":"test/test1 (datatype auto)","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"test/test1","payload":"{\"isJSON\":true}","payloadType":"json","x":730,"y":1800,"wires":[["2bb55579.21c2aa"]]},{"id":"e24875ef.314bd8","type":"inject","z":"4b3f21a3.ba434","name":"test/test2 (datatype json)","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"test/test2","payload":"{\"key\": \"value\"}","payloadType":"json","x":730,"y":1840,"wires":[["2bb55579.21c2aa"]]},{"id":"2bb55579.21c2aa","type":"mqtt out","z":"4b3f21a3.ba434","name":"","topic":"","qos":"","retain":"","respTopic":"","contentType":"","userProps":"","correl":"","expiry":"","broker":"7bab12a9.b04bcc","x":990,"y":1880,"wires":[]},{"id":"ef265819.c24d98","type":"inject","z":"4b3f21a3.ba434","name":"sub single string \"test/test1\"","props":[{"p":"action","v":"subscribe","vt":"str"},{"p":"subscription","v":"test/test1","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","x":1240,"y":1300,"wires":[["d835cbd0.207b28"]]},{"id":"105e4283.278b6d","type":"inject","z":"4b3f21a3.ba434","name":"sub single object {test/test2}","props":[{"p":"action","v":"subscribe","vt":"str"},{"p":"subscription","v":"{\"topic\":\"test/test2\",\"datatype\":\"json\",\"qos\":0}","vt":"json"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","x":1240,"y":1340,"wires":[["d835cbd0.207b28"]]},{"id":"8900a759.0712a8","type":"inject","z":"4b3f21a3.ba434","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"test/test3","payload":"{\"key\": \"value\"}","payloadType":"json","x":730,"y":1880,"wires":[["2bb55579.21c2aa"]]},{"id":"ca90115a.593aa","type":"inject","z":"4b3f21a3.ba434","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"test/test4","payload":"{\"key\": \"value\"}","payloadType":"json","x":730,"y":1920,"wires":[["2bb55579.21c2aa"]]},{"id":"400e95b5.50d65c","type":"inject","z":"4b3f21a3.ba434","name":"test/test5 (with v5 props)","props":[{"p":"payload"},{"p":"topic","vt":"str"},{"p":"userProperties","v":"{\"fred\":\"123\"}","vt":"json"},{"p":"responseTopic","v":"test/reply","vt":"str"},{"p":"contentType","v":"JSON","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"test/test5","payload":"{\"key\": \"value\"}","payloadType":"json","x":730,"y":1960,"wires":[["2bb55579.21c2aa"]]},{"id":"e7e02690.7991b8","type":"inject","z":"4b3f21a3.ba434","name":"unsub single test/test1","props":[{"p":"action","v":"unsubscribe","vt":"str"},{"p":"subscription","v":"{         \"topic\": \"test/test5\",         \"datatype\": \"json\",         \"qos\": 0     }","vt":"json"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","x":1220,"y":1480,"wires":[["1e612121.aa6c4f"]]},{"id":"42888285.314b4c","type":"inject","z":"4b3f21a3.ba434","name":"list subscriptions","props":[{"p":"action","v":"list","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","x":700,"y":1460,"wires":[["47c8c347.17c61c"]]},{"id":"3e957fe6.3a1e8","type":"inject","z":"4b3f21a3.ba434","name":"unsub all [\"test/test1\", ... , \"test/test5\"]","props":[{"p":"action","v":"unsubscribe","vt":"str"},{"p":"subscription","v":"[\"test/test1\",\"test/test2\",\"test/test3\",\"test/test4\",\"test/test5\"]","vt":"json"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","x":1270,"y":1520,"wires":[["1e612121.aa6c4f"]]},{"id":"b7bf8c92.303c3","type":"debug","z":"4b3f21a3.ba434","name":"control messages","active":false,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","statusVal":"","statusType":"auto","x":1570,"y":2060,"wires":[]},{"id":"139f8b7c.4fbf15","type":"comment","z":"4b3f21a3.ba434","name":"publish to regular mqtt out","info":"","x":730,"y":1760,"wires":[]},{"id":"357dd410.c98afc","type":"comment","z":"4b3f21a3.ba434","name":"Unsubscribe topics","info":"","x":1210,"y":1440,"wires":[]},{"id":"ff246de5.2a665","type":"comment","z":"4b3f21a3.ba434","name":"Subscribe topics","info":"","x":1200,"y":1260,"wires":[]},{"id":"e12462e5.a3056","type":"inject","z":"4b3f21a3.ba434","name":"connect","props":[{"p":"action","v":"connect","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","x":670,"y":1340,"wires":[["47c8c347.17c61c"]]},{"id":"558d476b.0ced78","type":"inject","z":"4b3f21a3.ba434","name":"disconnect","props":[{"p":"action","v":"disconnect","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","x":680,"y":1300,"wires":[["47c8c347.17c61c"]]},{"id":"7fe8eb8f.031624","type":"inject","z":"4b3f21a3.ba434","name":"connect with opts V1","props":[{"p":"options","v":"{\"url\":\"mqtt://192.168.1.50:1883\",\"birth\":{\"topic\":\"test/lwt/birth-V1\",\"qos\":0,\"retain\":false,\"payload\":\"birth-V1\",\"properties\":{\"correlationData\":\"hello birth-V1\",\"userProperties\":{\"prop1\":\"birth-V1\"},\"contentType\":\"application/text\"}},\"close\":{\"topic\":\"test/lwt/close-V1\",\"qos\":0,\"retain\":false,\"payload\":\"close-V1\",\"properties\":{\"correlationData\":\"hello close-V1\",\"userProperties\":{\"prop1\":\"close-V1\"},\"contentType\":\"application/text\"}},\"will\":{\"topic\":\"test/lwt/will-V1\",\"qos\":0,\"retain\":false,\"payload\":\"will-V1\",\"properties\":{\"correlationData\":\"hello will-V1\",\"userProperties\":{\"prop1\":\"will-V1\"},\"contentType\":\"application/text\"}}}","vt":"json"},{"p":"action","v":"connect","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","x":710,"y":1380,"wires":[["47c8c347.17c61c"]]},{"id":"c5bb1c01.fc48f","type":"inject","z":"4b3f21a3.ba434","name":"test/test1 (datatype auto)","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"test/test1","payload":"a string payload","payloadType":"str","x":730,"y":1540,"wires":[["ff4abd8b.d5d8c"]]},{"id":"1fbb6fb0.2e21c","type":"inject","z":"4b3f21a3.ba434","name":"test/test2 (datatype json)","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"test/test2","payload":"{\"bool\":true,\"string\":\"hello\"}","payloadType":"json","x":730,"y":1580,"wires":[["ff4abd8b.d5d8c"]]},{"id":"13e8f594.bded7a","type":"inject","z":"4b3f21a3.ba434","name":"test/test3 (v5 props)","props":[{"p":"payload"},{"p":"topic","vt":"str"},{"p":"responseTopic","v":"test/reply","vt":"str"},{"p":"userProperties","v":"{\"prop1\":\"val1\",\"prop2\":\"val2\"}","vt":"json"},{"p":"correlationData","v":"this_is_correl_data","vt":"str"},{"p":"contentType","v":"application/json","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"test/test3","payload":"{\"bool\":true,\"string\":\"hello\"}","payloadType":"json","x":710,"y":1620,"wires":[["ff4abd8b.d5d8c"]]},{"id":"94ae6596.a55898","type":"link out","z":"4b3f21a3.ba434","name":"publish->mqtt control","links":["17bbde58.6bd362"],"x":1260,"y":1620,"wires":[],"l":true},{"id":"17bbde58.6bd362","type":"link in","z":"4b3f21a3.ba434","name":"mqtt control","links":["47c8c347.17c61c","94ae6596.a55898","d835cbd0.207b28","1e612121.aa6c4f","e38fb27c.31965","9d777fc1.0cfec"],"x":1170,"y":2040,"wires":[["1ed4d33.7151c2d"]],"l":true},{"id":"47c8c347.17c61c","type":"link out","z":"4b3f21a3.ba434","name":"actions->mqtt control","links":["17bbde58.6bd362"],"x":940,"y":1340,"wires":[],"l":true},{"id":"d835cbd0.207b28","type":"link out","z":"4b3f21a3.ba434","name":"subscribe->mqtt control","links":["17bbde58.6bd362"],"x":1590,"y":1320,"wires":[],"l":true},{"id":"1e612121.aa6c4f","type":"link out","z":"4b3f21a3.ba434","name":"unsubscribe->mqtt control","links":["17bbde58.6bd362"],"x":1590,"y":1500,"wires":[],"l":true},{"id":"9d1fa392.f2af3","type":"comment","z":"4b3f21a3.ba434","name":"publish via mqtt control","info":"","x":720,"y":1500,"wires":[]},{"id":"c36ac379.0b0c2","type":"comment","z":"4b3f21a3.ba434","name":"connect / disconnect / other","info":"","x":720,"y":1260,"wires":[]},{"id":"1ed4d33.7151c2d","type":"mqtt control","z":"4b3f21a3.ba434","name":"","broker":"7bab12a9.b04bcc","action":"setby","x":1350,"y":2040,"wires":[["18724d21.34e9a3"],["b7bf8c92.303c3"]]},{"id":"43229d30.74ea64","type":"mqtt in","z":"4b3f21a3.ba434","name":"","topic":"test/lwt/#","qos":"2","datatype":"auto","broker":"7bab12a9.b04bcc","nl":false,"rap":true,"rh":0,"x":1340,"y":2100,"wires":[["de1ac78e.3de038"]]},{"id":"de1ac78e.3de038","type":"debug","z":"4b3f21a3.ba434","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","statusVal":"","statusType":"auto","x":1530,"y":2100,"wires":[]},{"id":"e6b741ea.22857","type":"inject","z":"4b3f21a3.ba434","name":"publish no topic","props":[{"p":"payload"},{"p":"topic","vt":"str"},{"p":"action","v":"publish","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"","payloadType":"date","x":1200,"y":1800,"wires":[["9d777fc1.0cfec"]]},{"id":"c53e04c6.f38828","type":"inject","z":"4b3f21a3.ba434","name":"subscribe no msg.subscription","props":[{"p":"action","v":"subscribe","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","x":1240,"y":1880,"wires":[["9d777fc1.0cfec"]]},{"id":"5856b83d.3c2938","type":"comment","z":"4b3f21a3.ba434","name":"bad tests","info":"","x":1180,"y":1720,"wires":[]},{"id":"ff4abd8b.d5d8c","type":"change","z":"4b3f21a3.ba434","name":"","rules":[{"t":"set","p":"action","pt":"msg","to":"publish","tot":"str"}],"action":"","property":"","from":"","to":"","reg":false,"x":1060,"y":1620,"wires":[["94ae6596.a55898"]]},{"id":"1dc959da.08f5c6","type":"inject","z":"4b3f21a3.ba434","name":"subscribe bad msg.subscription","props":[{"p":"action","v":"subscribe","vt":"str"},{"p":"subscription","v":"{\"TOPIC\":\"test/test1\"}","vt":"json"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","x":1250,"y":1920,"wires":[["9d777fc1.0cfec"]]},{"id":"95157fea.89116","type":"inject","z":"4b3f21a3.ba434","name":"publish bad topic","props":[{"p":"payload"},{"p":"topic","vt":"str"},{"p":"action","v":"publish","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"#/#/+/#","payload":"","payloadType":"date","x":1200,"y":1840,"wires":[["9d777fc1.0cfec"]]},{"id":"b9f15f39.e3d4","type":"inject","z":"4b3f21a3.ba434","name":"bad action","props":[{"p":"action","v":"deliberate_error","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","x":1180,"y":1760,"wires":[["9d777fc1.0cfec"]]},{"id":"ce2c4a8f.bb5998","type":"inject","z":"4b3f21a3.ba434","name":"subscribe bad topic in msg.subscription","props":[{"p":"action","v":"subscribe","vt":"str"},{"p":"subscription","v":"#/#/+/#","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","x":1270,"y":1960,"wires":[["9d777fc1.0cfec"]]},{"id":"e16b3361.47361","type":"complete","z":"4b3f21a3.ba434","name":"","scope":["1ed4d33.7151c2d"],"uncaught":false,"x":1350,"y":2160,"wires":[["f1f605ad.680d88"]]},{"id":"f1f605ad.680d88","type":"debug","z":"4b3f21a3.ba434","name":"mqtt control complete monitor","active":false,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","statusVal":"","statusType":"auto","x":1610,"y":2160,"wires":[]},{"id":"9d777fc1.0cfec","type":"link out","z":"4b3f21a3.ba434","name":"bad test->mqtt control","links":["17bbde58.6bd362"],"x":1540,"y":1840,"wires":[],"l":true},{"id":"2f9a4f56.30938","type":"inject","z":"4b3f21a3.ba434","name":"connect with opts V2","props":[{"p":"options","v":"{\"broker\":\"192.168.1.50\",\"port\":1883,\"cleansession\":false,\"birth\":{\"topic\":\"test/lwt/birth-V2\",\"qos\":0,\"retain\":false,\"payload\":\"birth-V2\",\"properties\":{\"correlationData\":\"hello birth-V2\",\"userProperties\":{\"prop1\":\"birth-V2\"},\"contentType\":\"application/text\"}},\"close\":{\"topic\":\"test/lwt/close-V2\",\"qos\":0,\"retain\":false,\"payload\":\"close-V2\",\"properties\":{\"correlationData\":\"hello close-V2\",\"userProperties\":{\"prop1\":\"close-V2\"},\"contentType\":\"application/text\"}},\"will\":{\"topic\":\"test/lwt/will-V2\",\"qos\":0,\"retain\":false,\"payload\":\"will-V2\",\"properties\":{\"correlationData\":\"hello will-V2\",\"userProperties\":{\"prop1\":\"will-V2\"},\"contentType\":\"application/text\"}}}","vt":"json"},{"p":"action","v":"connect","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","x":710,"y":1420,"wires":[["47c8c347.17c61c"]]},{"id":"7f40d44f.03b97c","type":"inject","z":"4b3f21a3.ba434","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"test/test4","payload":"{\"key\": \"value\"}","payloadType":"json","x":730,"y":1660,"wires":[["ff4abd8b.d5d8c"]]},{"id":"269b950a.5744aa","type":"inject","z":"4b3f21a3.ba434","name":"test/test5 (with v5 props)","props":[{"p":"payload"},{"p":"topic","vt":"str"},{"p":"userProperties","v":"{\"fred\":\"123\"}","vt":"json"},{"p":"responseTopic","v":"test/reply","vt":"str"},{"p":"contentType","v":"JSON","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"test/test5","payload":"{\"key\": \"value\"}","payloadType":"json","x":730,"y":1700,"wires":[["ff4abd8b.d5d8c"]]},{"id":"7bab12a9.b04bcc","type":"mqtt-broker","name":"PI","broker":"xxxx","port":"1883","clientid":"","autoConnect":false,"usetls":false,"compatmode":false,"protocolVersion":"5","keepalive":"60","cleansession":true,"birthTopic":"test/lwt/birth","birthQos":"0","birthPayload":"payload of test/lwt/birth","birthMsg":{"contentType":"application/json","userProps":"{\"prop\":\"birth-prop\"}","respTopic":"test/lwt/birthResponse","correl":"test/lwt/birth:Correl","expiry":"60"},"closeTopic":"","closeQos":"0","closePayload":"","closeMsg":{},"willTopic":"","willQos":"0","willPayload":"","willMsg":{},"sessionExpiry":""}]

We want to get the UI working on tablets.

There is some early support already in there for touch events, but it is not complete. For example, you can start to drag a new link between nodes, but it doesn't end properly.

The layout could also do with being optimised.

Function Changes

• [x] enable dragging out of palette
• [x] prevent native zoom
• [x] enable pinch-zoom in workspace ( PR coming from @TJKoury )
• [x] unable to wire nodes together (a3dea6ec0dc92ae2880a035b2fb4361b697f3ad0)
• [x] double tap to edit rather than long-touch (ec5985eaa32066c34ecd39bc1099aeb6d6a16e64)
• [x] how to delete a node (radial menu: e524393d8792e4cd75b6520b727e65b803457792)
• [x] how to undo change (radial menu: e524393d8792e4cd75b6520b727e65b803457792)
• [x] how to group select (lasso) - long-touch to disable scroll/enable lasso? (0e8f0735cc207c1503f1ef91a7a9c43604a802c7)
• [ ] import flow placement - click to place, needs a visual cue to touch as you don't drag the nodes
• [ ] pinch zoom deselects current selection
• [x] pinch zoom triggers radial menu (2fa82d9)
• [x] trigger radialMenu on long-touch with link selected

Mobile-specific UI changes

• [ ] decide on server-side or client-side mobile detection (ie serve mobile.html, or insert mobile specific css/javascript adaptations)
• [x] mobile-only tool bar to enable delete/undo/other? actions (not needed due to radialMenu)
• [x] sidebar resize target needs to be more obvious (aa4bf4d64060dab47d75c5dfc00dc4dd06429e23)
• [x] sidebar drag in from RH side (aa4bf4d64060dab47d75c5dfc00dc4dd06429e23)
• [ ] drop-down menu changed to be slide-in menu
• [ ] palette drag in from LH side

Current Behavior

When first logging in (or using incognito), I am presented with the standard Node-RED log Username: Password: and login button page

After logging in, I get the progress bar and "loading nodes" message and a second modal popup login box appears:

Audit logs don't show any obvious difference whether I log into the second dialog or not.

So what is it?

Expected Behavior

Normal, single, nodered welcome page login. Just one time, without the need to deal with a second popup.

Steps To Reproduce

Load nodered web interface, log in as usual.

Example flow

example flow not applicable

Environment

• Node-RED version: 1.3.5
• Node.js version: v14.18.2
• npm version: 6.14.15
• Platform/OS: Raspberry Pi 400 / Debian 10 Buster
• Browser: Chrome 9

8.0.4758.82

sample log where I cancel the second popup

first load page and log in with credentials:

11 Feb 12:34:19 - [audit] {"event":"auth.login","username":"admin","client":"node-red-editor","scope":"*","level":98,"timestamp":1644600859288}
11 Feb 12:34:19 - [audit] {"event":"plugins.list.get","level":98,"user":{"username":"admin","permissions":"*"},"path":"/plugins","ip":"192.168.1.200","timestamp":1644600859554}
11 Feb 12:34:19 - [audit] {"event":"comms.open","level":98,"timestamp":1644600859578}
11 Feb 12:34:19 - [audit] {"event":"comms.auth","user":{"username":"admin","permissions":"*"},"level":98,"timestamp":1644600859603}
11 Feb 12:34:19 - [audit] {"event":"plugins.configs.get","level":98,"user":{"username":"admin","permissions":"*"},"path":"/plugins","ip":"192.168.1.200","timestamp":1644600859634}
11 Feb 12:34:19 - [audit] {"event":"nodes.list.get","level":98,"user":{"username":"admin","permissions":"*"},"path":"/nodes","ip":"192.168.1.200","timestamp":1644600859665}
11 Feb 12:34:19 - [audit] {"event":"nodes.icons.get","level":98,"user":{"username":"admin","permissions":"*"},"path":"/icons","ip":"192.168.1.200","timestamp":1644600859743}
11 Feb 12:34:19 - [audit] {"event":"nodes.configs.get","level":98,"user":{"username":"admin","permissions":"*"},"path":"/nodes","ip":"192.168.1.200","timestamp":1644600859779}

hit cancel:

11 Feb 12:34:54 - [audit] {"event":"flows.get","level":98,"user":{"username":"admin","permissions":"*"},"path":"/flows","ip":"192.168.1.200","timestamp":1644600894457}

Here's the version where I enter the credentials in the popup

first load page and log in with credentials:

11 Feb 12:35:47 - [audit] {"event":"auth.login","username":"admin","client":"node-red-editor","scope":"*","level":98,"timestamp":1644600947179}
11 Feb 12:35:47 - [audit] {"event":"plugins.list.get","level":98,"user":{"username":"admin","permissions":"*"},"path":"/plugins","ip":"192.168.1.200","timestamp":1644600947485}
11 Feb 12:35:47 - [audit] {"event":"comms.open","level":98,"timestamp":1644600947518}
11 Feb 12:35:47 - [audit] {"event":"comms.auth","user":{"username":"admin","permissions":"*"},"level":98,"timestamp":1644600947559}
11 Feb 12:35:47 - [audit] {"event":"plugins.configs.get","level":98,"user":{"username":"admin","permissions":"*"},"path":"/plugins","ip":"192.168.1.200","timestamp":1644600947627}
11 Feb 12:35:47 - [audit] {"event":"nodes.list.get","level":98,"user":{"username":"admin","permissions":"*"},"path":"/nodes","ip":"192.168.1.200","timestamp":1644600947661}
11 Feb 12:35:47 - [audit] {"event":"nodes.icons.get","level":98,"user":{"username":"admin","permissions":"*"},"path":"/icons","ip":"192.168.1.200","timestamp":1644600947769}
11 Feb 12:35:47 - [audit] {"event":"nodes.configs.get","level":98,"user":{"username":"admin","permissions":"*"},"path":"/nodes","ip":"192.168.1.200","timestamp":1644600947798}

enter same credentials:

11 Feb 12:36:02 - [audit] {"event":"flows.get","level":98,"user":{"username":"admin","permissions":"*"},"path":"/flows","ip":"192.168.1.200","timestamp":1644600962993}

Current Behavior

When doing a simple GET request with no payload to an endpoint that should return a binary buffer (an image) I get the following error:

RequestError: Parse Error: Missing expected CR after header value

The node was working before version 3. Maybe it is related to https://github.com/nodejs/node/issues/43798

Expected Behavior

Return a binary buffer.

Steps To Reproduce

This is the node:

[
    {
        "id": "912ff074.7418",
        "type": "http request",
        "z": "61690af24820e126",
        "name": "",
        "method": "GET",
        "ret": "bin",
        "paytoqs": "ignore",
        "url": "http://192.168.7.14:8023/snapshot.cgi",
        "tls": "",
        "persist": false,
        "proxy": "",
        "authType": "",
        "senderr": false,
        "credentials": {},
        "x": 250,
        "y": 40,
        "wires": [
            [
                "bad44d5a.892d3"
            ]
        ]
    }
]

Example flow

[
    {
        "id": "469f2259.87ca3c",
        "type": "inject",
        "z": "61690af24820e126",
        "name": "",
        "props": [
            {
                "p": "payload"
            },
            {
                "p": "topic",
                "vt": "str"
            }
        ],
        "repeat": "",
        "crontab": "",
        "once": false,
        "onceDelay": 0.1,
        "topic": "",
        "payload": "",
        "payloadType": "date",
        "x": 100,
        "y": 120,
        "wires": [
            [
                "912ff074.7418"
            ]
        ]
    },
    {
        "id": "912ff074.7418",
        "type": "http request",
        "z": "61690af24820e126",
        "name": "",
        "method": "GET",
        "ret": "bin",
        "paytoqs": "ignore",
        "url": "http://192.168.7.14:8023/snapshot.cgi",
        "tls": "",
        "persist": false,
        "proxy": "",
        "authType": "",
        "senderr": false,
        "credentials": {},
        "x": 250,
        "y": 40,
        "wires": [
            [
                "bad44d5a.892d3"
            ]
        ]
    }
]

Environment

• Node-RED version: v3.0.0
• Node.js version: 16.16.0
• npm version: -
• Platform/OS: Docker
• Browser: Chrome

We haven't decided on what time-scale we want to enable node-red to be internationalized, but it is something we need to have a plan for.

This needs a high-level design that considers how each of the main components will have to be changed to support i18n. The runtime and editor should be fairly straightforward to add support for message catalogues. The hard part is how nodes can provide localized versions; their current architecture doesn't make it entirely obvious how this will be achieved easily.

Then there is the question of what library to use. Amongst the libraries that appear to be candidates are:

• jquery.i18n
• i18next

Current Behavior

I have node-red v2.2.2 currently installed in different machines with Ubuntu. And I realized that when I use the functions node.warn('any word') or node.error('any word') once, they will print the message on the debug window twice:

I have an old version of Node-red 1.2.1 installed on one machine and it doesn't happen there. I'm sure it's an issue with version 2.2.2.

Expected Behavior

The expected behavior is printing the message only once when I use the function node.warn once.

Steps To Reproduce

No response

Example flow

[{"id":"884df64fc0706d1a","type":"function","z":"ff922ddb.76cc18","name":"node.error('printing twice')","func":"node.error('printing twice')\nreturn msg;","outputs":1,"noerr":0,"initialize":"","finalize":"","libs":[],"x":1470,"y":1900,"wires":[["d16a5938e610505c"]]},{"id":"c84f153b25b2ec5b","type":"inject","z":"ff922ddb.76cc18","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"","payloadType":"date","x":1260,"y":1900,"wires":[["884df64fc0706d1a"]]},{"id":"d16a5938e610505c","type":"debug","z":"ff922ddb.76cc18","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"payload","targetType":"msg","statusVal":"","statusType":"auto","x":1690,"y":1900,"wires":[]},{"id":"53023a7dd1eb74ea","type":"function","z":"ff922ddb.76cc18","name":"node.warn('printing twice')","func":"node.warn('printing twice')\nreturn msg;","outputs":1,"noerr":0,"initialize":"","finalize":"","libs":[],"x":1470,"y":1960,"wires":[["30bbcdcf40181b6d"]]},{"id":"d59918f0a0e600ef","type":"inject","z":"ff922ddb.76cc18","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"","payloadType":"date","x":1260,"y":1960,"wires":[["53023a7dd1eb74ea"]]},{"id":"30bbcdcf40181b6d","type":"debug","z":"ff922ddb.76cc18","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"payload","targetType":"msg","statusVal":"","statusType":"auto","x":1690,"y":1960,"wires":[]}]

Environment

• Node-RED version: 2.2.2
• Node.js version: 16.13.12
• npm version: 8.5.5
• Platform/OS: Ubuntu 20.04
• Browser: Firefox/Chrome

Having updated the MySQL and mqtt nodes to make proper use of the credentials file, there are some improvements to be made. #222 added the basic framework for this.

There are some remaining tasks:

• [x] document the api and its use

• [x] Server-side registration of credentials is currently done via RED.nodes.registerCredentials - it should be RED.credentials.register (a bug I didn't spot before merging #222 - my fault) (delivered by @Belphemur in #228)
• [x] credential validation - as with properties in the defaults array, it should be possible to specify 'required' or 'validate' properties. (delivered by @Belphemur in #228)
• [x] save on Deploy - only save credentials on Deploy (as other configuration variable) - and allow Undo in same manner (delivered by @Belphemur in #251)
• [x] Now I can see it in action, the API we provide for a node to register its credentials (RED.credentials.register) doesn't quite feel right. In hindsight, we should move this to be part of RED.nodes.registerType. This should also incorporate what is done with RED.library.registry so there is one function for registering everything in a single call (although doesn't need to be done up front...) (a6a0352b7027c9fbf63a50b1d4b8297da3ab5e33)
• [x] RED.nodes.createNode should prepopulate the node object with a credentials object containing its values. This removes the need for every node implementation to go get the credentials themselves. This will allow us to remove RED.getCredentials from the external API. (aa35484a301ad5b6f1f2611dd428d1ee08719179)
• [x] We need a mechanism for a node to take some custom action using the credentials when displaying the edit dialog. http request is a good example of a node that wants to use this new api. It needs to toggle the visible state of the authentication fields depending if they are set or not. Currently oneditprepare is called asynchronously to the credential-loading request - which means this isn't possible. (b604db83f6b57ee6fef5889ac288d197f9bc4dc3 - oneditprepare is now called after creds have been loaded - node.credentials contains them.)
• [x] how to handle email nodes use of including non-credential flag in its http request to indicate if external creds are being used. (made the global flag a credential... problem solved: 8ddfa9eb29de41757d7e7e4ff1b4281f75e1b418)
• [x] decide whether RED.getCredentials, RED.addCredentials and RED.deleteCredentials should be removed from the external API. This can only be done once all existing users are migrated to the new API. (The twitter node is an example of out-of-stream credential handling due to oauth workflow that requires these apis - leave them in place)

It would be nice if there was a way to label the outputs, so that when I'm connecting nodes I could mouse over the output and see a tooltip pop-up that tells me what the label is.

Current Behavior

After update 3.0 the Function Node Editor background is White (not dark)

Expected Behavior

No response

Steps To Reproduce

No response

Example flow

paste your flow here

Environment

• Node-RED version: 3.0
• Node.js version: v16.15.0
• npm version:
• Platform/OS: Home Assistant OS 8.2
• Browser: Chrome 103.0.5060.114

The text will appear in the information tab of the side panel and not in the help tab of the side panel.

• [ ] Bugfix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)

Textual change.

Proposed changes

The location of the text of the comment node will appear in the help tab of the side panel and not in the information tab of the side panel. This change makes that more clear.

Checklist

• [x] I have read the contribution guidelines
• [x] For non-bugfix PRs, I have discussed this change on the forum/slack team.
• [ ] I have run grunt to verify the unit tests pass
• [ ] I have added suitable unit tests to cover the new/changed functionality

Current Behavior

I am massivly working with global context variables. When I set or change variables (does not matter, if its done via function node or a change node). The variables are set correctly and can also be read via a get call. I can also check them for example by looking into the global.json (store).

But the Editors UI is showing totally different values and even structure there is wrong.

If I press the global refresh button the values still do not get updated. If I press the local variable based refresh button, the variable is changing to "undefined". That very bad because the work with variables is hard to be debugged like this.

Expected Behavior

Expected is that the UI shows the real value and structure of the variables.

Steps To Reproduce

relevant part of the settings.json (I am only using "default"):

    contextStorage: {
        default: { module: "localfilesystem"},
        memory: { module: "memory" }
    },

Example flow

paste your flow here

Environment

Docker based installation:

• Node-RED version: v3.0.2
• Node.js version: v16.16.0
• npm version: 8.11.0
• Platform/OS: Linux 5.10.103-v7l+ arm LE
• Browser: google-chrome-stable (108.0.5359.124)

I know Node.Red supports running without an editor, but would it be possible to host the editor elsewhere and connect to node.red instance remotely? For example, having installed node.red on raspberry pi, I would like to install same version on the docker. Tell pi to run without the editor, and configure node.red on the docker to connect to the pi, rather than the local instance.

…editor

• [ ] Bugfix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)

Proposed changes

This PR add following inline figure support to the markdown editor of Node-RED editor used for describing node's as documents discussed at this forum thread.

• writing an inline diagram using mermaid syntax enclosed by ```mermaid and ```,
• inserting an inline image as data URL (<img src="data:..." />) by drag & drop of an image file.

Mermaid diagram can be disabled by setting editorTheme.markdownEditor.mermaid.enabled to false in settings.js. In this case, mermaid rendering is disabled, and mermaid code blocks are shown by expandable code block as shown below.:

The code block is closed by default. When mermaid rendering is disabled, the mermaid library is not loaded into Node-RED editor to make editor memory footprint smaller,

Checklist

• [x] I have read the contribution guidelines
• [x] For non-bugfix PRs, I have discussed this change on the forum/slack team.
• [x] I have run grunt to verify the unit tests pass
• [x] I have added suitable unit tests to cover the new/changed functionality

Fixes #3982

When splitting buffers in a stream, the node stores any 'left-over' bits following the split to be joined with the next message in the stream. It stored the done event until that left-over bit was made whole.

However, if there were no left-over bits (length === 0), it was storing done for later and calling done.

The fix is to not store the done for later if there is no left-over bit.

But, this does also raise a question of a difference in behaviour between string and buffer modes. I think for String streams, it always calls done after splitting, regardless of any left-over bits... whereas for Buffer streams, as described above, it waits until left-overs are handled.

This could do with tidying up, but needs more investigation and test cases to properly figure out the 'expected' behaviour.