Hello!

What do you think about idea of implementing such formatting?

If we would name this function format, then here are some examples of how it would work:

v.sformat('{}, {}, {}', 0, 1, 2); => '0, 1, 2' v.sformat('{0}, {0}, {1}, {2}, {3}', 1, 2, 3, 5); => '1, 1, 2, 3, 5' v.format('{name}: {a}+{b}={c}', {name: 'sum', a: 1, b: 2, c:3}); => 'sum: 1+2=3'

There would be also possibility to pass function to format.

If you think this is a good idea, then I would implement it in the coming days :smile:

Hi! I tried the voca.js on explorer v11 and it crashed.

I'm not an expert in javascript but I managed to make it work by adding a few lines. Maybe it could be useful to others?

Modifies:

At the very beginning of the file:

//object.keys support
if (!Object.keys) {
  Object.keys = function(obj) {
    var keys = [];
    for (var i in obj) {
      if (obj.hasOwnProperty(i)) {
      keys.push(i);
    }
  }
 return keys;
  };
}

//object.values support
if (!Object.values) {

Object.values = function(obj) {

var res = [];
    for (var i in obj) {
        if (obj.hasOwnProperty(i)) {
            res.push(obj[i]);
        }
    }
    return res;
  };
}

//Array.foreach support
if (!Array.prototype.forEach) {
    Array.prototype.forEach = function(fn, scope) {
        for(var i = 0, len = this.length; i < len; ++i) {
            fn.call(scope, this[i], i, this);
        }
    }
}

//Array.isArray support
if (!Array.isArray) {
    Array.isArray = function(item) {
      if(item instanceof Array){return true;}
      return false;
    }
}

//bind support
if (!Function.prototype.bind) {
  Function.prototype.bind = function(oThis) {
    if (typeof this !== 'function') {
      // closest thing possible to the ECMAScript 5
      // internal IsCallable function
      throw new TypeError('Function.prototype.bind - what is trying to be bound is not callable');
    }

    var aArgs   = Array.prototype.slice.call(arguments, 1),
        fToBind = this,
        fNOP    = function() {},
        fBound  = function() {
          return fToBind.apply(this instanceof fNOP && oThis
                 ? this
                 : oThis,
                 aArgs.concat(Array.prototype.slice.call(arguments)));
        };

    fNOP.prototype = this.prototype;
    fBound.prototype = new fNOP();

    return fBound;
  };
}

(function (global, factory) { 
[...]

And then the function isNil

function isNil(value) {
    return value === undefined || value === null || value === '';
}

Now it works.

Expected behavior :smile_cat:

v.titleCase("professor's office")
'Professor\'s Office'

Actual behavior :crying_cat_face:

v.titleCase("professor's office")
'Professor\'S Office'

Node version: 8.1.4

Are there situations that I'm missing here where a letter after a prime/apostrophe should be capitalized? The same behaviour occurs with real/smart quotes (’ as opposed to ') as well

> v.titleCase("professor’s office")
'Professor’S Office'

Description

Repeat: Removed while loop, used repeat method of String.prototype to improve readability Reverse: Changed function to increase time complexity from O(3n) to O(n)

Check List

• [X] All test passed
• [ ] Added test to ensure correctness

Awesome library, would have a suggestion. v.stripHtml(htmlTagArray = [''])

If any htmlTag is given within the array the strip function is limited to them otherwise the function removes all html tags.

Welcome to Voca's GitHub repo!

Expected behavior :smile_cat:

expect(v.prune('YATTA, ', 6, '')).toEqual('YATTA,');

Actual behavior :crying_cat_face:

expect(v.prune('YATTA, ', 6, '')).toEqual('YATTA'); // the string is missing the `,` at the end

Steps to reproduce :construction_worker:

https://github.com/mattiaerre/china-musk/blob/master/src/store/prune.test.js

Technical details: :wrench:

Browser/OS type: macOS Mojave Node version: v10

thanks so much, -Mattia

Welcome to Voca's GitHub repo!

Expected behavior :smile_cat:

v.graphemes("కృష్ణ") should return (2) ["కృ", "ష్ణ"] v.countGraphemes("కృష్ణ") should return 2

Actual behavior :crying_cat_face:

v.graphemes("కృష్ణ") returns (5) ["క", "ృ", "ష", "్", "ణ"] v.countGraphemes("కృష్ణ") returns 5

Steps to reproduce :construction_worker:

v.graphemes("కృష్ణ") v.countGraphemes("కృష్ణ")

Technical details: :wrench:

Browser/OS type: n/a Node version: n/a

Feature Suggestion

Convert a string to title case.

Examples

v.titleCase('hello world')
// => 'Hello World
v.titleCase('Hello world')
// => 'Hello World
v.titleCase('hello World')
// => 'Hello World

Implentation Suggestions

This SO question has many suggestions.

The top answer uses string.replace() with regex:

function toTitleCase(str) {
  return str.replace(/\w\S*/g, function(txt){return txt.charAt(0).toUpperCase() + txt.substr(1).toLowerCase();});
}

Not sure about the coverage of all cases.

Options

In formal title case, words like 'a', 'it', 'of', etc. are ignored (not capitalized). Consider this as an option. v.titleCase(subject, allWords)

v.titleCase('this is a title of great proportions', true);
// => 'This Is A Title Of Great Proportions'
v.titleCase('this is a title of great proportions', false);
// => 'This is a Title of Great Proportions'

For e.g. If the input is "wxyz" then the output of the string should be ['w','wx','wxy','wxyz','wxz','wy','wyz','wz','x','xy','xyz','xz','y','yz','z']

I am unsure if this is behavior is intended or not but if there is a number that is part of word or acronym it is broken out as a separate word.

Expected behavior:

v.words('What Is The Best MACD Indicator for MT4?') (8) ["What", "Is", "The", "Best", "MACD", "Indicator", "for", "MT4"]

v.countWords('What Is The Best MACD Indicator for MT4?') 8

Current behavior: v.words('What Is The Best MACD Indicator for MT4?') (9) ["What", "Is", "The", "Best", "MACD", "Indicator", "for", "MT", "4"]

v.countWords('What Is The Best MACD Indicator for MT4?') 9

I realize I could come up with my own regex to solve this issue but the default regex works really well besides this one scenario which doesn't seem intended.

I am using Voca 1.4.0

Bumps acorn from 5.7.3 to 5.7.4.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Related issue

None

Description

The file at src/helper/number/const.js had a typo in the JSdoc comment. It said "save integer" instead of "safe integer"

Check List

• [x] All test passed
• [ ] Added test to ensure correctness

I think this library should include functions to convert Strings to TypedArrays and viceversa, with the option to interpret as UTF-8 or UTF-16 depending on use case. So if a string is to be interpreted as UTF-8, the corresponding TypedArray should be a Uint8Array, otherwise UTF-16 is used and a Uint16Array of code-units is returned. If an arbitrary TypedArray is provided, it'll be read as a string of octets, and those octets will be converted to a string depending on the chosen encoding. UTF-16 has endianess and BOMs, so a function that handles implicit and explicit endianess would be slightly more complicated.

Another thing related to encodings are binary-to-text encodings like Hexadecimal, base64, base85, etc. JS already has base64 support with atob and btoa, but hex and base85 are missing, which could be provided by this library.

I don't know if these features should be added to this library because Voca seems to be intended for high-level (not low-level) use cases, and adding base85 support would be pointless because it's rarely used. Any constructive criticism is appreciated

Scripts are cool for frontend. But serverside needs performance.

Chaining the string methods practically causes reloops per chain.

How about synthesizing methods together for one loop?

Starting the project in a few a days.

I like Voca better than the alternatives, but I can't see how you would convert camelcase into words. In other libs it's called .humanize

For example:

"camelCase" -> "camel case"

Welcome to Voca's GitHub repo!

Expected behavior :smile_cat:

Importing the library should not throw an exception.

Actual behavior :crying_cat_face:

Following exception is thrown:

global is not defined

Error in function getGlobalObject in ./node_modules/voca/index.js:3595

 3593 |   if (typeof global === 'object' && global.Object === Object) {
 3594 |     // NodeJS global object
> 3595 |     globalObject$1 = global;

Steps to reproduce :construction_worker:

This seems to be an issue using voca in the latest major update of Gatsby (v3), or perhaps Webpack? From what I can gather, voca is initialising the global object using "global" (ie NodeJS instance) even though this is a browser instance, I don't understand why it would be entering that if statement

Technical details: :wrench:

Browser/OS type: Chrome/ Ubuntu 20 Node version: v12.21.0

Related issue

#50 Title Abbreviations

Description

Add another input in titleCase function named preserveUpperCase

Check List

• [x] All test passed
• [x] Added test to ensure correctness