On Ubuntu 16.10, when I use the command-line tool trash to delete a file, rather than a folder, the file is deleted immediately rather than appearing in the Trash where I can recover it. In other words, trash acts like rm -f when given a file.

Some commands that demonstrate the problem:

$ pwd
/home/roryokane

$ # delete files

$ touch aaaaaa.txt
$ trash aaaaaa.txt

$ touch bbbbbb.txt
$ echo "contents of bbbbbb" > bbbbbb.txt
$ trash bbbbbb.txt

$ # delete folders

$ mkdir cccccc
$ touch cccccc/foo.txt
$ echo "contents of foo" > cccccc/foo.txt
$ trash cccccc

$ mkdir dddddd
$ trash dddddd

When I look in my Trash by clicking the Trash icon in the dock/taskbar, I only see the cccccc and dddddd folders in the trash. The aaaaaa.txt and bbbbbb.txt files are missing.

My environment

I used the xdg-trashdir package, which trash currently uses, to find the location of my Trash directories. Here is my Node session:

const xdgTrashdir = require('xdg-trashdir');
let dirs = []
xdgTrashdir.all().then(dirsInner => dirs = dirsInner)
dirs.forEach(dir => console.log(dir))

And the output:

/dev/.Trash-1000
/run/.Trash-1000
/home/roryokane/.local/share/Trash
/dev/shm/.Trash-1000
/run/lock/.Trash-1000
/sys/fs/cgroup/.Trash-1000
/snap/core/1337/.Trash-1000
/snap/keepassx-elopio/1/.Trash-1000
/snap/core/1287/.Trash-1000
/snap/core/1264/.Trash-1000
/home/roryokane/.local/share/Trash
/run/user/1000/.Trash-1000

Saving that to a file and running cat trash_dirs.txt | xargs ls showed that the only folder of those that exists is /home/roryokane/.local/share/Trash, which contains expunged/, files/, and info/. None of those folders contain files or folders with aaaaaa, bbbbbb, cccccc, or dddddd in their names. Also, when I search for those four files and folders using the Files program to search those names from the root of the disk, none of them are found.

I installed trash with Yarn:

$ which trash
/home/roryokane/.yarn-global/bin/trash
$ yarn global ls
yarn global v0.21.3
warning No license field
info "[email protected]" has binaries:
   - gitjk_cmd
   - git-jk
info "[email protected]" has binaries:
   - trash
Done in 0.61s.

$ sed -e '/^+.*/p' a > b
$ time rm b

real    0m0.361s
user    0m0.161s
sys     0m0.027s
$ sed -e '/^+.*/p' a > b
$ time \rm b

real    0m0.002s
user    0m0.000s
sys     0m0.002s
$ type rm
rm is aliased to trash

$ ls -a -l
-rw-rw-r--  1 nikhil 179K Jan 25 11:27 b

After updating to v 3.1.1 (Win7), trash is no longer working. Before the update it worked perfect when I had v2.0.0.

I get the following when trying to trash anything now.

sh.exe": /local/trash: No such file or directory

When trashing a file or directory, the implementation MUST create the corresponding file in $trash/info first. Moreover, it MUST try to do this in an atomic fashion, so that if two processes try to trash files with the same filename this will result in two different trash files. On Unix-line systems this is done by generating a filename, and then opening with O_EXCL.

https://specifications.freedesktop.org/trash-spec/trashspec-latest.html

It looks like GnomeVFS was sanity-checking the timestamps. So if you break the rule and don't create the trashinfo file first, then GnomeVFS will ignore it :-).

Fixes #56

I just installed trash and I'm using ZSH. I get zsh: command not found: trash error.

$ trash a.txt
zsh: command not found: trash

$ npm list --depth=0
/Users/zulhilmizainudin
├── [email protected]
└── [email protected]

$ npm -v
2.6.1

What should I do?

$ touch test
$ trash test
Command failed: Traceback (most recent call last):
  File "./trash-put", line 4, in <module>
    from trashcli.put import main
  File "/home/despairblue/node_modules/trash/vendor/trash-cli/trashcli/put.py", line 255
    except (IOError, OSError), error:
                             ^
SyntaxError: invalid syntax

Like globby, I assumed this module accepted a string. When I passed in '/foo/bar/car' it turned it into an array of ['/', 'f', 'o', ...] and globbed a result of of

['/', '/foo/bar/car']

The value of / was not what I wanted :warning:. In earlier versions trash would have thrown an error if it received a string. However, now it silently accepts a string and happily trashes root.

The nas I'm on has limited storage on root so the trash fills up fast with no-space errors. It also let's me muck with / without borking, restoring off another partition, so no worries.

The command:

trash /Volumes/something/abc

moves the file/directory to ~/.Trash on OS X, i.e. moves it to a different drive. It should just move the file/directory to the trash proper for the volume the file is on.

Tested on OS X Yosemite with trash 1.2.0.

Only node required you say? I say yes! Although it could be worth waiting for support for external drives before merging. It's not a requirement in the trash spec (only MAY use) so it wouldn't be wrong to merge either.

Currently I'm using trash-cli which works fine, but it's Python dependent and slow as it's excuted in a child process.

There's a spec on how to implement "moving files to the trash" correctly.

It would be incredible if someone would be interested in writing a separate node module for this.

Let me know if you're interested ;)

With the addition of using fs.lstatSync https://github.com/sindresorhus/trash/commit/126a1dd1532d0bdd236628fb8db505db033d9273, now trash errors with

Error: ENOENT: no such file or directory, lstat './the-file'
   at Object.fs.lstatSync 

When a file doesn't exist, where as fs.existsSync would return false.

Related to #64 (\cc @jdanford)

Similar to #56, but probably has to be solved in a different way for Windows. This was reported by a user in my app losslesscut https://github.com/mifi/lossless-cut/issues/537 When he trashed a file on a network mounted drive (which has no trash), the file just got removed permanently.

trash wasn't able to delete a file named \ \ ㊕\ 八倍縮時影片⏩\ 📺\ 🚲🚴\ 8\ ✖\ Time\ lapse\ _\ 上水\ Sheung\ Shui\ ⬄\ 粉嶺\ Fanling\ _\ 2020-Oct-28\ -FxRsQ-yrtG4.webm but rm did

I have windows 10 + WSL (v1). I just installed this tool and tried to use it on a file inside WSL... I was expecting it to move the file to my Recycle Bin. It didn't work, but then I realized it put the file (renamed) inside ~/.local/share/Trash/files/ (according to that linux spec I guess).

I now realize this wasn't going to work like I expected since the tool is running in a linux environment (WSL), not actual windows.

I'm not sure if there's any way to get this tool installed out in windows land and still be able to run it from inside WSL to do what I expected, but if that's possible it would be nice to add something about that to the documentation.

Alternately and minimally, it might be a good idea to point in the docs out that installing under WSL in Windows is actually installing in linux, and pointing out where deleted files will go. Could remove some future confusion I had for the last ~20 minutes.

I've been trying to use trash via coc-explorer, but it doesn't seem to find the the correct Trash folder. I've investigated xdgTrashdir a bit to see if it was the cause, but xdgTrashdir() with no arguments seems to find my home trash dir fine (/home/$USER/.local/share/Trash).

The issue here is that according to trash my Trash folder is supposed to be /nix/store/.Trash-1000, which is not correct. NixOS uses a weird filesystem, and I'm not too familiar with why this is happening, but my best guess is that the mount mapping logic finds /nix/store as the mount the target directory $topdir according to the spec.

This is not the expected behavior, as /nix/store resides on the same filesystem and mount that my home folder does. I'm not familiar with how the mount points are resolved, so I'm not sure exactly how to fix this, but I'd gladly help with anything else I can do.

README claims trash() returns a Promise, but the expected type is void? https://github.com/sindresorhus/trash/blob/bdfbd071e491df63c2e59bb4d72ebfac6c60ef10/index.test-d.ts#L4

So there is currently no way to tell whether the library succeeded in moving a file into the trash or whether it encountered an error?

trash('some-file.lol')
  .then((result) => {
    console.log(result); // always `undefined`
  })
  .catch((err) => {
    console.log(err); // never runs
  });

So, the library just sends a command to the OS and doesn't know what happens after?

When you tell the library to delete a non-existing file, it behaves the same way (no error, no notification).

This isn't a problem -- it's just that I'd love to have my app respond appropriately, not just assume that deletion occurred correctly 😓

I can manually get node to check whether the file is present to confirm it was deleted, but would be great if I didn't have to 😅

Please let me know if I'm misunderstanding something.

trash (invoked, in my case, via trash-cli) does not seem to work on directories in Linux (in my case, Ubuntu 19.10).

$ trash {src,test,build}/**/*.{js,d.ts,map}
Error: EISDIR: illegal operation on a directory, copyfile '/builds/build/es6' -> '/root/.local/share/Trash/files/c862ddbe-a1f8-4589-b545-fe260f81e2e9'