first part of Sound Feb/March 2022 upgrade plan

huge shout out to @pvienhage for most of the ideas

ArtistV3.sol

This upgrade is mainly gas & UX optimizations:

• Adds editionCount view function
• Adds setPresaleQuantity and setSignerAddress so an artist can update those parameters of an edition after creating it. Both are protected by onlyOwner
• Sends ETH directly to edition.fundingRecipient during the buyEdition transaction
• deprecates depositedForEdition and withdrawnForEdition mappings
• Deprecates atTokenId counter in favor of deriving tokenId from editionId and serial number (the current edition.numSold) bit-packed together
• removes getTokenIdsOfEdition and getOwnersOfEdition view functions
• replaces tokenToEdition mapping with tokenToEdition helper function that handles both the new
• updates tokenSupply & tokenURI functions to accommodate above changes

tests

• tests for all of the above in Artist.test.ts
• before & after upgrade tests in upgrades.test.ts

👋 Hello, soundxyz!

I'm wondering if you all have plans to introduce contributing guidelines to this repository?

I'm interested in contributing (and perhaps others are too 😉), but I'm not quite sure where the best place to start. From the last 48 hours, I see there's healthy activity from the team and I'd love to lend a hand!

However, I want to make sure the time that I spend on opening issues and PRs are worthwhile (and welcome!), so it would be lovely to get some direction from the team on where you all welcome the most help (good first issues, feature implementation, bug fixes, etc.).

Thank you for considering my ask! 🙇‍♂️

the downside of this is pre-upgrade tokenURIs will be like ...api/metadata/1/1/1 and post-upgrade will be like ...api/metadata/1/1/3907309379307007101, but making them consistent would require including a version number in the URI so our API knows if it should search for the NFT using the tokenId or the serialNumber

• at neume network we're continuously downloading the music NFT's metadata and we're also roughly testing for equality of responses in-between temporal gaps
• https://github.com/neume-network/strategies/blob/3ceb7b3386101633ed3ac1b01c303b70e53c9ff7/test/strategies/soundxyz-get-tokenuri/extractor_test.mjs#L10-L22 tests downloading the following sound.xyz tokenURI: https://github.com/neume-network/strategies/blob/3ceb7b3386101633ed3ac1b01c303b70e53c9ff7/test/strategies/soundxyz-get-tokenuri/extractor_input_data#L1
• The expected results is a snapshot which we manually curate: https://github.com/neume-network/strategies/blob/3ceb7b3386101633ed3ac1b01c303b70e53c9ff7/test/strategies/soundxyz-get-tokenuri/extractor_snapshot.json#L4
• You can see that those tests work as their commit is the basis for this test run: https://github.com/neume-network/strategies/actions/runs/3013604127
• However, it seems that shortly after you've manually changed the comment wall URL in one of your music NFTs: https://github.com/neume-network/strategies/actions/runs/3033162850/jobs/4881205201#step:6:287 and our tests errored
• we'd appreciate it if you'd host your metadata through content addressing and by e.g., publishing a new hash for each update so that it stays immutable

• I'm working on neume
• For all published tracks, we're using the initial mint event Transfer(address(0), creator, tokenId) to index tracks using a fork of Spinamp's subgraph: https://github.com/neume-network/web3-music-subgraph
• We highly value being able to make idempotent requests to platforms, so e.g., we were calling function tokenURI at the point of an NFT's creation rather than with block number tag "latest".
• So you can see that we actually get fairly "old" tokenuris from your contracts: https://raw.githubusercontent.com/neume-network/data/main/results/soundxyz-call-tokenuri-transformation
• Recently (this week), those URI formats have been broken by your server, and they now return a 404 error rather than the actual JSON metadata of the NFT. Here's an example: https://www.sound.xyz/api/metadata/66/1/10
• We think that's a bad form: We think that "cool URIs don't change"
• E.g., a backward compatible upgrade of the server would have used the 301 redirect HTTP status code to point an old resource to a new resource as I think structurally, the resources haven't been laid out differently.