By default, any change on the content will trigger an immediate model update and form validation. With this PR you can override this behavior using the ng-update-model-on attribute to bind only to a comma-delimited list of events.

I.e. ng-update-model-on="blur" will update and validate only after the control loses focus.

If you want to keep the default behavior and just add new events that may trigger the model update and validation, add "default" as one of the specified events.

I.e. ng-update-model-on="default,submit"

Also, a ng-update-model-debounce attribute will allow defering the actual model update after the last triggered event. This feature is not available in radio buttons.

I.e. ng-update-model-debounce="500" for 500ms

Custom timeouts for each event can be set for each event if you use an object in ng-update-model-on. I.e. ng-update-model-on="{default: 500, blur: 0}"

You can specify both attributes in any tag so they became the default settings for any child control, although they can be overriden.

Closes #1285

I have a problem with validating inputs that are generated dynamically. Here is the fiddle that shows the problem: http://jsfiddle.net/flsilva/8JzDb/17/

this is taken from: https://groups.google.com/forum/?fromgroups=#!topic/angular/qLeUWZVuQMI

the name is generated fine but it's not bound to the form scope. Because I can name it correctly but the form is not bound, it seems that this behavior is inconsistent.

Thoughts?

I'm having problems with Safari 6.0 auto-complete on some simple forms on Angular 1.0.2.

When Safari uses auto-complete to fill in the form, Angular seems to be unaware of the new characters that were entered by auto-complete.
Please see the attached image for an example.

To reproduce:

1. Enter data into the form a few times so that auto-complete is activated.
2. Then enter a few characters that triggers an auto-complete.
3. Hit return.
4. Compare the alert message with the contents of the input field.

I've created a jsFiddle that can be used to reproduce the problem: http://jsfiddle.net/msgilligan/5cynT/

I've seen a similar problem when Safari 6.0 or Chrome 22.0.1229.79 automatically fills in a password field that has a 'required' attribute. The form is not marked as valid and I have to go enter a space after the password and then delete it.

We have a paradigm in our app that user's create new things on the same page that they view things. So our route is like /thing/:id. When creating a new thing they go to /thing/new. Once the thing has been successfully saved we want to change the route to /thing/1234 (or whatever its new id is). Now the partial doesnt need to be reloaded because the data is all the same. We just want the path to be updated so a user can now bookmark the correct link, etc.

Having an option on $location (not on the route definition) to enable/disable route loading would work but I'm sure there are other ways to implement the feature.

I am using on iOS 8 GM(iPhone5C). With this device, I am getting this error in this line(https://github.com/angular/angular.js/blob/master/src/ng/rootScope.js#L216) But on iOS 8 GM(iPhone5S) and iOS 7.x (iPhone5C, iPhone5S), this error does not occur.

To resolve this error, I rewrote the code as follows:

$new: function(isolate) {
        var child;

        if (isolate) {
          child = new Scope();
          child.$root = this.$root;
          // ensure that there is just one async queue per $rootScope and its children
          child.$$asyncQueue = this.$$asyncQueue;
          child.$$postDigestQueue = this.$$postDigestQueue;
        } else {
          // Only create a child scope class if somebody asks for one,
          // but cache it to allow the VM to optimize lookups.
          if (!this.$$ChildScope) {
            this.$$ChildScope = function ChildScope() {
              this['$$watchers'] = this['$$nextSibling'] =
                  this['$$childHead'] = this['$$childTail'] = null;
              this['$$listeners'] = {};
              this['$$listenerCount'] = {};
              this['$id'] = nextUid();
              this['$$ChildScope'] = null;
            };
            this.$$ChildScope.prototype = this;
          }
          child = new this.$$ChildScope();
        }
        child['this'] = child;
        child['$parent'] = this;
        child['$$prevSibling'] = this.$$childTail;
        if (this.$$childHead) {
          this.$$childTail.$$nextSibling = child;
          this.$$childTail = child;
        } else {
          this.$$childHead = this.$$childTail = child;
        }
        return child;
      },

The situation has improved, but I do not understand the reason...

The following simple HTML demonstrates the issue:

<!DOCTYPE html>
<html>
    <head>
        <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.3.16/angular.js"></script>
        <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.3.16/angular-route.js"></script>
        <script>
            angular.module('fail', ['ngRoute'])
            .config(function($routeProvider) {
                $routeProvider
                .when('/a', {
                    template: '<a ng-href="#/b">a</a>'
                })
                .when('/b', {
                    template: '<a ng-href="#/a">b</a>'
                })
                .otherwise({
                    redirectTo: '/a'
                });
            });
        </script>
    </head>
    <body ng-app="fail">
        <div ng-view></div>
    </body>
</html>

This runs as expected on most devices, but it throws an infinite digest exception on iOS 9. I'm able to reproduce on both iPad Air 2 and iPad 4th generation with iOS 9 beta 2. I realize it's probably an issue in iOS, but it might still be worth investigating.

I would like to be able to bind to the progress event of the xhr upload.

for example (in plain javascript):

var xhr = new XMLHttpRequest(); xhr.upload.addEventListener("progress", uploadProgress, false)

(so I can show a progress meter for uploaded files)

I want to be able to do the same thing by doing $http.post...

for this and any other case edge case where you need to interact with the raw XHR object itself it might be nice to provide something that lets you just get at the original xhr object.

hi trying to do a simple file upload :) but the input of type=file dont seem to bind ive tried hg-model-instant but get nothing, even upgraded to 1.0.2 and nothing

BREAKING CHANGE:

This commit introduces the notion of "private" properties (properties whose names begin and/or end with an underscore) on the scope chain. These properties will not be available to Angular expressions (i.e. {{ }} interpolation in templates and strings passed to $parse) They are freely available to JavaScript code (as before).

Motivation

Angular expressions execute in a limited context.  They do not have direct access to the global scope, Window, Document or the Function constructor.  However, they have direct access to names/properties on the scope chain.  It has been a long standing best practice to keep sensitive APIs outside of the scope chain (in a closure or your controller.)  That's easier said that done for two reasons: (1) JavaScript does not have a notion of private properties so if you need someone on the scope chain for JavaScript use, you also expose it to Angular expressions, and (2) the new "controller as" syntax that's now in increased usage exposes the entire controller on the scope chain greatly increaing the exposed surface.  Though Angular expressions are written and controlled by the developer, they (1) typically deal with user input and (2) don't get the kind of test coverage that JavaScript code would.  This commit provides a way, via a naming convention, to allow publishing/restricting properties from controllers/scopes to Angular expressions enabling one to only expose those properties that are actually needed by the expressions.

I've tried my luck at the Gitter channels with limited success so I'm trying my last resort :)

What's the current way of importing the new component router to a project?

I see most recent work is in angular/angular repo but don't seem to find a recent package anywhere. The JSPM angular-new-router package points to @btford's repo and brings version 0.5.3 which looks pretty outdated.

Please see this demo: https://jsbin.com/yixote/11/edit?html,js,output

Thanks to "bindToController" in angular 1.3, we're able to create a much simpler api for building components.

Just as "angular.service" helps us to easily build an "angular.provider", I strongly believe a simplified "angular.component" could help us easily build components with "angular.directive".

I'm sure everyone will have plenty of feedback :)

I suppose this doesn't meet the LTS definition of a critical bug. But I am going to file it here in case it is - at the very least - helpful to other people.

I spent a lot of time tracking down this issue. It's confusing and non-obvious why this would happen.

I'm submitting a ...

• [ ] regression from 1.7.0
• [ ] security issue
• [ ] issue caused by a new browser version
• [x] other

Current behavior:

If you initialise, or clear a <input type="number"> field to blank (ie ""). It's ng-change handler will always be called on submit. Even if it has not been changed.

Expected / new behavior: Change handler does not get called.

Minimal reproduction of the problem with instructions: An example

<script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.8.2/angular.min.js"></script>

<div ng-app="app">
  <div ng-controller="MainCtrl">
    <form ng-submit="submit()">
      <input type="number" ng-model="form.testNumber" ng-change="changed()"/>
      <button type="submit">Submit</button>
    </form>
  </div>
</div>

var app = angular.module("app", []);

app.controller("MainCtrl", function ($scope) {
    $scope.form = {
      testNumber: ""
    };

    $scope.changed = function () {
        console.log("changed");
    };

    $scope.submit = function () {
        console.log("submitted");
    };
});

see: http://jsfiddle.net/6qxrygzm/1/

Click the submit button in the demo. The console will log the message "changed" even though the field is untouched from its initialised value.

AngularJS version: 1.8.2

Browser: all | Chrome 98.0.4758.102 | Firefox 97.0.1 (64-bit)

Anything else:

Bumps shelljs from 0.7.6 to 0.8.5.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps marked from 0.3.6 to 4.0.10.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps follow-redirects from 1.13.0 to 1.14.7.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

AngularJS is in LTS mode

We are no longer accepting changes that are not critical bug fixes into this project. See https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.

Does this PR fix a regression since 1.7.0, a security flaw, or a problem caused by a new browser version?

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

• [x] The commit message follows our guidelines
• [x] Fix/Feature: Docs have been added/updated
• [x] Fix/Feature: Tests have been added; existing tests pass

Other information:

AngularJS is in LTS mode

We are no longer accepting changes that are not critical bug fixes into this project. See https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.

I'm submitting a ...

• [ ] regression from 1.7.0
• [ ] security issue
• [ ] issue caused by a new browser version
• [x] other

Current behavior:

• Described in PR https://github.com/angular/angular.js/pull/17141

Expected / new behavior:

• dgeni and dgeni-packages can be updated without breaking the markdown rendering of the docs

Minimal reproduction of the problem with instructions:

1. Update dgeni and dgeni-packages
2. Run the docs and see rendering issues with markdown.

AngularJS version: 1.8.2 Browser: all

Anything else:

The alternative to this labor intensive task is pinning marked to0.3.6` as is done in PR https://github.com/angular/angular.js/pull/17141.

However, in https://github.com/angular/angular.js/pull/17141#discussion_r646466923, Pete suggested that

Rather than pinning marked we should just fix the docs to be CommonMark compliant.