Node allows executable scripts to use the unix shebang (#!/usr/bin/env node) convention. It seems buddy.js chokes on this, which is probably an issue with the upstream parser or the configuration thereof:

{ [SyntaxError: Unexpected character '#' (1:0)] pos: 0, loc: { line: 1, column: 0 }, raisedAt: 0 }

I've been having an issue with buddyjs recently where in my grunt task it will error out saying something along the lines of:

Running "buddyjs:src" (buddyjs) task
[TypeError: Object
## CONTENTS OF ONE OF MY JS FILES ##
 has no method 'split']
Warning: Task "buddyjs:src" failed. Use --force to continue.

Aborted due to warnings.

Now this seems to be because its expecting a large string to split on newlines, however it's an object.

Line of code that assumes this: https://github.com/danielstjules/buddy.js/blob/8558a9d5ed2098325b462d30895c9c2db0f5ea74/lib/detector.js#L152

The method expects contents to be a string, where in this case it seems to be the raw buffer and not a string, causing the split on newlines to fail.

I have a case where I am converting seconds to ms. e.g.

var MS = SECONDS * 1000;

Currently, I'd have to rewrite 1000 as a const or ignore it everywhere. Instead, I'd like to be able to ignore that line with a comment.

Buddy.js report negative number even though they are stored in const :

src/attachmentMappers/retailMappers.js:3  | const EMPTY_INDEX_OF = -1;

 1 magic number found across 34 files

v0.9

Consider the following file:

var x = {
    statusCode: 200,
    y: function() {
        z = 100;
    }
};

Buddy doesn't report the 200 as being a magic number. Though it will report the 100.

Hi Daniel,

I'm using buddy.js in version 0.7.0:

./node_modules/buddy.js/bin/buddy --version

My source snippet is:

return b = Math.random() * 16, (a === 'y' ? (b & 3 | 8) : (b | 0)).toString(16); // buddy ignore: line

Calling buddy.js returns warnings:

./snippet.js:1 | return b = Math.random() * 16, (a === 'y' ? (b & 3 | 8) : (b | 0)).toString(16); // buddy ignore: line
./snippet.js:1 | return b = Math.random() * 16, (a === 'y' ? (b & 3 | 8) : (b | 0)).toString(16); // buddy ignore: line
./snippet.js:1 | return b = Math.random() * 16, (a === 'y' ? (b & 3 | 8) : (b | 0)).toString(16); // buddy ignore: line
./snippet.js:1 | return b = Math.random() * 16, (a === 'y' ? (b & 3 | 8) : (b | 0)).toString(16); // buddy ignore: line

 4 magic numbers found across 6 files

Did I miss something?

With kind regards Marco

If you make a file with the following contents:

console.log(0x1A + 0x02);
console.log(071);

The output from Buddy is rather interesting:

$ buddy .

./test.js:1 | console.log(26 + 0x02);
./test.js:1 | console.log(0x1A + 2);
./test.js:2 | console.log(57);

3 magic numbers found across 1 file

Notice how the hex/octal numbers are converted to decimal before being logged.

Hi Daniel,

unfortunately buddy binary returns wrong version number if called with:

$ ./bin/buddy --version
0.0.1

Although dependencies are declared the following:

"buddy.js": "^0.2.1"

and the downloaded version contains 0.2.1 in it's own package.json.

Maybe this issue is already fixed in newer versions.

With kind regards Marco

NOTE: I know nodeJS v0.11.x does not have a stable release yet, so it is not really that important I guess?

With ECMAScript 6, support for generators is added. Currently, this requires one to use the --harmony flag to run node scripts that make use of generators. There is an issue with buddy.js, because these functions are indicated by asterisk notation.

function* foo(x) {
    yield x + 1;

    var y = yield null;
    return x + y;
}

The issue is that buddy.js notices an unexpected token (the *) and shuts down by this error.

Hello! For myself, I've created gulp plugin. Perhaps it may be necessary to someone else. It would be great if you added my plugin to README as grunt plugin.

https://github.com/Semigradsky/gulp-buddy.js

A common use case is to only use contents parsing instead of file path parsing. This patch separates concerns between reading file path and parsing contents.

What is the change

Add "Related Section" referencing ESlint's magic number rule.

Purpose of Change

1. Expose more people to the awesome-ness of no magic numbers.
2. ESlint is constantly updating and maintaining their version of 'no magic numbers' linter rule that works with modern javascript & typescript. It seems like this repo hasn't been updated in a while.
3. Most people when they search 'no magic numbers' in javascript frequently land here. It would be nice for them to also know that it exists in ESlint as part of a core rule.

Questions

Are you ok with putting a notice in the beginning of the README, indicating to user's that it's worth checking out ESlint's version in the spirit of getting more people exposed to 'no magic numbers'?

I added a local version of jQuery to my a repo, and now Buddy is failing with over 60 magic numbers found.

Is there any way to ignore a path?

Or can --ignorePath be added as a cli option?

Thank you!