so I made a bug :( I wasn't formatting back to an AST for any of the other options other than printing to stdout, this fixes that.

The only thing now that might be a little weird, is if you try to use --diff or --list when the original is not an AST but you use --save-ast not sure how I wanted to handle it, but leaving as-is for now.

Mostly I was looking for a way to format to 4 spaces and not 2. Originally I added a cli option to set the number of spaces to indent, but I think this might be a better option?

Also I wasn't sure how I should document an example (if you feel one is necessary).

If someone could play around with this (test it out) I'd appreciate it. I've added some tests and it seems to work great but I want to make sure I didn't miss any edge cases.

This fixes #28

This might already work, I haven't tested it. But it would be nice if it formatted json too (since its a "subset" of js anyway).

I suspect it will choke on the floating object declaration without an accompanying variable declaration.

this addresses #18

I have been thinking about updating the travis setup to use grunt, that way the travis build will fail when jshint doesn't pass. Thoughts?

jshint has found a few issues with rewrite.js, think we either need fix the issues or change the jshint config to allow things we want.

Running "jshint:lib" (jshint) task

   lib/rewrite.js
     56 |  if (pattern == null && node != null) {
                       ^ Use '===' to compare with 'null'.
     56 |  if (pattern == null && node != null) {
                                       ^ Use '!==' to compare with 'null'.
     60 |  if (pattern != null && node == null) {
                       ^ Use '!==' to compare with 'null'.
     60 |  if (pattern != null && node == null) {
                                       ^ Use '===' to compare with 'null'.
     64 |  if (wildcards != null && isWildcard(pattern)) {
                         ^ Use '!==' to compare with 'null'.
     87 |      && match(wildcards, pattern.value, node.value);
               ^ Bad line breaking before '&&'.
     93 |      && match(wildcards, pattern.property, node.property);
               ^ Bad line breaking before '&&'.
    103 |      && match(wildcards, pattern.right, node.right);
               ^ Bad line breaking before '&&'.
    106 |      && match(wildcards, pattern.test, node.test)
               ^ Bad line breaking before '&&'.
    107 |      && match(wildcards, pattern.update, node.update)
               ^ Bad line breaking before '&&'.
    108 |      && match(wildcards, pattern.body, node.body);
               ^ Bad line breaking before '&&'.
    170 |      && match(wildcards, pattern.init, node.init);
               ^ Bad line breaking before '&&'.
    194 |      if (wildcards != null && isWildcard(replacement)) {
                             ^ Use '!==' to compare with 'null'.
    207 |      for (var i = 0; i < replacement.elements.length; i++) {
                          ^ 'i' is already defined.
    217 |      for (var i = 0; i < replacement.arguments.length; i++) {
                          ^ 'i' is already defined.
    223 |      for (var i = 0; i < replacement.params.length; i++) {
                          ^ 'i' is already defined.
    226 |      for (var i = 0; i < replacement.defaults.length; i++) {
                          ^ 'i' is already defined.
    233 |      for (var i = 0; i < replacement.params.length; i++) {
                          ^ 'i' is already defined.
    236 |      for (var i = 0; i < replacement.defaults.length; i++) {
                          ^ 'i' is already defined.
    250 |      for (var i = 0; i < replacement.declarations.length; i++) {
                          ^ 'i' is already defined.
    273 |      for (var i = 0; i < replacement.properties.length; i++) {
                          ^ 'i' is already defined.
    310 |}
          ^ Missing semicolon.
    327 |      })
                 ^ Missing semicolon.
    331 |}
          ^ Missing semicolon.

>> 24 errors in 6 files

Hi,

I note that switch statement use wrong tabulation:

function execute() {
  switch (test) {
  case a:
    break;
  }
}

It should be:

function execute() {
  switch (test) {
    case a:
      break;
  }
}

Let me know if I miss configuration possibilities or if you can enhance jsfmt with this?

Thank you!

If I jsfmt this:

if(a)
  a(); // run a
else if(b)
  b(); // run b
else {
  c(); // run c
}

It does some crazy munging into the comment:

if (a)
  a(); // run aelse if (b)b()
  ; // run b else {
  c(); // run c
}

If I do it without the comments it at least doesn't cause a syntax error, but does it make it quite ugly:

if (a)
  a();else if (b)b()
  ; else {
  c();
}

jsfmt diff ignores space changes git diff -b and when running jsfmt --diff=true --format=true ./rewrite.js I missed a bunch of continuation changes that I didn't actually intend to make:

diff --git a/rewrite.js b/rewrite.js
index 3675a93..9a638b0 100644
--- a/rewrite.js
+++ b/rewrite.js
@@ -84,13 +84,13 @@ function match(wildcards, pattern, node) {
         return false;
       }
       return match(wildcards, pattern.key, node.key)
-          && match(wildcards, pattern.value, node.value);
+      && match(wildcards, pattern.value, node.value);
     case 'MemberExpression':
       if (pattern.computed != node.computed) {
         return false;
       }
       return match(wildcards, pattern.object, node.object)
-          && match(wildcards, pattern.property, node.property);
+      && match(wildcards, pattern.property, node.property);
     case 'ArrayExpression':
       return partial(wildcards, pattern.elements, node.elements);
     case 'ObjectExpression':
@@ -100,12 +100,12 @@ function match(wildcards, pattern, node) {
         return false;
       }
       return match(wildcards, pattern.left, node.left)
-          && match(wildcards, pattern.right, node.right);
+      && match(wildcards, pattern.right, node.right);
     case 'ForStatement':
       return match(wildcards, pattern.init, node.init)
-          && match(wildcards, pattern.test, node.test)
-          && match(wildcards, pattern.update, node.update)
-          && match(wildcards, pattern.body, node.body);
+      && match(wildcards, pattern.test, node.test)
+      && match(wildcards, pattern.update, node.update)
+      && match(wildcards, pattern.body, node.body);
     case 'VariableDeclaration':

is this the desired behavior? if not, I might suggest removing the -b option from jsfmt diff.

It looks like this issue stemmed from us using different AST parsers for different features:

• Rewrite is using falafel, whose default is Acorn
• Esprima is used everywhere else

This PR migrates away from Acorn for rewrite by providing an esprima parser.

This PR creates an internal interface for parsing/walking which centralises control of which parser implementation we use and how we walk the AST.

When running jsfmt -v test.js where test.js contains:

var o = {
    a: 0,
    get b() {}, 
    set c(x) {}
};

I get no error, but with:

var o = {
    get b() {}, 
    set c(x) {}
};

I get test.js [TypeError: Cannot read property 'value' of undefined]

and with:

var o = {
    get b() {}, 
};

I get test.js [TypeError: Cannot read property 'root' of undefined]

@jimfleming, this was my attempt at trying to support loading/saving as AST, I dont expect it to be perfect, but a random attempt.

tries to take care of #102

I am using react 16.8.6. My code is working fine but I am getting syntax error. jsfmt don't support below import code. exportCsv = () => { this.setState({ isExporting: true }); import('./exportToCsvV2').then(bundle => { try { // some code } catch (e) { throw e; } }); };

Bumps deep-extend from 0.4.2 to 0.6.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Given this repository has not been updated in quite some time, and has open security vulnerabilities, I propose that we follow an Apache-compatible license and publish an updated fork to npm as a separate package.

Please update the deep-extend dependency to at least v0.5.1, in order to resolve multiple security risks:

• https://npmjs.com/advisories/612
• https://npmjs.com/advisories/612

Please patch or replace esformatter so that the debug dependency rises to:

• 2.6.9
• 3.1.0
• 4.0.0

In order to resolve a security risk.

https://www.npmjs.com/advisories/534