Thank you for this great resource. I'm using it to download files returned from a request that uses a proxy and the link to the documents cannot simply be placed in an <a href>

I can successfully download all file types with the exception of the microsoft office docx and xlsx types. When attempting to open the downloaded files with MS Office I get an error message stating that they are corrupt and cannot be repaired.

I have tried including the correct mime type application/vnd.openxmlformats-officedocument.wordprocessingml.document

AND

leaving the mime type blank (anddefaulting to application/octet-stream)

Both result in corrupted file.

Any ideas how to support the download of those file types correctly?

my code:

var x = new XMLHttpRequest();
 x.open("GET", attachUrl, true);
 x.responseType = 'blob';
// with correct mime type
//x.onload = function (e) { download(x.response, name, file.ContentType); }
// without mime type
x.onload = function (e) { download(x.response, name); }
console.log(file.ContentType);
x.send();

and the error message in MS Office

Hi, When using download.js, some characters became dashes. http:// became http--- for exemple.

tested codepen with debug mod.

Thanks for your support !

This does not seem to work on safari 9+

http://pagedemos.com/sxks39b72aqb/1 http://pagedemos.com/sxks39b72aqb/2

generate nothing

http://pagedemos.com/sxks39b72aqb/3

Failed to load resource: Frame load interrupted

The library breaks PDF file and produces invalid PDF which opens with blank pages. PDF Example: http://partners.adobe.com/public/developer/en/xml/AdobeXMLFormsSamples.pdf

Code:

$.ajax({
        url: '/AdobeXMLFormsSamples.pdf',
        success: download.bind(true, "application/pdf", 'AdobeXMLFormsSamples.pdf'), 
        complete: function(){...}
    });

Tested on browsers:

• Chromium Linux Version 44.0.2403.61 (64-bit)
• Firefox Linux 38.0.5

Hi, in my app i was using just this piece of js:

var link = document.createElement("a"); link.download = dataItem.Filename; link.href = data; link.click();

where data is the data uri with mime type etc... this is working perfectly on chrome, but not in ie so i used your library, and it's perfect for ie the only issue is that is not working with documents like docx, ods...

Hi,

maybe it's a simple question, but I can't make it myself:

how has the function to look alike if I want to download an existing file?

like the filename is "image.jpg"?

thank you!

In the saver() function where an invisible anchor element is used to start the download, clicks are allowed to bubble up to the document root.

https://github.com/rndme/download/blob/31cf0fa096b2171c569e694e2416df2182449d01/download.js#L111

It would be great if the call to anchor.click() would stop clicks from propagating to the body element.

This is quite an old bug but it looks like it has not been resolved yet. Basically when I try to use your plugin to download a base64 that is bigger than several MB (from a canvas), I get "network error" instead of the proper file. Probably you should switch to Blob if the base64 string is too long.

Using base64 encoded content, I can download text and images. I can also download PDFs in chrome.

However, I'm getting an error when downloading the same PDF in Internet Explorer 11.

index.txt

How can I fix this?

I've tried setting up a simple string download which works fine in Chrome and Firefox but not in Safari 7.1. After triggering the download I can see the data being inserted into the current page real quick and then it disappears.

download('This is some string', filename, 'text/plain');

I don't know how to describe it properly, and neither do I have a MRE. But it seems that if the main function is called "download", that creates an error as described in the title.

I have renamed your function to something else (e.g. "downloadit") and then it worked.

No idea what might be triggering this error (I am using OS X version 10.9.5 and Chrome Version 64.0.3282.167), but I hope this might be of help somehow.

I'm using this library to download files from our API. But now i see that if I start more than 80 requests instantly and then I download them using this lib, some files are not downloaded (no errors seen in console or in requests). Requests seems to be there with status: 200, but there are missing files in my downloads folder. This works ok in FF. Anyone had this issue? I've managed to improve this by not starting all requests when user press 'download' all, I've created a Queue and when some requests are done, i'm starting others.

Hi,

Thanks you very much for this great resource. I am using this to download Excel file with extension .xls by passing the html data as a data variable and no issues found it works perfectly as expected. But now I need to download the same Excel file with extension .xlsx and I have tried calling download function as per below code snippets:

download(data, "text.xslx", "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet")

And also: download(data, "text.xslx", "text/xlsx")

It always gives me below error when I open the downloaded file:

I read all the relevant articles but could not find the solution. There was an article/issue which was fixed(https://github.com/rndme/download/issues/21) but that was related to the download .xlsx file from the URL and I need to download from the data which I am passing. This passing data contains the dynamically generated html file.

Could you please help me in resolving this issue or guide me what mistake I am making ?

Thanks in advance ! Ajay

Hello Dan!

I'm using your "download" library quite often - thank you very much for this work!

But since I'm mostly developing in TypeScript now, I thought it might be a good idea to provide a type declaration file for it.

And, well, since I'm also developing with Svelte, I just added an export declaration for package.json as well.

Perhaps, you'll find it useful.

With greetings from Germany,

Andreas Rozek

Chrome don't support download attribute in anchor tag when yo click this link chrome force to download file and in my case need that open file and don't work if remove download attribute work fine.

function saver(url, winMode) { if ('download' in anchor) { //html5 A[download] anchor.href = url; anchor.setAttribute("download", fileName); //THIS LINE anchor.className = "download-js-link"; anchor.innerHTML = "downloading..."; anchor.style.display = "none"; document.body.appendChild(anchor); setTimeout(function () { anchor.click(); document.body.removeChild(anchor); if (winMode === true) {setTimeout(function () { self.URL.revokeObjectURL(anchor.href);}, 250);} }, 66); return true; }