starter kit for interacting with zora api, protocol, and creator toolkit

Summary

👋 Hi @0xTranqui ! Thanks for creating this starter kit.

I'm wondering if there are plans to migrate Deploy to Rinkeby to Deploy to Görli, now that https://testnet.create.zora.co/ has ported over to the Goerli testnet? 💭

Friendly references

• Ethereum Blog - testnet deprecation
• Zora Discord Server - #developers thread

Hi 0xTranqui, I was working on extending your zora starter kit to support my Barter based zora offers market place. I found a bug in code when going through it.

When setOfferAmount is called by the user with a particular offer price we're sending the offer price as it is as msg.value to the OffersV1 contract.

` const offerPrice = setOffer.amount ? ethers.utils.parseEther(setOffer.amount) : ""

const { data: setOfferData, isError: setOfferError, isLoading: setOfferLoading, isSuccess: setOfferSuccess, write: setOfferWrite  } = useContractWrite({
    addressOrName: mainnetZoraAddresses.OffersV1,
    contractInterface: abi,
    functionName: 'setOfferAmount',
    args: [
        offerContractAddress,
        offerTokenId,
        setOffer.offerId,
        setOffer.currency,
        offerPrice,
    ],
    overrides: {
        value: offerPrice
    },
    onError(error, variables, context) {
        console.log("error", error)
    },
    onSuccess(setOfferData, variables, context) {
        console.log("Success!", setOfferData)
    },
})

`

Say I made an initial offer of 0.1 ETH for a NFT. Now say I want to increase my offer to 0.2 ETH. The current SetOfferAmount component will send the whole 0.2 ETH again. As a result I would have paid the OffersV1 contract 0.3 ETH but according to my offer stored in OffersV1 storage I have only paid 0.2 ETH. Only 0.2 ETH would be refunded in the case where I cancel the offer.

To fix this I have first read the offer from OffersV1 storage to get the previous amount and then computed the difference with current amount and only sent the difference to OffersV1.

In case current amount is less than prev amount we send 0 ETH. Letting OffersV1 take care of the refunds. In case of crypto currencies other ETH we send 0 ETH too.

I made the fix and created a pull request here: #3

Fix for sending only the difference between previous offer and current offer instead of sending current offer ETH fully to OffersV1. For detailed explanation please check the related issue.

Summary

👋@0xTranqui - hi again! By way of #1, would you be open to adding a license to this project? 💭

Without one, this project is under exclusive copyright by default and unless otherwise specified, nobody else can copy, distribute, or modify your work without being at risk of take-downs, shake-downs, or litigation. Once the work has other contributors (each a copyright holder), “nobody” starts including you. 😅

I humbly suggest the MIT License or The Hippocratic License as some options. If you're up for it and know which one you'd like, I wouldn't mind cutting a PR for it too! ✌️