Which issues does this PR resolve?

#22

How were things before and how does this PR change that? (If UI change add images)

There were no EOF in gitinore file

How should I review this PR? (Add implementation details, files to start with, etc.)

gitignore should have an EOF .

Reviewer Checklist

• [ ] Understood the purpose of the PR.
• [ ] Tested it locally. Check for mobile compatibility if applicable.
• [ ] Checked that we don't have any merge conflicts.
• [ ] Went through the code line by line.

Which issues does this PR resolve?

-There's an issue when generating a typescript app using the cli because of a recent upgrade in typescript.

How were things before and how does this PR change that? (If UI change add images)

Before:

After:

How should I review this PR? (Add implementation details, files to start with, etc.)

Generate a typescript app using the CLI to recreate the issue. Upgrade type-node package to fix the issue.

Reviewer Checklist

• [ ] Understood the purpose of the PR.
• [ ] Tested it locally. Check for mobile compatibility if applicable.
• [ ] Checked that we don't have any merge conflicts.
• [ ] Went through the code line by line.

Which issues does this PR resolve?

resolves #21

How were things before and how does this PR change that? (If UI change add images)

update project name in the generated pakcage json

How should I review this PR? (Add implementation details, files to start with, etc.)

check the newly wrote code and the removed lines

Reviewer Checklist

• [ ] Understood the purpose of the PR.
• [ ] Tested it locally. Check for mobile compatibility if applicable.
• [ ] Checked that we don't have any merge conflicts.
• [ ] Went through the code line by line.

Which issues does this PR resolve?

/resolves #4

How were things before and how does this PR change that? (If UI change add images)

Added an option to setup jest as a testing library

How should I review this PR? (Add implementation details, files to start with, etc.)

• Check the files that changed

Reviewer Checklist

• [ ] Understood the purpose of the PR.
• [ ] Tested it locally. Check for mobile compatibility if applicable.
• [ ] Checked that we don't have any merge conflicts.
• [ ] Went through the code line by line.

Thanks for the good work !

Which issues does this PR resolve?

Add cookies-parser, cors, morgan, .env.example

How were things before and how does this PR change that? (If UI change add images)

N/A

How should I review this PR? (Add implementation details, files to start with, etc.)

templates/{ts|js}/{.env.example, src/index, package.json, src/config/contstants}

Reviewer Checklist

• [ ] Understood the purpose of the PR.
• [ ] Tested it locally. Check for mobile compatibility if applicable.
• [ ] Checked that we don't have any merge conflicts.
• [ ] Went through the code line by line.

Describe the bug (add an image if UI bug)

There is no end of file in gitignore file of the generated template and github apone creating PRs will later point it out

Which browser or device was used?

--

Steps to reproduce

1 - Use the templete generator and create a project. 2 - Check the generated .gitignore file

Additional context (any extra information)

Is your proposal related to a problem?

Right now we're copying package.json into the new generate template, the problem is that the project name won't be reflected into the new template.

Describe the solution you'd like

It would be best if we could generate the package.json with the initial package options.

Describe alternatives you've considered

N/A

Additional context

N/A

Which issues does this PR resolve?

resolves #16

How were things before and how does this PR change that? (If UI change add images)

Improved initial template

How should I review this PR? (Add implementation details, files to start with, etc.)

Check the new template files

Reviewer Checklist

• [ ] Understood the purpose of the PR.
• [ ] Tested it locally. Check for mobile compatibility if applicable.
• [ ] Checked that we don't have any merge conflicts.
• [ ] Went through the code line by line.

Which issues does this PR resolve?

resolves #14

How were things before and how does this PR change that? (If UI change add images)

Now: .gitignore is being copied to the newly generated repository.

How should I review this PR? (Add implementation details, files to start with, etc.)

Reviewer Checklist

• [ ] Understood the purpose of the PR.
• [ ] Tested it locally. Check for mobile compatibility if applicable.
• [ ] Checked that we don't have any merge conflicts.
• [ ] Went through the code line by line.

Which issues does this PR resolve?

resolves #6

How were things before and how does this PR change that? (If UI change add images)

Before on Windows: When husky options is chosen a new file with 6 as it's name is generated. Now: I've added a check if that file is generated and remove it if it's there.

How should I review this PR? (Add implementation details, files to start with, etc.)

Check the new generated code.

Reviewer Checklist

• [ ] Understood the purpose of the PR.
• [ ] Tested it locally. Check for mobile compatibility if applicable.
• [ ] Checked that we don't have any merge conflicts.
• [ ] Went through the code line by line.

Describe the bug (add an image if UI bug)

Running npx mrm@2 lint-staged on windows results in a file that has some logs called 6 to be generated.

Which browser or device was used?

Windows

Steps to reproduce

• Start using the CLI.
• Choose different options to match your needs.
• Choose Setup husky for git hooks.
• Here if you're on Linux or MacOS everything works fine, but when you're on windows the file 6 appears with npm install logs.

Additional context (any extra information)

n/a

Is your proposal related to a problem?

No

Describe the solution you'd like

Switch to Nodejs native modules instead of using modules from npm

Describe alternatives you've considered

N/A

Additional context

Some modules can be replaced with native modules which will result in smaller package size and faster initial download.

Is your proposal related to a problem?

nope :)

Describe the solution you'd like

I'd like to request having a format script in package.json something like "format": "prettier --write ."

and can we also have .editorconfig so the all parties developing wont have overlapping configs

Describe alternatives you've considered

(Write your answer here.)

Additional context

(Write your answer here.)