For Pingvin Share, the email notification only seems to work with GMail's SMTP service. Would it be possible to get compatibility with SendGrid. Currently you request the smtp host, smtp email, smtp password, and smtp port. For SendGrid to work, there also needs to be a spot for the smtp username, which can be different than the smtp email.

Hey,

really love pingvin and the feature to send mail notifications for shares.
Any chance we could define that notification message ourselves in a text box or something?

Forgive the incorrect location for this. I saw your contributing section, but I don't have enough time at the moment to work on this, but I have thought about creating something similar for a few years without much success getting started.

I think a key element for a system like this is to offer the ability to create a "my account" section for those that are downloading uploads. The use case is most folks (in my estimation, at least my own mileage) use systems like this to transfer files to customers (think creative content creators). I have a buddy who works for Viacom (BET, MTV, Comedy Central, etc.) as an imaging director for their TV/Radio commercials. He uses WeTransfer (paid version) so he can get information from the download(er) such as IP address, time/date of download, etc. to verify the product was collected. Further, he uses it when other customers (smaller promoters) attempt to say they didn't get a download and dispute the CC charge.

Having a system that allows for a list of files that have been assigned to a user account so they can log in and see their past "content" would be an amazing feature, potentially even a paid feature.

I don't know if this is possible with the structure you are creating or if even is an acceptable 'request'. Would love to help with the project in the future (as time and my wife permits).

Cheers!

I was working on issue #28 and I realized that my editor kept auto-formatting the code in a way that was different from the rest of the code. I think it would be a good idea to add a .editorconfig file so that contributors' IDEs and formatting stay consistent.

editorconfig reference: https://editorconfig.org/

Hello, Is a 2 factor authentication for the admin planned ? so that the admin account is better protected ? with an authentication app. like google authenticator or Authy I would be happy if this could be implemented. Keep up the good work :)

I wrote issue #8 and realized after I opened PR #11 that it would make much more sense to have even more granular expiration selection.

Something like this:

Based on the source code, it shouldn't be too hard to implement. Maybe I can replace PR #11 with a feature like this?

These lines could essentially stay exactly the same: https://github.com/stonith404/pingvin-share/blob/cde22f85ee785363bb0149347a2187c9166f4cb6/backend/src/share/share.service.ts#L38-L43

Pretty much the only thing that would need to change would be: https://github.com/stonith404/pingvin-share/blob/b30269344db456a83b846247725fa9ea242e3d94/frontend/src/components/share/CreateUploadModalBody.tsx#L102-L115

and a little bit of frontend logic.

It could even be a little more advanced, giving a preview of the exact time the share would expire:

What do you think?

👟 Reproduction steps

Upgraded from 0.5.0 to 0.5.1 it quit working

👍 Expected behavior

It to work. Is 0.5.1 broke? Tried to downgrade docker to 0.5.0 and didn’t work either. Scratches head

👎 Actual Behavior

Doesn’t work; just 502

🌐 Browser

Safari

Resolves #30

• Switched from node:slim to node:alpine
• Better multi-stage build for caching (makes docker build faster in a lot of cases)
• Corrected/improved builds (standalone, output-file-tracing, removing node modules)

New Features

• Adds granular control of expiration date, being able to set a specific duration for when the share will expire (resolves #12)
• Adds the ability to disable the expiration date of a share (resolves #8)
• Configurable 12/24 hour selection using the frontend's .env file

What changed

• Added some missing dependencies to package.json (it wouldn't run without)
• Updated rx.js Without updating rx,js, an error was thrown when trying to access the database. (TypeError: (0 , rxjs_1.lastValueFrom) is not a function)
• Replaced expiration dropdown with a numerical input and a dropdown for "unit selection" (minutes, hours, days, etc.)
• Added the "Never" expiration checkbox option to the "create share" modal (disables numerical input when checked)
• Added small tooltip under expiration selection previewing when the share would expire
• Updated text (in the completed upload modal and shares page) to match the "never" expiration (text like "this share never "expires")
• Updated backend to not automatically remove "never expires" shares
• Fixed some various linting errors (mostly related to unused imports)
• Added a new environment variable in the frontend to toggle between 12-hour and 24-hour date/time previews (used in several places)

How was this implemented

The customizable expiration date changes required no changes to the backend, only the frontend needed some changes.

The "never" expiration date was implemented by using unix timestamp 0. Some manual exceptions were added to the backend to support the timestamp of 0. For example, backend/src/auth/jobs/jobs.service.ts line 20 (AND: [{expiration: {lt: new Date()}}, {expiration: {not: moment(0).toDate()}}]) now has a hardcoded exception to shares that have a expiration date of 0. There are several other changes very similar to this scattered around the backend.

The 12/24 hour modes was implemented by simply importing next's runtime config options and checking the TWELVE_HOUR_TIME option, then printing the appropriate time format.

Known Issues

There is one known issue: entering an expiration date that is too long. Some values (999999 Years for example) break the date parsing in the backend. A quick fix to temporarily resolve this issue is to limit the expiration input to a smaller value (currently set to 99999, but should be adjusted in the near future.) A better fix is to handle this specific error in the backend and return an appropriate response, then showing a proper error message in the frontend instead of just displaying "Internal server error." This issue does not significantly affect application performance.

1. upload a file
2. generate link
3. open link
4. get error " This share can't be found. Please check your link."

url - https://pingvin.MYDOMAIN.nl/share/SHARECODE

🔖 Feature description

A user shouldn't have to log in every time they visit the page.

There could be an option to "keep me logged in" when initially logging in that would create a cookie or JWT that would store the session.

🎤 Pitch

This would make uploading/downloading files easier for registered users, since they won't have to log in every time they access the page.

It would be great if admin could set default and separate limits for uploads from unregistered users, ie:

• expiration time
• file size limit
• anonymous uploads per hour/day/week/month

This would make it far more abuse resistant.

🔖 Feature description

You already have integrated mail functionality, it would be awesome to have the ability to reset a password in case the original is lost/forgotten. Sadly, I had this problem today.

🎤 Pitch

Most sites offer this, and it seems like it would be a good idea.

Question to think about: How would this impact 2FA? Does resetting 2FA upon a forgotten password (probably the simplest approach) reduce the security of 2FA too much?

🔖 Feature description

This feature would allow the admin to directly add files from his/her existing hard drives to Pingvin without uploading them to the instance.

🎤 Pitch

I make mod packs for games, and share photos, and family videos. This would allow me to attach network storage and grab a file on the drive without uploading it directly to Pingvin. I currently employ a Ceph cluster so having 3 copies of a single file on one my nodes is already enough. Adding a new VM and then uploading the file to it would mean I have 6 copies.

I also am no developer so I couldn't tell you how to do this or the complexity of it I just think it would be a neat feature.

🔖 Feature description

It would be great to have the option (i.e. in Administration settings) to make the "Password Protection" field for shares mandatory.

🎤 Pitch

This way it would be possible to force your users to set Passwords for every share they create.

🔖 Feature description

On share page, next to the download button/icon - it would be really nice to have a - copy direct link to file button/icon. You should be able to wget/curl the file in question for anywhere.

🎤 Pitch

It would be very useful to get a direct link to the file you want to download. That's useful when you open the link on a browser, but want to download the file on a remote computer via curl/wget etc.

👟 Reproduction steps

When I try to upload larger file it will just stop after few seconds. I've set the maximum upload 10GB. I've tried to send 2.4GB file, ISO and I get the errors 403 and 413 in console. Using chrome to upload.

👍 Expected behavior

Upload normally.

👎 Actual Behavior

🌐 Browser

Chrome