Feedback for @itsmraga-hub

• Optional you can use document.create to load your todos, so you can bind event listner easily.
• You can kindly try to personalize your UI
• Good use of DRY, KISS approach
• Your code follows a good approach that can be tested easily

💯 Achievements

• No linter errors.
• Followed correct GitHub Flow.
• Use jest framework for testing.
• Successfully test function to edit a task.
• Successfully test function to clear all completed by checking the returned length.
• Successfully test function to change the status of a task.
• Use mock localStorage.
• Group tests with the describe() function.

💯 Achievements

• No linter errors.
• Proper documentation and commit messages.
• Pair programming.
• Use jest framework to write tests.
• Group test using describe() method.

⚠️ Issue

• Proper use of ES6 arrow functions.

  • https://github.com/itsmraga-hub/To-Do-List/pull/3/files#diff-bfe9874d239014961b1ae4e89875a6155667db834a410aaaa2ebe3cf89820556R111
  • https://github.com/itsmraga-hub/To-Do-List/pull/3/files#diff-51b0fd417605212140c4feae53f7bf4819ef0a25da349170bffe93e31eb92029R11
  • https://github.com/itsmraga-hub/To-Do-List/pull/3/files#diff-51b0fd417605212140c4feae53f7bf4819ef0a25da349170bffe93e31eb92029R1-R2
  • https://github.com/itsmraga-hub/To-Do-List/pull/2/files#diff-a9d5cc09bfb639e03b6768ebd73079c6d4d9a75a4c23c47842010479fdcb7c7eR20-R26
  • https://github.com/itsmraga-hub/To-Do-List/pull/2/files#diff-a9d5cc09bfb639e03b6768ebd73079c6d4d9a75a4c23c47842010479fdcb7c7eR20-R26
  • https://github.com/itsmraga-hub/To-Do-List/pull/2/files#diff-a9d5cc09bfb639e03b6768ebd73079c6d4d9a75a4c23c47842010479fdcb7c7eR13-R17

• Proper ES6 class constructor

  • https://github.com/itsmraga-hub/To-Do-List/pull/2/files#diff-a9d5cc09bfb639e03b6768ebd73079c6d4d9a75a4c23c47842010479fdcb7c7eR2-R5

💯 Achievements

• Allow users to mark tasks as completed or not.
• Allow the user to clear all completed items.
• Refresh the page.
• Add a new JavaScript file and import it.
• Add event listener to all the checkboxes.

💯 Achievements

• Create a new JavaScript file with new functionality
• Implement a function for adding a new task (add a new element to the array).
• Implement a function for deleting a task (remove an element from the array).
• Implement a function for editing task descriptions.
• Save to localStorage.

💯 Achievements

• Set up the project with webpack.
• Create To Do list HTML skeleton.
• Create an array of objects with three keys as required by the project.
• Use the ES6 function to iterate over the array and write HTML content.
• Render page dynamically.

Hello @itsmraga-hub 👋,

You have done an amazing job with setting up your To-do-list project 🥇 There are some things that you can improve in the project , and I think it will help you make your code perfectly dry.

Highlights 💯

• Correct workflow ✔️
• Great file organization ✔️
• Professional documentation ✔️
• JavaScript Best practices - DRY, KISS and YAGHI ✔️

♻️ Possible Improvements ♻️

• Your todoList app looks perfect , but the submission button allows empty tasks to be added to the list. It could be better if you add a condition that prevent that. You could do

if(input.value === ' ') {
// Do not add
} else {
// Add the task 
}

• It could be better to add functionality to the three dots icons on the right of the page. Because it allows a good user experience.
• It is a good practice to allow pointer cursor to the three dots icons on the right for a better user experience . Kind add in your css file the line below.

.threedots {
    cursor: pointer
/* ....*/
}

Happy coding.