Description

takes PR https://github.com/ghiscoding/lerna-lite/pull/168 and addresses all comments provided in the original PR

Motivation and Context

• fixed npm lockfile that got broken by original PR, I took the same approach as the pnpm lock file update to fix the npm lock file update. Both updates are now very similar and easier to read
• removed preferred-pm since I would prefer to not use any extra dependencies, and I think that also fixed the unit tests since they weren't being detected properly
• added a prettier VSCode setting (setup) and also fixed couple of places where prettier wasn't doing a good job
• add a new flag no-update-root-lock-file just in case this pnpm update causes issues, at least the user could disable it

How Has This Been Tested?

only local unit tests for now, we might need a bit more testing, need to validate with @JacobSoderblom

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [x] I have added tests to cover my changes.
• [x] All new and existing tests passed.

Describe the bug

As titled. This broke currently our release process :scream:

lerna publish --conventional-commits --create-release github --allow-branch main --yes --message="chore(release): Publish [skip ci]"

Reproduction

1. Create PNPM workspace
2. Use a dependency with workspace: protocol
3. Publish with lerna.
4. workspace: is still in the manifest.

Lerna config and logs

<!-- Please paste your `lerna.json` here -->

<!-- If you have a `lerna-debug.log` available, please paste it here -->
<!-- Otherwise, feel free to delete this <details> block -->

Environment Info

| Executable        | Version |
| ----------------- | ------- |
| `lerna --version` | v1.4.0 |
| `npm --version`   | VERSION |
| `yarn --version`  | VERSION |
| `node --version`  | VERSION |

---
OR simply run `npx lerna info` command

Used Package Manager

pnpm

Validations

• [X] Follow our Code of Conduct
• [X] Read the docs.
• [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• [X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
• [X] The provided reproduction is a minimal reproducible example of the bug.

Description

This flag would run npm install --package-lock-only or associated command depending on the package manager client defined in npmClient (npm, pnpm or yarn). It will try to use the package manager client to update the lock file instead of relying on Lerna-Lite to update the file which requires a lot more code.

Motivation and Context

in summary this simplifies a lot the process of updating the lock file and also make it a lot more reliable since we are relying solely on the client to its job with a lot less logic to implement in Lerna-Lite. Relying on the client is also future proof in case the lock file structure ever change.

How Has This Been Tested?

unit tests were added

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x] My code follows the code style of this project.
• [x] My change requires a change to the documentation.
• [x] I have updated the documentation accordingly.
• [x] I have added tests to cover my changes.
• [x] All new and existing tests passed.

Describe the bug

Hello, I try

GH_TOKEN=ghp_secret lerna version --conventional-commits --changelog-include-commits-client-login --create-release github --git-dry-run

and it generate this

? Are you sure you want to create these versions? Yes
lerna-lite verb independent wrote /home/starptech/repositories/wundergraph/wundergraph/packages/sdk/CHANGELOG.md
lerna-lite verb independent wrote /home/starptech/repositories/wundergraph/wundergraph/packages/nextjs/CHANGELOG.md
lerna-lite info dry-run> git add -- packages/sdk/package.json packages/sdk/CHANGELOG.md packages/nextjs/package.json packages/nextjs/CHANGELOG.md
lerna-lite verb git commit -F /tmp/126f273a-186a-4603-8ca0-0677638e0833/lerna-commit.txt
lerna-lite info dry-run> git commit -F /tmp/126f273a-186a-4603-8ca0-0677638e0833/lerna-commit.txt
lerna-lite verb git tag @wundergraph/[email protected] -m @wundergraph/[email protected]
lerna-lite info dry-run> git tag @wundergraph/[email protected] -m @wundergraph/[email protected]
lerna-lite verb git tag @wundergraph/[email protected] -m @wundergraph/[email protected]
lerna-lite info dry-run> git tag @wundergraph/[email protected] -m @wundergraph/[email protected]
lerna-lite info git Pushing tags...
lerna-lite info dry-run> git push --follow-tags --no-verify --atomic origin main
lerna-lite info execute Creating releases...
lerna-lite verb git config --get remote.origin.url
lerna-lite info dry-run> Create Release with repo options:  {"owner":"wundergraph","repo":"wundergraph","tag_name":"@wundergraph/[email protected]","name":"@wundergraph/[email protected]","body":"## [0.98.0](https://github.com/wundergraph/wundergraph/compare/@wundergraph/[email protected]...@wundergraph/[email protected]) (2022-08-18)\n\n\n### Features\n\n* native webhooks support ([#126](https://github.com/wundergraph/wundergraph/issues/126)) ([a0b38bd](https://github.com/wundergraph/wundergraph/commit/a0b38bd54b88198db6cc176432d577dab0931245))\n\n\n### Bug Fixes\n\n* issue with unhandled hyphens in input names ([#123](https://github.com/wundergraph/wundergraph/issues/123)) ([b01caaa](https://github.com/wundergraph/wundergraph/commit/b01caaa8c4036afbeb579dbbf14a52d82971b116))\n\n","draft":false,"prerelease":false}
lerna-lite info dry-run> Create Release with repo options:  {"owner":"wundergraph","repo":"wundergraph","tag_name":"@wundergraph/[email protected]","name":"@wundergraph/[email protected]","body":"## [0.1.1](https://github.com/wundergraph/wundergraph/compare/@wundergraph/[email protected]...@wundergraph/[email protected]) (2022-08-18)\n\n**Note:** Version bump only for package @wundergraph/nextjs\n\n\n\n","draft":false,"prerelease":false}
lerna-lite success version finished

same as without the flag

## [0.98.0](https://github.com/wundergraph/wundergraph/compare/@wundergraph/[email protected]...@wundergraph/[email protected]) (2022-08-18)

### Features

* native webhooks support ([#126](https://github.com/wundergraph/wundergraph/issues/126)) ([a0b38bd](https://github.com/wundergraph/wundergraph/commit/a0b38bd54b88198db6cc176432d577dab0931245))

### Bug Fixes

* issue with unhandled hyphens in input names ([#123](https://github.com/wundergraph/wundergraph/issues/123)) ([b01caaa](https://github.com/wundergraph/wundergraph/commit/b01caaa8c4036afbeb579dbbf14a52d82971b116))

Expectation

Should add the authors to the changelog as described in https://github.com/ghiscoding/lerna-lite/tree/main/packages/version#--changelog-include-commits-client-login-msg

Reproduction

See above.

Lerna config and logs

<!-- Please paste your `lerna.json` here -->

<!-- If you have a `lerna-debug.log` available, please paste it here -->
<!-- Otherwise, feel free to delete this <details> block -->

Environment Info

| Executable        | Version |
| ----------------- | ------- |
| `lerna --version` | 1.10.0 |
| `npm --version`   | VERSION |
| `yarn --version`  | VERSION |
| `node --version`  | VERSION |

---
OR simply run `npx lerna info` command and copy+paste the result here

Used Package Manager

pnpm

Validations

• [X] Follow our Code of Conduct
• [X] Read the docs.
• [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• [X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
• [X] The provided reproduction is a minimal reproducible example of the bug.

• supersede #362

Description

Add a new option --allow-peer-dependencies-update option on the version command which will help to update peer dependencies before publishing them. This option is opt-in and disabled by default because of what the original Lerna maintainer wrote in Lerna issue #1018

peerDependencies shouldn't be updated by lerna publish

This option is not recommended for most users, for them peerDependencies will remain untouched unless the user really wants it enabled and has more knowledge in this regard. However even when this flag is enabled, it will never mutate/update peer dependencies with semver range operator (ie >=2.0.0).

Regex used

For this implementation, we'll use this regex to identify if the peer dependency is allowed to be updated or not (regex101)

/^(workspace:)?[~^]?[\d\.]+([\-]+[\w\.\-\+]+)*$/i

Note

While at it, the code in package and package-graph related to workspace: protocol were refactored a bit to follow similar implementation as to what Lerna as recently done, even though the implementation is different at least the naming is now similar.

Motivation and Context

Provide a way to bump peer dependencies but only via a flag, this behavior will be disabled by default, this will close #333

• closes #333

The main code change for this new option is in the updateLocalDependency() method found in package.ts, a new argument allowPeerDepsUpdate was added and when enabled it will add peerDependencies into the loop of dependencies to be inspected for updates. The loop is also new in that same method, since prior to this we would only update/bump the 1st dependency found, however now if the flag is enabled, we also include (loop) the peer dependency as well so instead of updating 1 dependency (by name), we might update up to 2 of with the same name

in summary, calling lerna version --allow-peer-dependencies-update (or the equivalent lerna.json config) on this package

{
  "name": "B",
  "dependencies": {
    "A": "workspace:^1.2.0"
   },
  "peerDependencies": {
    "A": "workspace:^1.2.0"
  }
}

will bump both the dependencies and peerDependencies to ^1.3.0 on a minor bump (note again that a semver range >= will never be bumped)

How Has This Been Tested?

added a lot more unit tests to cover package.ts, package-graph, publish and version

What will be valid and update?

It will update (bump) regular semver like these

• 1.2.3
• ^1.2.3
• ^1.4.0-alpha.0
• workspace:^1.2.3

but it won't mutate/update things like

• >=1.0.0
• >=1.0.0 <2.0.0
• ^1 | ^2 | ^3

Types of changes

• [ ] Chore (change that has absolutely no effect on users)
• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x] My code follows the code style of this project.
• [x] My change requires a change to the documentation.
• [x] I have updated the documentation accordingly.
• [x] I have added tests to cover my changes.
• [x] All new and existing tests passed.

Describe the bug

Hi, lerna-lite replaced >= with ^. I'm not sure if this is correct.

Reproduction

1. Create a pnpm workspace with two packages (FOO, SDK) and FOO depending on SDK.

FOO: version 0.80.0, use the version constraint workspace:>=0.91.0 on SDK SDK: version 0.91.0

2. Make a change in SDK and commit

Calculate the next version with lerna publish prerelease --no-verify-access --conventional-commits --create-release github lerna will bump the SDK version in FOO as follow.

---    "SDK": "workspace:>=0.91.0",
+++    "SDK": "workspace:^0.91.6-next.1",

Lerna config and logs

<!-- Please paste your `lerna.json` here -->

<!-- If you have a `lerna-debug.log` available, please paste it here -->
<!-- Otherwise, feel free to delete this <details> block -->

Environment Info

| Executable        | Version |
| ----------------- | ------- |
| `lerna --version` | 1.4.0 |
| `npm --version`   | VERSION |
| `yarn --version`  | VERSION |
| `node --version`  | v16.14.2 |

---
OR simply run `npx lerna info` command

Used Package Manager

pnpm

Validations

• [X] Follow our Code of Conduct
• [X] Read the docs.
• [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• [X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
• [X] The provided reproduction is a minimal reproducible example of the bug.

Hi there

I was wondering if it would be considered to update the cli to learna-lite in a future version, as opposed to the two ws-* commands? The reasoning behind this would be for ease of development, where developers familiar with lerna could easily recognise the use of this project as lerna like commands, whereas ws-* is not familiar

I'm submitting a Feature request

Motivation / Use Case

Ease of migration and familiarity for developers

Expected Behavior

ws-roller version - > lerna-lite version etc

Other Information

Description

Update regex for extracting commit date inside the get-commits-since-last-release.ts function, the regex has an issue related to parsing time zones. When executing git log with --format="%h %aI" option to get the oldest commit details, %aI formats the author date in ISO 8601 format, then the old regex /^"?([0-9a-f]+)\s([0-9\-T\:]*)"?$/ used to extract commit hash and date. The old regex can only parse dates with a time zone offset of - hours but in my case, my time zone has an offset of + hours. Hence, the commit date was always undefined leading to all commands that call Github API with $since variable to fail with GraphqlResponseError Variable $since of type GitTimestamp! was provided invalid value.

Thank you @ghiscoding for the fantastic work 🙏.

Motivation and Context

After #272, I tried to use the --changelog-include-commits-client-login option but it always fails when calling GitHub API, after debugging turns out that the commit date was undefined because of miss-parsing of the ISO date time zones.

New Regex (regex101 editor)

/^"?([0-9a-f]+)\s([0-9\-|\+T\:]*)"?$/

should parse -+ time zones.

How Has This Been Tested?

All old tests pass and I don't know if this case needs a dedicated test.

Types of changes

• [ ] Chore (change that has absolutely no effect on users)
• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [x] I have added tests to cover my changes.
• [x] All new and existing tests passed.

Describe the bug

See CI Job The command is executed but the updated lock file was not committed https://github.com/wundergraph/wundergraph/commit/b9dea13cbaa4cf33c9d7d2af48ca71bad8723f24

Expectation

I miss the line

 git add -- packages/sdk/package.json packages/sdk/CHANGELOG.md packages/nextjs/package.json packages/nextjs/CHANGELOG.md pnpm-lock.yaml

Reproduction

No idea

Lerna config and logs

<!-- Please paste your `lerna.json` here -->

<!-- If you have a `lerna-debug.log` available, please paste it here -->
<!-- Otherwise, feel free to delete this <details> block -->

Environment Info

| Executable        | Version |
| ----------------- | ------- |
| `lerna --version` | 1.5.1 |
| `npm --version`   | VERSION |
| `yarn --version`  | VERSION |
| `node --version`  | VERSION |

---
OR simply run `npx lerna info` command and copy+paste the result here

Used Package Manager

pnpm

Validations

• [X] Follow our Code of Conduct
• [X] Read the docs.
• [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• [X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
• [X] The provided reproduction is a minimal reproducible example of the bug.

Fix #200

Description

Motivation and Context

How Has This Been Tested?

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [ ] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] I have added tests to cover my changes.
• [ ] All new and existing tests passed.

I'm submitting a Feature request

Motivation / Use Case

I would like a repo that uses pnpm workspaces to be able to use lerna-lite.

Expected Behavior

When version or publish are run in repositories that use pnpm workspaces, the commands should work.

Currently, the following error occurs:

~/elephant/web-packages -> chore/pnpm |• $
❯ pnpm lerna publish
lerna notice cli v1.0.5
lerna info versioning independent
lerna ERR! Error: Unsupported URL Type "workspace:": workspace:^0.3.1
lerna ERR!     at unsupportedURLType (/Users/theo/elephant/web-packages/node_modules/.pnpm/[email protected]/node_modules/npm-package-arg/lib/npa.js:262:15)
lerna ERR!     at fromURL (/Users/theo/elephant/web-packages/node_modules/.pnpm/[email protected]/node_modules/npm-package-arg/lib/npa.js:322:13)
lerna ERR!     at Function.resolve (/Users/theo/elephant/web-packages/node_modules/.pnpm/[email protected]/node_modules/npm-package-arg/lib/npa.js:80:12)
lerna ERR!     at /Users/theo/elephant/web-packages/node_modules/.pnpm/@[email protected]/node_modules/@lerna-lite/core/dist/package-graph/package-graph.js:53:60
lerna ERR!     at Array.forEach (<anonymous>)
lerna ERR!     at /Users/theo/elephant/web-packages/node_modules/.pnpm/@[email protected]/node_modules/@lerna-lite/core/dist/package-graph/package-graph.js:47:44
lerna ERR!     at Map.forEach (<anonymous>)
lerna ERR!     at new PackageGraph (/Users/theo/elephant/web-packages/node_modules/.pnpm/@[email protected]/node_modules/@lerna-lite/core/dist/package-graph/package-graph.js:43:14)
lerna ERR! lerna Unsupported URL Type "workspace:": workspace:^0.3.1

Other Information

• This same problem is present in the forked lerna repository https://github.com/lerna/lerna/issues/2564#issuecomment-1035392832
• I don't mind taking a crack at this myself when I can find the time 👍
• My focus is pnpm as that is my personal use-case, however this issue is present with yarn workspaces also.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• [ ] chore(deps): update all non-major dependencies (eslint-plugin-jest, jest-extended, nx, prettier)

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• [ ] chore(deps): update lee-dohm/no-response digest to 6617437

Detected dependencies

• [ ] Check this box to trigger a request for Renovate to run again on this repository

Describe the bug

Hi, I'm a bit curious about how the independent mode works. I made a preview and got the following logs:

> lerna version --conventional-commits --changelog-include-commits-client-login --create-release github --git-dry-run

lerna-lite notice cli v1.11.1
lerna-lite verb rootPath /home/starptech/repositories/wundergraph/wundergraph
lerna-lite info dry-run> git rev-parse
lerna-lite info versioning independent
lerna-lite verb project packages packages/nextjs packages/sdk packages/protobuf
lerna-lite info dry-run> git rev-list --count --all --max-count=1
lerna-lite verb isAnythingCommitted 1
lerna-lite verb currentBranch main
lerna-lite info dry-run> git show-ref --verify refs/remotes/origin/main
lerna-lite info dry-run> git remote update
lerna-lite info dry-run> git rev-list --left-right --count origin/main...main
lerna-lite verb hasTags filter for tags with '*@*' pattern
lerna-lite verb hasTags true
lerna-lite verb git-describe.sync "*@*" => "@wundergraph/[email protected]"
lerna-lite info Looking for changed packages since @wundergraph/[email protected]
lerna-lite verb filtered diff packages/nextjs/package.json
lerna-lite verb filtered diff packages/protobuf/package.json
lerna-lite verb filtered diff packages/sdk/package.json
lerna-lite verb updated @wundergraph/nextjs
lerna-lite verb updated @wundergraph/protobuf
lerna-lite verb updated @wundergraph/sdk
lerna-lite info dry-run> git describe --always --long --dirty --first-parent
lerna-lite verb getChangelogConfig using preset "conventional-changelog-conventionalcommits"
lerna-lite verb getChangelogConfig Attempting to resolve preset "conventional-changelog-conventionalcommits"
lerna-lite info getChangelogConfig Successfully resolved preset "conventional-changelog-conventionalcommits"
lerna-lite verb independent increment 0.1.4 by patch - @wundergraph/nextjs
lerna-lite verb independent increment 0.91.2 by patch - @wundergraph/protobuf
lerna-lite verb independent increment 0.98.3 by patch - @wundergraph/sdk

Changes (3 packages):
 - @wundergraph/nextjs: 0.1.4 => 0.1.5
 - @wundergraph/protobuf: 0.91.2 => 0.91.3
 - @wundergraph/sdk: 0.98.3 => 0.98.4

Check the line

lerna-lite verb git-describe.sync "*@*" => "@wundergraph/[email protected]"
lerna-lite info Looking for changed packages since @wundergraph/[email protected]

Shouldn't it be checked for each package individually? Why is @wundergraph/[email protected] the base?

Expectation

No response

Reproduction

No

Lerna config and logs

<!-- Please paste your `lerna.json` here -->

<!-- If you have a `lerna-debug.log` available, please paste it here -->
<!-- Otherwise, feel free to delete this <details> block -->

Environment Info

| Executable        | Version |
| ----------------- | ------- |
| `lerna --version` | 1.11.1 |
| `npm --version`   | VERSION |
| `yarn --version`  | VERSION |
| `node --version`  | VERSION |

---
OR simply run `npx lerna info` command and copy+paste the result here

Used Package Manager

pnpm

Validations

• [X] Follow our Code of Conduct
• [X] Read the docs.
• [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• [X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
• [X] The provided reproduction is a minimal reproducible example of the bug.