Is your feature request related to a problem? Please describe.

The transformer tests are not run in parallel

The tests start in parallel, but are run in sync

Diff:

-  describe.each(fixtureSubDirs)("%s", (subDir) => {
+  describe.each(["new-client"])("%s", (subDir) => {
     const subDirPath = join(fixtureDir, subDir);
     it.concurrent.each(getTestFileMetadata(subDirPath))(
       `transforms: %s.%s`,
       async (filePrefix, fileExtension) => {
+        const startDate = new Date();
+        console.log(`${filePrefix} start: `, startDate.toTimeString());
+
         const { input, outputCode } = await getTestMetadata(subDirPath, filePrefix, fileExtension);
         runInlineTest(transformer, null, input, outputCode);
+
+        const endDate = new Date();
+        console.log(`${filePrefix} end: ${endDate.toTimeString()}`);
+        console.log(`${filePrefix} test run time: ${endDate.getTime() - startDate.getTime()}ms`);
       }
     );

Output:

    global-import start:  14:25:39 GMT-0800 (Pacific Standard Time)
    global-require start:  14:25:39 GMT-0800 (Pacific Standard Time)
    service-import-deep start:  14:25:39 GMT-0800 (Pacific Standard Time)
    service-import start:  14:25:39 GMT-0800 (Pacific Standard Time)
    service-require-deep start:  14:25:39 GMT-0800 (Pacific Standard Time)

    service-import end: 14:25:51 GMT-0800 (Pacific Standard Time)
    service-import test run time: 11781ms

    service-require start:  14:25:51 GMT-0800 (Pacific Standard Time)

    global-require end: 14:26:04 GMT-0800 (Pacific Standard Time)
    global-require test run time: 24973ms

    service-require-deep end: 14:26:20 GMT-0800 (Pacific Standard Time)
    service-require-deep test run time: 40440ms

    global-import end: 14:26:30 GMT-0800 (Pacific Standard Time)
    global-import test run time: 50777ms

    service-import-deep end: 14:26:41 GMT-0800 (Pacific Standard Time)
    service-import-deep test run time: 62212ms

    service-require end: 14:27:00 GMT-0800 (Pacific Standard Time)
    service-require test run time: 68779ms

This leads to CI taking time. For example, the test step takes 3m https://github.com/awslabs/aws-sdk-js-codemod/actions/runs/3803141886/jobs/6469293363

Describe the solution you'd like

Experiment with Jest code or configuration to run tests in parallel

Describe alternatives you've considered

N/A

Additional Context

$ yarn dlx -q envinfo --preset jest

  System:
    OS: macOS 12.1
    CPU: (8) arm64 Apple M1 Pro
  Binaries:
    Node: 18.12.1 - /private/var/folders/42/54jl1_3x4hz06cf7bc_kzd4h0000gn/T/xfs-6daa84fb/node
    Yarn: 3.3.1 - /private/var/folders/42/54jl1_3x4hz06cf7bc_kzd4h0000gn/T/xfs-6daa84fb/yarn
    npm: 8.19.2 - ~/Library/Caches/fnm_multishells/57062_1672199177403/bin/npm
  npmPackages:
    jest: ^29.3.1 => 29.3.1

Is your feature request related to a problem? Please describe.

During benchmarking, the test global-import-new-clients and service-import took the most time, i.e. 16s. Rest of the tests take ~100ms

Tested by adding logs:

// src/transforms/v2-to-v3/transformer.spec.ts

it.each(testFiles)(`transforms correctly using "%s" data`, async (filePrefix, fileExtension) => {
  const testStart = Date.now();
  console.log("test start:", filePrefix, testStart);

  // ...

  const testEnd = Date.now();
  console.log("test end: ", filePrefix, testEnd);
  console.log("test duration: ", filePrefix, testEnd - testStart);
}

Output:

test duration:  global-import-new-clients 15979
...
test duration:  service-import 18148

Describe the solution you'd like

Check if the issue is with efficiency of source code, which can be improved. If not, identify if tests can be run faster.

Describe alternatives you've considered

N/A

Self-service

• [ ] I'd be willing to implement a fix

Describe the bug

The v2-to-v3 transform removes top level comment

Template name

v2-to-v3

Input code

// Top level comment
import AWS from "aws-sdk";

// Create client
const client = new AWS.DynamoDB({ region: "us-west-2" });

// Make listTables call
client.listTables({}, (err, data) => {
  if (err) console.log(err, err.stack);
  else console.log(data);
});

Observed failure

No failure, but the top level comment is removed

import { DynamoDB } from "@aws-sdk/client-dynamodb";

// Create client
const client = new DynamoDB({ region: "us-west-2" });

// Make listTables call
client.listTables({}, (err, data) => {
  if (err) console.log(err, err.stack);
  else console.log(data);
});

Expected output

// Top level comment
import { DynamoDB } from "@aws-sdk/client-dynamodb";

// Create client
const client = new DynamoDB({ region: "us-west-2" });

// Make listTables call
client.listTables({}, (err, data) => {
  if (err) console.log(err, err.stack);
  else console.log(data);
});

### Environment

```shell
aws-sdk-js-codemod: 0.6.4

jscodeshift: 0.14.0
 - babel: 7.20.5
 - babylon: 7.20.5
 - flow: 0.196.2
 - recast: 0.21.5

Additional context

No response

Issue

Refs: https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#force-deleting-cache-entries

Description

Cleans up caches when pull request is closed

Testing

Will be done after PR is merged

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Issue

Fixes: https://github.com/awslabs/aws-sdk-js-codemod/issues/263

Description

Deep import search only for available clients in getV2ClientNamesRecord

Testing

CI

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Issue

Documenting performance numbers for https://github.com/awslabs/aws-sdk-js-codemod/issues/251

Description

Log time taken by source.find operation in getV2ClientNamesRecord

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Issue

Refs: https://github.com/awslabs/aws-sdk-js-codemod/issues/251#issuecomment-1367689802

Description

Reduce number of calls to source API in getV2ClientNamesRecord

Testing

CI

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Issue

Attempts to fix https://github.com/awslabs/aws-sdk-js-codemod/issues/239

Description

What does this implement/fix? Explain your changes.

Testing

How was this change tested?

Additional context

Add any other context about the PR here.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Self-service

• [X] I'd be willing to implement this feature

Input code

Input:

import DynamoDB from "aws-sdk/clients/dynamodb";

const ddbClient = new DynamoDB({ region: "us-west-2" });
const listTablesInput: DynamoDB.ListTablesInput = { Limit: 10 };
const listTablesOutput: DynamoDB.ListTablesOutput = await ddbClient
  .listTables(listTablesInput)
  .promise();

Existing output:

import { DynamoDB, ListTablesCommandInput, ListTablesCommandOutput } from "@aws-sdk/client-dynamodb";

const ddbClient = new DynamoDB({ region: "us-west-2" });
const listTablesInput: ListTablesCommandInput = { Limit: 10 };
const listTablesOutput: ListTablesCommandOutput = await ddbClient
  .listTables(listTablesInput);

Expected Output

import * as DynamoDB from "@aws-sdk/client-dynamodb";

const ddbClient = new DynamoDB.DynamoDB({ region: "us-west-2" });
const listTablesInput: DynamoDB.ListTablesCommandInput = { Limit: 10 };
const listTablesOutput: DynamoDB.ListTablesCommandOutput = await ddbClient.listTables(
  listTablesInput
);

Additional context

This solution not only minimizes imports which can conflict with other variables defined in the code, but also adds support for nested type definitions requested in https://github.com/awslabs/aws-sdk-js-codemod/issues/225

Self-service

• [ ] I'd be willing to implement this feature

Input code

const ACM = require("aws-sdk/clients/acm");

const client = new ACM();

Expected Output

Expected output

const { ACM } = require("@aws-sdk/client-acm");

const client = new ACM();

Observed output

const {
  ACM
} = require("@aws-sdk/client-acm");

const client = new ACM();

Additional context

No response

Issue

Follow-up to https://github.com/awslabs/aws-sdk-js-codemod/pull/174

Description

Computer branch name from pull_request number

Testing

Will be done after PR is merged

Additional context

Docs: https://docs.github.com/developers/webhooks-and-events/webhooks/webhook-events-and-payloads?actionType=closed#pull_request

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Issue

Fixes https://github.com/awslabs/aws-sdk-js-codemod/issues/243

Description

What does this implement/fix? Explain your changes.

Testing

How was this change tested?

Additional context

Add any other context about the PR here.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Issue

Refs: https://github.com/awslabs/aws-sdk-js-codemod/issues/225

Description

What does this implement/fix? Explain your changes.

Testing

How was this change tested?

Additional context

Add any other context about the PR here.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Self-service

• [X] I'd be willing to implement this feature

Input code

import AWS = require("aws-sdk");

const client = new AWS.DynamoDB({ region: "us-west-2" });

Expected Output

import { DynamoDB } = require("@aws-sdk/client-dynamodb");

const client = new DynamoDB({ region: "us-west-2" });

Additional context

This missing feature was noticed in https://github.com/awslabs/aws-sdk-js-codemod/issues/242

Issue

Fixes: https://github.com/awslabs/aws-sdk-js-codemod/issues/51

Description

Add initial support for DynamoDB DocumentClient transformation

Testing

CI

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Self-service

• [ ] I'd be willing to implement this feature

Test Comand

npx aws-sdk-js-codemod --dry --print -t v2-to-v3 example.ts

Input code

import { S3 } from "aws-sdk";
const testTags: S3.Tag[] = [{ Key: "abc", Value: "value" }];

Current Output

Results:
0 errors
1 unmodified
0 skipped
0 ok

Expected Output

import { Tag } from "@aws-sdk/client-s3";
const testTags: Tag[] = [{ Key: "abc", Value: "value" }];

Additional context

Would it be possible to migrate the import of Typescript type definitions from v2 to v3? My project has a global store that uses the AWS SDK types to store objects and tags. During migration, it'll be great to also have those types updated to their v3 references.

Describe the bug

npx does not use the latest version of codemod

Steps to reproduce

To reproduce, you need to have an older version of aws-sdk-js-codemod installed

$ npm view aws-sdk-js-codemod version 
0.6.3

$ npx aws-sdk-js-codemod --version
aws-sdk-js-codemod: 0.6.1
...

Run the following commands:

$ npx aws-sdk-js-codemod@latest --version

$ npx aws-sdk-js-codemod --version

Observed behavior

When latest is explicitly passed, it uses the latest version. But it does not override the previously installed version

$ npx aws-sdk-js-codemod@latest --version
Need to install the following packages:
  [email protected]
Ok to proceed? (y) y
aws-sdk-js-codemod: 0.6.3
...

$ npx aws-sdk-js-codemod --version 
aws-sdk-js-codemod: 0.6.1
...

Expected behavior

Default documentation should update how to use the latest version.

The current usage recommends npx aws-sdk-js-codemod which will use the catched version: https://github.com/awslabs/aws-sdk-js-codemod#usage