Hey so I have been trying ng-extract-i18n-merge to see wether it can replace the old @ngx-i18nsupport/tooling (using 9 locales), but I ran into some problems.

Installation & Configuration went fine, but when I first executed it I got the following results:

angular.json

package.json "i18n-extract-merge": "ng build && ng run xxx:extract-i18n-merge",

1)Already translated texts in state=translated were overritten 2)Order / Structure of .xlf files was completely modified

Example: As you can see the english word "Sender" was already translated to the german word "Absender" and it went from line 1388 to line 11

Is there any way to keep the existing translations by modifying the state attribute or via configuration?

3)FuzzySearch = true resulted in many mismatches mixing source & target of multiple texts

Hey there,

first of all thanks for making this script, it really helped me to migrate from xliffmerge.

I've discovered a little bug that I'd like to report when using "includeContext": true,. If you change the location of a "i18n" tag or add a new one with the same value than an existing one it doesn't seem to merge the updated to the <note category="location"> tags correctly.

Here's a scenario to describe the issue better:

1. Move a row with "i18n" tag in an html file
2. Run the ng-extract-18n-merge script
3. Changes in messages.xlf: - <note category="location">src/app/app.component.html:31</note> + <note category="location">src/app/app.component.html:32</note>
4. Changes in messages.de.xlf: none

It should also reflect the changes in messages.de.xlf, right?

I've looked at the source code but wasn't able to fix it with a pull request yet.

Is there a way to show additional logging during the merge? I'm running this program on my existing translation base (+/- 3500 translations; merged before with xliffmerge, moved to this due to the console error) and it takes >10 min and is still not finished. I'd like to know if it crashed on something or if it is still trying its best.

Hi, thank you for providing a new package!

I am still using this to translate my strings. However, it seems that this tool does not pickup new or changed translations since I switched to ng-extract-i18n-merge.

What do you use for actual translating?

regards,

Philipp

Looks like extract-i18n-merge command trims spaces, but extract-i18n don't. I have cases when i don't need to trim them.

<span
  class="link-ghost"
  i18n="Phone Verification"
> Change</span>

I have a space before Change. But as a result i have:

<trans-unit id="ba3ab8408e0985aaa20a3c83f77a8bc336a96ae4" datatype="html">
  <source>Change</source>
  <context-group purpose="location">
    ...
  </context-group>
  <note priority="1" from="description">Phone Verification</note>
</trans-unit>

May be there is any extra config except collapseWhitespace? "ng-extract-i18n-merge": "^1.4.0",

Describe the bug When adding new strings for translations with the setting "newTranslationTargetsBlank": "omit", I get the following error Cannot read property 'attr' of undefined

Setup/Configuration

"extract-i18n-merge": {
          "builder": "ng-extract-i18n-merge:ng-extract-i18n-merge",
          "options": {
            "browserTarget": "digital-intake:build",
            "format": "xlf",
            "includeContext": false,
            "newTranslationTargetsBlank": "omit",
            "outputPath": "apps/digital-intake/src/locale",
            "sourceLanguageTargetFile": "messages.en.xlf",
            "targetFiles": ["messages.en.xlf", "messages.es.xlf"]
          }
        },

If a translate unit doesn't exist this fails

Expected behavior I expect the new translations to merge without the target element

Screenshots If applicable, add screenshots to help explain your problem.

Version (please complete the following information):

• Angular: 13.0.4
• OS: Mac
• nodejs: 14.17.0
• ng-extract-i18n-merge version: 2.0.0 - 2.1.2

Additional context My translator has requested that I proved the new strings without the target

Is your feature request related to a problem? Please describe. Setting "includeContext": false, to false removes the context from the Angular generated file

Describe the solution you'd like Merge should not touch the Angular generated file

Describe alternatives you've considered

Additional context I want to remove the location context from the merged files but leave it in the angular generated file

Describe the bug I am not sure if it's a bug as I am not sure I fully know if this is intended behaviour or not. I get a lot of warnings like this:

Where some of the lines look like that:

<button class="col-4 btn w-100 btn-primary block" type="submit" (click)="onLogin()" i18n="Login|Auth@@Login">
    Login
</button>

This causes the translator to pick the string up as " Login " rather than "Login". Funny enough, the translation units seem to look "as expected": <source>Login</source>

Setup/Configuration

"extract-i18n": {
          "builder": "ng-extract-i18n-merge:ng-extract-i18n-merge",
          "options": {
            "browserTarget": "sportsense-tms:build",
            "format": "xlf",
            "collapseWhitespace": true,
            "trim": true,
            "includeContext": true,
            "outputPath": "src/locale",
            "targetFiles": [
              "messages.en.xlf",
              "messages.de.xlf"
            ]
          }
        }

and some translations like:

  <button class="col-4 btn w-100 btn-primary block" type="submit" (click)="onLogin()" i18n="Login|Auth@@Login">
    Login
  </button>

and

<button class="btn btn-primary" (click)="onLogin()" id="login" i18n="Login|ResetPassword@@Login">Login</button>

Expected behavior No warnings

Version (please complete the following information):

• Angular: 13
• ng-extract-i18n-merge version: 2.1.2

Additional context angular issue

Hi, I faced issue if destination file is not empty. "@angular/core": "14.0.2", "ng-extract-i18n-merge": "^2.0.1",

https://www.screencast.com/t/Wn8dB1QxvVP2

During a faulty merge in our source versioning system, duplicate ID's occurred in the messages files for one language. This condition was not detected for a long time and led to a long search for causes on different levels before the problem was found in duplicate message IDs.

I know the angular property "i18nDuplicateTranslation" but this doesn't seem to give a warning or error message here either.

Would it be possible to integrate a check for duplicate ID's?

First. Thank you for this plugin!!!

I think I found a lil bug. I had the same text to translate in multiple components and noticed that it was only translated in one of the components. It seems angular uses context-groups to translate multiple components. I used "includeContext": true to fix this but found the following even without it.

For example this is the original messages.xlf:

<trans-unit id="1547876271716599756" datatype="html">
        <source>Impressum</source>
        <context-group purpose="location">
          <context context-type="sourcefile">src/app/app-routing.module.ts</context>
          <context context-type="linenumber">12</context>
        </context-group>
        <context-group purpose="location">
          <context context-type="sourcefile">src/app/app.component.html</context>
          <context context-type="linenumber">4</context>
        </context-group>
      </trans-unit>

and this is what the plugin generates:

<trans-unit id="1547876271716599756" datatype="html">
        <context-group purpose="location">
          <context context-type="sourcefile">src/app/app-routing.module.ts</context>
          <context context-type="linenumber">12</context>
        </context-group>
        <source>Impressum</source>
        <target state="translated">Imprint</target>
      </trans-unit>

I would also recommend to set "includeContext": true as default in the plugin if I did not miss anything here.

Thank you!

I intend to maintain this library over the coming years.

Since I have other things to do as well, this can only be done on a "best effort" basis. This is probably enough to keep everything up to date. To shorten response times and consistently provide fixes/updates in a timely manner, I'd like to invite other contributors. This should sustain the development.

I'm not totally sure about a meaningful "process", but I'd like to have some contributions before adding a contributor to readme and giving repository rights.

Please comment if you are interested or have other/further ideas! :)

Hello,

Could it be possible to support Nx by at least be able to handle both angular.json and workspace.json ? I'm using a workspace.json file instead of angular.json and target extract-i18n-merge is not added when installing ng-extract-i18n-merge package, so I can't use that command.

yarn ng add ng-extract-i18n-merge

produces

 NX   Cannot find project 'ng-extract-i18n-merge'

and

yarn run [PROJECT_ID]:extract-i18n-merge
yarn nx run [PROJECT_ID]:extract-i18n-merge

produces

NX   Cannot find target 'extract-i18n-merge' for project [PROJECT_ID]

Thanks