@guillaumepotier while testing #105 on staging, another form we use Garlic on gets emptied / destroyed before submit. As a result of that no data is sent, and the form validation does not pass as the CQRF token also is cleared.

Narrowed this down to comparing 1.2.4 to 1.3.0, on which the bug occurs (so is not specific to PR #105 ): https://github.com/guillaumepotier/Garlic.js/compare/1.2.4...master

The form initialization used to be like this:

$(function() {
    $('#orderInfoForm').garlic({
        excluded: '[data-persist="false"]'
    });
});

and restoring the form to a working situation was possible by:

$(function() {
    $('#orderInfoForm').garlic();
});

We now see that the form is emptied, but that the form submit works. I think the form should not be emptied, but only the storage should be emptied right?

This issue is changed already Read the discussion yourself :)

=== Original issue content Sometimes when i refresh a form I got some strange hint "This is your saved data. Click here to see default one"

Can I set option to disable it or choose other behavior? (I just want the hint gone) It's screwing the layout:(

I will disable it for the moment :S But thanks for the rest of the work!

What do you think?

It caught me out that those did not work out of the box...

Want me to add the rest of the html5 field types? number and tell change the on screen keyboard on a mobile so they are needed for mobile stuff.

Not sure if you want to support select elements, but this seemed like a missing feature to me, since it' felt weird to return the page and have it almost resume the previous state.

Also binding to some additional events instead of just keyUp, since a paste event, for example, can change the content without touching a key.

Video @ https://docs.google.com/open?id=0B0emwt_fpZvddFNqQWJ5WVNfZVE

SO issue: http://stackoverflow.com/questions/13489224/how-to-implement-node-localname-equivalent-for-ie8

This allows us to add a timestamp to the data, so we can locally configure whether we want to use outdated values.

Example

$('#garlicForm').garlic({
        # ...
        preRetrieve: function(elem, currentValue, restoredValue) {
            var cacheValue = JSON.parse(restoredValue);
            if (cacheValue.timestamp < getLastDateModified()) {
                return false;
            }
            return cacheValue.content;
        },
        prePersist: function(elem, storedValue) {
            var timestamp = getCurrentTimestamp();
            return parseCacheItem(timestamp, storedValue);
        }
    });

Fixes #93

I fixed a bug where if you had a field with data-storage="false" the rest of the form would also be data-storage="false" from that point onward.

I have not created the .min.js file sorry. What are you using todo that, I keep getting a larger file.

I have a scenario where after user fill out a form FBSDK call is made to check if the user is authenticated. If not, FB authenticates himself and gets redirected back to the form but by then the information is lost.

I used data-persist="garlic" on the form but ti didn't work. Am I missing something?

Hi Guillaume,

I faced an need to execute own functions after swap event. So I suggest to implement an option for such handler.

In particular is essential for widget overridden by some js wrapper. F.e CKeditor.

When submitting the form, data in local storage is always cleared, regardless of whether the form submit goes ahead (i.e. even if the form fails validation).

So, in a form using both Garlic.js and Parsley.js, if you fill in all fields and hit submit (but with an invalid entry), then the data is cleared. I would expect (hope) that data is only cleared once the form submits and validates, otherwise data is cleared too early.

add support for select[multiple] instead of silently failing. every value will be converted to JSON before it is saved to local storage to support the array value of select[multiple].

In the past I used Garlic.js with great success, but now that I use webpack to compile my assets, I get this error in the browser console:

garlic.min.js:145 Uncaught TypeError: Cannot read property 'fn' of undefined
    at garlic.min.js:145
    at Object../node_modules/garlicjs/dist/garlic.min.js (garlic.min.js:197)
    at __webpack_require__ (bootstrap:19)
    at Module.<anonymous> (application.js:17)
    at Module../app/javascript/packs/application.js (application.js:32)
    at __webpack_require__ (bootstrap:19)
    at bootstrap:83
    at bootstrap:83
(anonymous) @ garlic.min.js:145
./node_modules/garlicjs/dist/garlic.min.js @ garlic.min.js:197
__webpack_require__ @ bootstrap:19
(anonymous) @ application.js:17
./app/javascript/packs/application.js @ application.js:32
__webpack_require__ @ bootstrap:19
(anonymous) @ bootstrap:83
(anonymous) @ bootstrap:83

My entry point contains this:

require('garlicjs')

And it does not matter whether I change this to:

import 'garlicjs'

I must admit that I am not very good at all at JavaScript, so I would not be surprised if the solution is really simple?

There is a problem with the input field with the phone type. I use for this field - jquery.maskedinput.js Code for this field: $('body').on('focus', 'input[name='phone']', function(){ $(this).mask('+7 (999) 999-99-99'); }); Everything is fine here. But Garlic.js doesn't work correctly. The value from this field is written without the last digit: "+7 (111) 111-11-1_" Сan you help me with this?

Main Page has a number of tab, after 3-4 tab switchings when I click on the form page and write in TinyMCE editor and click on save the data is not sent to the controller.

I want to export and save all form data into a single json file and then place it back into the form fields if the users loads the app (online test) on a different device.

Is there an API within garlic to get the entire blob of data and save it remotely to a database like Firebase?