Seems like can't handle wasm I guess. Can I use esbuild plugin?

https://github.com/SettingDust/esm-loader-parse-error There isn't "type": "module" in @minify-html/wasm package.json. So I added

Error: Parse error @:1:285
    at yt (E:\javascript\esm-loader-parse-error\node_modules\@esbuild-kit\core-utils\dist\index.js:9:7926)
    at oA (E:\javascript\esm-loader-parse-error\node_modules\@esbuild-kit\core-utils\dist\index.js:14:66)
    at dt (E:\javascript\esm-loader-parse-error\node_modules\@esbuild-kit\core-utils\dist\index.js:22:85)
    at H (file:///E:/javascript/esm-loader-parse-error/node_modules/@esbuild-kit/esm-loader/dist/index.js:1:2969)
    at async nextLoad (node:internal/modules/esm/loader:163:22)
    at async ESMLoader.load (node:internal/modules/esm/loader:605:20)
    at async ESMLoader.moduleProvider (node:internal/modules/esm/loader:457:11) {
  idx: 284
}

Full log: https://pastes.dev/t9RjNTub7P

import('./content-extractor') is failed. It's fine after add /index.

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/E:/javascript/article-extractor/src/content-extractor' imported from E:\javascript\article-extractor\src\default-extractors.ts

Reproduction: https://github.com/sxzz/esbuild-esm-loader-issue

src/
├── index.ts
├── utils        # this is a directory
└── utils.ts

node --loader @esbuild-kit/esm-loader src/index.ts

Error [ERR_UNSUPPORTED_DIR_IMPORT]: Directory import '/path/esbuild-esm-loader-issue/src/utils' is not supported resolving ES modules imported from /path/esbuild-esm-loader-issue/src/index.ts
    at __node_internal_captureLargerStackTrace (node:internal/errors:465:5)
    at new NodeError (node:internal/errors:372:5)
    at finalizeResolution (node:internal/modules/esm/resolve:433:17)
    at moduleResolve (node:internal/modules/esm/resolve:1009:10)
    at defaultResolve (node:internal/modules/esm/resolve:1218:11)
    at i (file:///path/esbuild-esm-loader-issue/node_modules/.pnpm/@[email protected]/node_modules/@esbuild-kit/esm-loader/dist/index.js:87:17)
    at ESMLoader.resolve (node:internal/modules/esm/loader:580:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:294:18)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:80:40)
    at link (node:internal/modules/esm/module_job:78:36) {
  code: 'ERR_UNSUPPORTED_DIR_IMPORT',
  url: 'file:///path/esbuild-esm-loader-issue/src/utils'
}

If rename or remove src/utils, it works.

IMHO, the problem caused by here. https://github.com/esbuild-kit/esm-loader/blob/0d64195031bb599034be6c2d29427efd4d9d6334/src/loaders.ts#L79-L81

This will resolve the error cannot process paths specified at compilerOptions.paths in tsconfig.json

This patch was created to fix sudden errors from esno::pull#24

I have no clue what's happening 😐 I use this package as a --loader argument to node when running my @avajs tests.

Everything is working fine when executed locally, GitHub actions throws this at me, where this package seems to have problems resolving local pnpm workspace dependencies?

(https://github.com/wilsonjs/wilson2/runs/7886347702?check_suite_focus=true)

Might be similar to #9, which seems fixed though.

@esbuild-kit/esm-loader is configured for @avajs tests here: https://github.com/wilsonjs/wilson2/blob/f4bcf26c8279c01198096204ba766b7b416fa11f/packages/utils/ava.config.js#L9

Hello!

I'm absolutely loving TSX, the dev experience is 💯

I started getting this error recently, I believe it is since the recent support for paths in tsconfig.

Error: Non-relative paths are not allowed when 'baseUrl' is not set. Did you forget a leading './'?
    at file:///Users/jameshomer/Projects/Rosewood/node_modules/.pnpm/[email protected]/node_modules/get-tsconfig/dist/index.mjs:3:7227
    at Array.map (<anonymous>)
    at file:///Users/jameshomer/Projects/Rosewood/node_modules/.pnpm/[email protected]/node_modules/get-tsconfig/dist/index.mjs:3:7105
    at Array.map (<anonymous>)
    at se (file:///Users/jameshomer/Projects/Rosewood/node_modules/.pnpm/[email protected]/node_modules/get-tsconfig/dist/index.mjs:3:7002)
    at ce (file:///Users/jameshomer/Projects/Rosewood/node_modules/.pnpm/[email protected]/node_modules/get-tsconfig/dist/index.mjs:3:7533)
    at file:///Users/jameshomer/Projects/Rosewood/node_modules/.pnpm/@[email protected]/node_modules/@esbuild-kit/esm-loader/dist/index.js:1:338
    at ModuleJob.run (node:internal/modules/esm/module_job:198:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:385:24)

Here is tsonfig.json

{
  "extends": "./.svelte-kit/tsconfig.json",
  "compilerOptions": {
    "allowJs": true,
    "checkJs": true,
    "esModuleInterop": true,
    "forceConsistentCasingInFileNames": true,
    "resolveJsonModule": true,
    "skipLibCheck": true,
    "sourceMap": true,
    "strict": true
  }
}

And .svelte-kit/tsconfig.json

{
	"compilerOptions": {
		"baseUrl": "..",
		"paths": {
			"$lib": [
				"src/lib"
			],
			"$lib/*": [
				"src/lib/*"
			]
		},
		"rootDirs": [
			"..",
			"./types"
		],
		"importsNotUsedAsValues": "error",
		"isolatedModules": true,
		"preserveValueImports": true,
		"lib": [
			"esnext",
			"DOM"
		],
		"moduleResolution": "node",
		"module": "esnext",
		"target": "esnext"
	},
	"include": [
		"../src/**/*.js",
		"../src/**/*.ts",
		"../src/**/*.svelte"
	],
	"exclude": [
		"../node_modules/**",
		"./**"
	]
}

I was able to fix the issue by manually adding baseUrl to my root tsconfig.json.

It seems like perhaps the extends feature is supported for paths but not baseUrl, maybe this is relevant to get-tsconfig?

Furthermore, after I added baseUrl which fixed this isuue I then had to add .js onto a couple of relative module paths - not a big deal but I thought this loader was supposed to support this automatically. ie. lodash/orderBy -> lodash/orderBy.js.

Thanks!

I'm using this loader in order to run .tsx files in Mocha, but I noticed when attaching a debugger that the scripts were minified. It'd be nice to be able to configure the esbuild minification option to improve debugging.

So, if I use commander with my TypeScript code and try to run it using tsx - it doesn't work. commander is a very popular npm package.

Here are steps to reproduce:

nvm use 16
npm init -y
npm add commander
echo "import { program } from 'commander';" > index.mjs
npx tsx index.mjs

I get this:

SyntaxError: The requested module './index.js' does not provide an export named 'default'
    at ModuleJob._instantiate (node:internal/modules/esm/module_job:128:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:194:5)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:385:24)
    at async loadESM (node:internal/process/esm_loader:88:5)
    at async handleMainPromise (node:internal/modules/run_main:61:12)

However, using just pure node ... works. Setting "type": "module" and using .js extension has same effect.

The now deprecated https://github.com/antfu/esbuild-node-loader works fine with above steps.

For now, only JavaScript via 'data:text/javascript;base64,... is supported.

Can add text/typescript or (text/ts? text/tsx?) support later if the use-case arises.

Summary

This PR adds support for ESBK_TSCONFIG_NAME=tsconfig.custom.json and passes it down to get-tsconfig.

(This will be used for the upcoming tsx --tsconfig arg)

Yarn has an alternative modules layout system it calls Plug'n'Play.

For this to work in ESM mode, it uses a loader. However, node can only load one loader. In this case, first the pnp loader must be called to obtain the module source and then the esbuild loader.

There's node-loader-core which allows chaining loaders, but I wonder if there would be a more direct way possible?

There's an official esbuild plugin to make esbuild use pnp. Maybe that could be used?

Hello,

I'm trying to use this loader together with Jest, but are running into some problems. It seems like using this loader causes extra messages to be emitted when spawning a child process using child_process.fork.

Here is a minimal reproduction:

package.json

{
  "type":"module",
  "dependencies": {
    "@esbuild-kit/esm-loader":"^2.5.0"
  }
}

parent.js

import child_process from 'node:child_process'

const child = child_process.fork('./child.js')

child.on('message', (msg) => {
  console.log(msg)
})

child.js

process.send({ hello: 'world' })

Here is the output when running with just regular Node.js

$  node ./parent.js 
{ hello: 'world' }

And here is the output with the loader:

$ node --loader @esbuild-kit/esm-loader ./parent.js
(node:74148) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:74149) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
{ type: 'dependency', path: 'file:///private/tmp/hjdkas/child.js' }
{ hello: 'world' }

Notice the extra { type: 'dependency', path: 'file:///private/tmp/hjdkas/child.js' } line

hello.mts:

const hello = 'hello';
export default hello;

static.mjs:

import hello from './hello.mjs';
console.log(hello);

Execute

node --loader @esbuild-kit/esm-loader static.mjs

Error

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/mshima/git/test/hello.mjs' imported from /Users/mshima/git/test/static.mjs

This is useful for allowJs option.

Description

In windows, Using dynamic import with absolute path cause ERR_UNSUPPORTED_ESM_URL_SCHEME error

Reproduction

1. create a.ts file following

import path from "path";

const abs_path = path.resolve('./b.ts', );  // absolute path
import(abs_path)

2. run node --loader @esbuild-kit/esm-loader a.ts

extra

tsx has same error.