It is very important, because a lot of users will use source maps from Sass/Stylus. And if Rework will destroy this map data, if will be bad feature :(.

As Discussed in Styl #21, I updated the at2x plugin to require hi-res in the value to activate. This lets authors be more selective on its use, and makes sure that people are consciously accepting the consequences of using the plugin on specific images.

Please let me know if you want anything else tweaked.

I will be happy to implement this if you want, just need some pointers

this

::placeholder {
  color: #aaa
}

should eql

::-webkit-input-placeholder,
::-moz-placeholder,
::-ms-input-placeholder,
::-o-placeholder {
  color: #aaa
}

When I proccess

body {
    transition: all 1s ease-out;
}

or

body { transition: all 1s ease-out }

Rework will remove all my formatation and use own styles (without \n at end file):

body {
  transition: all 1s ease-out
}

It's not critical, but good postprocessor will change only that, you need.

specifically:

• Rework#vendors()
• rework.prefix()
• rework.prefixValue()
• rework.keyframes()

i don't think most people use these and instead use autoprefixer. the only module i've seen that actually uses this is styl, but i think that's only because of @visionmedia's refusal to use anything written in coffee script. these modules won't be deleted, just moved to its own module not included with rework.

arguments for removal:

• people use autoprefixer anyways
• much less maintenance on rework
• closes #78 #73 #70
• vendor prefixes are going away in favor of feature flags, so vendor prefix support is short-term thinking
• manual vendor prefixing is a pain in the ass

arguments against removal: you tell me

aye or nay?

Using placeholder extension leaves an empty selector in the output. An example of this can be seen in the test file: https://github.com/visionmedia/rework/blob/master/test/fixtures/extend.nested.placeholder.out.css

Expected result seems like it would be either to insert background: black; or to remove the empty selector if the generated extended selectors cover that case in the cascade.

Steps to reproduce

1. Create a placeholder selector:

   %dark-button {
       background: black;
   }
   
   .button {
       extend: %dark-button;
   }
   

2. Run rework use extend

3. Compare output

Expected result

.button {
    background: black;
}

Actual result

.button {
    background: black;
}

.button {

}

attempt to address https://github.com/visionmedia/rework/issues/6

i definitely want to figure out how to solve this problem, because it will make Myth much nicer. open to different ideas though. it could be moved out into a separate helper (although visit is just added in core again so dunno if thats that useful?)

Variables syntax in CSS is totally mind fucked. We need special :root section, we use different var-NAME in declaration and just var(NAME) in usage.

If Rework’s vars isn’t spec equalent, maybe we should use normal syntax from Stylus or Sass (I prefer last one, because it is very easy to find variable usage in code and we can’t rewrite systems terms like red = blue).

I propose inlining source maps as a base64 encoded data uris — that would provide excellent dev experience and doesn't require to serve source maps to browser separately.

I think we should remove all the plugins from core. Follow the same philosophy of node.js itself and make them separate. This would prevent people from opening lots of pull requests asking for core status (e.g. #32 which does this at the moment). We could then create a simple wiki page like we did with component to list them.

For the command line interface I'd suggest a simple plugin technique where people can list the modules they have installed that supply 'rework' plugins.

Usage then becomes:

Usage: rework <plugins> [options]

Options:

  -h, --help            output usage information
  -V, --version         output the version number
  -v, --vendors <list>  specify list of vendors

e.g.

$ rework ease,vars,extend -v webkit,moz < my.css > my.reworked.css

We could have rework automatically attempt require(plugin) and then if that fails it could attempt require('rework-' + plugin)

This would vastly reduce the size of core and hopefully lead to it being pretty much locked stability once we've sorted how to handle async transformations and syntax transformations.

Hi,

Created an @import disk read plugin (#24). It just goes in a depth first search and merges the css ast into current one. Not sure if it's the way you'd want to implement though. Feels kinda ugly.

Not works if css contains inline comments like below. Throwing error

background: #aaaaaa/{bgColorOverlay}/ url(images/ui-bg_flat_0_aaaaaa_40x100.png)/{bgImgUrlOverlay}/ 50%/{bgOverlayXPos}/ 50%/{bgOverlayYPos}/ repeat-x/{bgOverlayRepeat}/;

rework not supporting nested rules is very limiting. In my case I can't use the css-whitespace parser beforehand because my CSS depends on certain rework plugins to become valid CSS. So css-whitespace fails on it for not understanding the rework pieces and rework fails for not understanding the nesting :( Shouldn't this be an option built into rework?

Dupe of #2 but I got an actual API proposition

What about this

// sync
rework(css).use(plugin).toString()

// async; promise-based
rework(css)
  .then(function(object) {
    return plugin(object);
  })
  .then(function(object) {
    return object.toString();
  })

// or similar

@necolas