things to do:

• [x] folder support
  • [x] find where the folder info is stored in EWRAM
  • [x] add chip data and icons
  • [x] expose chip info via getFolderEditor
• [x] navicust support
  • [x] get navicust cata
  • [x] find where navicust data is stored in EWRAM
  • [x] expose navicust info via getNavicustEditor
• [x] style support
  • [x] find where style data is stored in EWRAM
  • [x] make a UI for this

MacOS: Ventura 13.0 Processor: Quad-Core Intel Core i7 Tango version: 4.0.23

I tried playing with my logitech controller but it wasn't detected by Tango (in game or in the input setting section). I found SDL Github repo this issue https://github.com/libsdl-org/SDL/issues/5781 and saw the link to this page https://nachtimwald.com/2020/11/08/macos-iohidmanager-permission-issue/

Based on the page I had to give Tango Input Monitoring privileges which worked

Not sure where to put this kind of documentation in Tango for other users, but happy to open a PR given directions

Tango's launcher doesn't detect Switch's JoyCons, NES, and SNES controllers, ignoring any button requests when attempting to map these controllers.

Strangely, Switch Pro Controllers work perfectly fine, not sure how the above controllers operate differently from SPCs.

For some reason, whenever a version change is made(3.2.44 to 3.2.45, for example) the program won't auto-update for me. I have stable update channel on and I don't know what I'd have to enable to allow it to auto update.

• glutin:

  • up-to-date drivers: fine
  • nvidia: fine but stream is dark on discord?
  • really old intel graphics drivers: horrible texture mangling
  • mesa (with srgb): doesn't work, NoAvailablePixelFormat
  • mesa (without srgb): wrong colors
  • angle (using gles): wrong colors but slightly less wrong
  • powervr (using gles): lol

• wgpu:

  • up-to-date drivers: fine
  • some intel drivers: crashes on vulkan, must use d3d12
  • angle (using gles): wrong colors but just as wrong as glutin gles
  • mesa (using gles): doesn't work at all, just hangs
  • powervr (using gles): lol

Most of the stuff breaking Linux support was already fixed thanks to some back and forth on Discord with @bigfarts . This PR mainly just adds some stuff to package.json to allow it to build an AppImage with everything it needs.

Overview of this PR:

• Added build:linux script to package.json, which does the build without calling the Windows-specific update-bin.sh script
• Added dist:linux script to package.json, which is identical to dist except it calls build:linux instead of build
• Added a linux section to package.json, which tells Electron to also copy libSDL2 shared objects from the host to the AppImage, this way the AppImage works fine even if the user's machine doesn't have SDL2 installed
• Ensures tango-core is spawned from the launcher while inheriting the full environment. Otherwise it won't be able to find any bundled shared objects and will crash.

Building:

• The build process is straightforward, even easier than building for Windows. I believe your workflow already satisfies all the dependencies, it's just a matter of changing some of the commands out. But for completeness, here's what I used to build on a clean Ubuntu 20.04 Docker image:

# Update system and install apt dependencies
apt update -y
apt upgrade -y
DEBIAN_FRONTEND=noninteractive apt install -y alsa build-essential clang cmake curl git libnss3 libsdl2-dev libsdl2-ttf-dev pkgconf sudo

# Install Rust, not using apt since apt's version is too old
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y

# Install node 18 because apt is on version 12 or something
curl -fsSL https://deb.nodesource.com/setup_18.x | sudo -E bash - && \
	sudo apt-get install -y nodejs

# Clone tango
git clone --recurse-submodules https://github.com/tangobattle/tango

# Build the core
cd tango/core
cargo build --release --target x86_64-unknown-linux-gnu

# Copy the core binaries to the launcher
cd ..
mkdir -p launcher/bin
cp core/target/x86_64-unknown-linux-gnu/release/{tango-core,replayview,replaydump,keymaptool} ./launcher/bin/

# Install npm dependencies
cd launcher
npm install

# Build the launcher and package the AppImage
npm run dist:linux

# AppImage will be found at:
# ./packages/Tango-3.1.10.AppImage

Things of note:

• When packaging this for release, I recommend compiling on Ubuntu 20.04 instead of Ubuntu 22.04. This is so that it gets compiled with a slightly older version of glibc, allowing it to run on a wider range of systems. If this were compiled on Ubuntu 22.04, it would only be compatible with a very limited number of systems with the recent version of glibc used by 22.04.
• I haven't tested this on an online PvP match at all. The game runs though, so I have no reason to believe the netplay would be broken. Perhaps some beta Linux builds can be released so the wider community can give it a try and report problems.
• For whatever reason (at least on KDE), Tango's icon doesn't show in the application window. Instead, it uses the default placeholder X11 icon. Not a huge deal but I don't know why this is:

There's always an external program that will help out with that, but not everyone is a tech literate person willing to take a minute to set up a keyboard emulation program. With Tango 3.0 focusing on user-friendliness (or so it seems to me), I feel like adding controller support fits in with that theme.

unsure why this happens

[2022-09-28T11:44:27Z WARN  datachannel::sys] rtc::impl::IceTransport::LogCallback@354: juice: Send failed, datagram is too large

Your FOSSA integration was successful! Attached in this PR is a badge and license report to track scan status in your README.

Below are docs for integrating FOSSA license checks into your CI:

• CircleCI
• TravisCI
• Jenkins
• Other

marwe — Today at 16:34 nice, I think that's pretty much the only way to make the dynamic dream a reality otherwise the other option would have to be like the patch devs supplying additional hardcoded metadata for the save viewer

works on 3.2.33, almost definitely due to shadow input changes

todo:

• rewrite rx packets out of replayview to see what they are and compare

20220705144710-ROCKEXE4.5ROBR4Jbn45_us_real_bn_gameplay-v0.6.0-vs-I_Drink_Jet_Fuel-unhinged-aquadrgn-occurroico-round3-p1.tangoreplay.gz

MacOS version: Ventura 13.0 Processor: Quad-Core Intel Core i7 Tango: 4.0.23

I saw that support for Switch Joycons is available for Tango. But whenever I try to open Tango while my Macbook is connected to my Switch joycons it would crash. The log outputs are always the same (pasting just the crash reason):

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: SdlError("Couldn't open Bluetooth_057e_2006_0x7fe5e8704080")', tango/src/main.rs:253:54
stack backtrace:
   0: _rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::result::unwrap_failed
   3: core::result::Result<T,E>::unwrap
   4: tango::child_main
   5: tango::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

The program doesn't crash when Tango is already open and I connect my Switch joycons, but the program wouldn't pick up the inputs from the joycons (didn't check the logs for thesee, but can try and replicate if needed)

I also noticed that my Switch joycon bluetooth connection identifier (the green lights) would be at 2 green lights whenever I have it connected with Tango open, which I think means that it is connected as the second device to the bluetooth interface. But I checked and there were no other bluetooth devices connected to my Macbook

i'm not sure why:

• this only happens during the turn (also the audio gets scrunkly)
• in the custom screen the audio is not scrunkly
• doesn't seem to cause any timing issues
• maybe skipping samples?

this seems relatively complicated to implement, as during the random battle screens there is SIO communication going on. i don't really know what the SIO in question is, though, and how much of it is actually required (and how much of it can just be fudged).