##Adding Clear-all and toggle tasks done functionalities

In this milestone:

• Added clear functionality in class and used it on an event listener.
• Users can switch tasks status to done or incomplete.
• All interactions that change data will update local storage.

deploymentis done from the dist folder on a dedicated subtree branch called deployment.

##Adding to-do list Functionality and styling

In this milestone:

• Removed all hardcoded items from the tasks array.
• Created 2 js files for classes and functionality declaration.
• Implemented Add, Remove, Edit, and Complete functionality
• New tasks by default accept property complete to be false.
• Deleting a task updates list indexes.
• All changes are stored in local storage.
• Added styling modification to match the design.

deploymentis done from the dist folder on a dedicated subtree branch called deployment.

##Adding to-do list structure and updating list dynamically.

In this milestone:

• Used preconfigured webpack template to set up the project.
• to do list is populated dynamically from the list of items in the data.js file.
• CSS is loaded by Webpack Style/CSS Loader.
• All source files (index.html, index.js and style.css) are located in /src directory and distribution files are generated by webpack and served by webpack dev server from /dist folder.
• deployment is done from dist folder on a dedicated subtree branch called deployment.

Hi @Elerqsousy, You have done a great job. Every functionality of the project is ok and the interface is also looking good. Here are some suggestions that you can consider : 1.

• You can consider using retrun this inside the class for method chaining. Here is an example from this article :

• Inside this function, it exists a single line. This is not a multiline function and it's a good practice for writing javascript code not to use multiline for single line function. https://github.com/Elerqsousy/to-do-list/blob/6a83d1ca360198ef027abd4de5e82cec987c4396/src/modules/functionality.js#L50

• This to-do list is taking blank comments. Consider using required inside input tag.

Happy Coding :+1:

Instead of exporting one object as it is, using distracting before or after importing would have been much more clear and readable. https://github.com/Elerqsousy/to-do-list/blob/6a83d1ca360198ef027abd4de5e82cec987c4396/src/modules/icons.js#L1-L4

const {undoneIcone , doneIcon} = icons;

Nesting object directly in the constructor

In these lines of code

1. Naming

-Using more descriptive names would have been great. Instead of Node you could have used ObjectClass. https://github.com/Elerqsousy/to-do-list/blob/6a83d1ca360198ef027abd4de5e82cec987c4396/src/modules/object-class.js#L1 The same concept applies here: https://github.com/Elerqsousy/to-do-list/blob/6a83d1ca360198ef027abd4de5e82cec987c4396/src/modules/object-class.js#L2

2. YAGNI

-The this.object is not needed and could have been nested directly in the constructor object. https://github.com/Elerqsousy/to-do-list/blob/6a83d1ca360198ef027abd4de5e82cec987c4396/src/modules/object-class.js#L2-L11

like this: class ObjectClass { constructor(description, completed, index = 0) { this.object = { description:${this.description = description}, completed: this.completed = completed, index: this.index = index, }; } }

Hey, you did a Great job with the project. I have some suggestions for you to improve it.

it's better to use meaningful class names instead of Node use Task
also the objected as Node attribute is repeated you can directly set description completed and index as attributes and same for Data class i think Tasks would be more meaningful

Happy coding. ⭐😊✌️