Hi,

I am updating some of my plugin but some weird bug is happening with jquery easing. Using the old version (1.3) the problem does not happen, using the new version the problem happens.

Both codes below are absolutely exactly the same. Nothing is different except the version of jquery easing.

https://quemfazsite.com.br/temp/teste-old-easing.php https://quemfazsite.com.br/temp/teste-new-easing.php

Open the first link (old) and click GO1 and GO2. You will see an animation in the background color. When you open the second link and click in GO1 and GO2 you will see the animation works strangely, a black background appears in the element.

The strangest thing here is that I am not even using EASING in this page! The animation is being done with the default, LINEAR but no other fancy easing is being used and even so jquery easing messes with the animation.

Can we expect a solution soon?

I wanted to use your script in a WordPress theme and because of the BSD license this is not possible. There are few BSD licensees that are compatible with GPL but it has to be specified. Right now your license is global and says only BSD so it falls under OriginalBSD.

Here is what your license is currently referring to https://www.gnu.org/licenses/license-list.en.html#OriginalBSD

Any way you can change this to GPL compatible license so that we can use it in WordPress?

The source code of this library is written as if it were minified code, and it also has lots of redundant logic problems. I'm trying to expand this into non-jQuery functions to use in another library which is why I've discovered these cases.

For example these lines of code:

https://github.com/gdsmith/jquery.easing/blob/master/jquery.easing.js#L104-L111

There's a few things here that are undesirable in source code:

• One letter variable names, including the fn parameters, making debugging difficult / impossible. Fortunately this StackOverflow answer is helpful.
• The highlighted function first hard codes var p = 0; and then checks if (!p) p=d*(.3*1.5);. Things like this could be avoided for efficiency, and make the source code more readable.
• Incorrect javascript scoping is used, in the same function var s=1.70158; and then else var s = you can see s is redefined incorrectly using a second var declaration
• Inline operators are used in if statements such as if ((t/=d/2)==2) which mutates the variable t in place, making tracing code unnecessarily difficult.
• In general these functions aren't written like source code. They're written like (poorly) hand optimized, (poorly) hand minified functions that would be better left to Uglify or Closure Compiler work on them.

Since these functions have clearly stood the test of time the logic in them is sound and doesn't need to change for the library to work. For a learning opportunity, however, there is much room for improvement.

This is more of a comment/query. I am trying to include this plugin using requirejs and I am having a lot of issues with this loading. I have tried to shim it but with no luck. Will this plugin be rewritten to be AMD compliant?

I was using your easing script on a site I made. You put up a notification and linked me to an other one I could use. Just wanted to say thank you and sorry for any inconvenience I may have caused. I'm new to javascript and I didnt know it was a problem to link to your script. Ive updated my code to point to the link you sent.

Really sorry, and thanks again.

jQuery has released with jQuery 3.1.1 a 'slim' version that excludes easing. jQuery Easing Plugin tries to preserve the original jQuery 'swing' easing by default. A check was added to prevent error messages.

Hey, Thanks for the good effort in building this library. We would like to use your node in our project.

Can you let us know what license have been assigned to this library?

Thanks Kandy

It'd also be nice to have your file(s)' CDN integrity hash on Github, so that one can confirm the integrity at the source of what any particular CDN is serving.

I just found out that the link to the license in file jquery.easing.js is not correct.

The link in line 6 is: https://raw.github.com/gdsmith/jquery-easing/master/LICENSE

The correct link should be: https://raw.github.com/gdsmith/jquery.easing/master/LICENSE

The correct substring in the link is "jquery.easing" instead of "jquery-easing".

When searching for jquery.easing in the node.js modules folder, I couldn't find it, and when I require it, it just returns a blank object. Does the module still work?

Google pagespeed report:

Minify JavaScript Compacting JavaScript code can save many bytes of data and speed up downloading, parsing, and execution time. Minify JavaScript for the following resources to reduce their size by 991B (53% reduction). Minifying https://cdnjs.cloudflare.com/…s/jquery-easing/1.3/jquery.easing.min.js could save 991B (53% reduction) after compression.

Improving the min.js version improves PageSpeed score and therefore your SEO

Bumps minimist from 1.2.5 to 1.2.6.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Hi,

I have installed jQuery and Jquery.easing modules in a project but I am getting below error when run the page.

at /node_modules/jquery.easing/jquery.easing.js:22:28 at /node_modules/jquery.easing/jquery.easing.js:15:13 at Object. (/node_modules/jquery.easing/jquery.easing.js:19:3) at Module._compile (internal/modules/cjs/loader.js:1176:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1196:10) at Module.load (internal/modules/cjs/loader.js:1040:32) at Function.Module._load (internal/modules/cjs/loader.js:929:14) at Module.require (internal/modules/cjs/loader.js:1080:19) at require (internal/modules/cjs/helpers.js:72:18) at eval (webpack-internal:///jquery.easing:1:18)

I seriously dont know what the cause of this issue.

Please help me to resolve this issue

Builds on #40 (dropping bower).

• Enhancement: Derive main easing files (including minified) from ESM source, with main ones assuming global jQuery
• Enhancement: Add module, exports, browser, and type for ESM usage by bundlers or Node
• Enhancement: Have CommonJS API require passing in jquery instance (passing in alone not sufficient)
• Docs/Demo: Add Node CJS demo; give more on usage
• Linting: More consistent styling
• Refactoring: Switch to ES6 Modules in source
• Refactoring: More ES6 in source
• npm: Update jquery dep.; remove uglify-js (using Terser with Rollup)

A couple notes:

1. If you are open to it, I can move the jquery.easing.js and jquery.easing.min.js to a new dist folder, as that should make things a bit cleaner, though it would increase breakage as the path would change.
2. Since jQuery doesn't yet fully support ESM (e.g., see https://github.com/jquery/jquery/issues/4592 ), using import statements against jQuery in source would need our adding Rollup's commonjs plugin, and it would have the disadvantage of baking in a specific version of jQuery, adding to bundle size (unless we kept the import statement as an import statement, but then users would have to do their own bundling based on our bundle which isn't very convenient). So, currently, even one of the ESM source files relies on a jQuery global, though there is also another source file addJQueryEasing.js (in source at src/addJQueryEasing.mjs) which allows one to pass in one's own jQuery instance if that is desired. jQuery's current lack of proper ESM export is another reason I didn't bother with a native Node ESM demo, though I tentatively added such support in package.json (by the type and exports fields).
3. I changed the API for CJS to require passing in a jQuery instance. This is because one really must have some DOM built to use in Node, e.g., with jsdom to get things working properly (I added a demo that executes without error, but as it is in Node, there is of course no visual effect). Note that CJS support had been broken until recently anyways, so I don't think this necessitates a breaking change (nor, as a result, should I think the addition of exports be so, even though it normally would be a breaking change since it prevents Node access to other files--but it wouldn't of course impact browser use even if installed by npm). module and browser can be breaking changes too, but I think they are targeting the files that should be expected.
4. Although I didn't do so, we could add jquery as a peer dependency for Node usage, but Node really needs custom tooling like jsdom as well, so maybe better to avoid the hassle of having to keep peerDependencies up to date.
5. While I added a few more linting rules for consistent styling, I'd be happy to apply a more rigorous config, e.g., standard, airbnb, etc., if you like.

I see there is a tag for 1.4.2, but that tag updated package.json, bower.json, etc. to 1.4.1 instead (and the npm package doesn't have all of that commit's changes either). Could we get a new release where the tag reflects the npm package version? Thanks!

Hi All,

Thank you for your time making this project available!

Today I was doing some experiments on a TS project and I've converted the source to TypeScript.

https://gist.github.com/slig/145d7333052b7b2532f90d9f47e20d8e

In the end I decided I'll stick with the default swing from jQuery, but I thought the source might be useful for someone else.

Just to be clear, I don't expect the project to be converted to TS. I'm posting this here so someone googling for the type definitions can find them on the above gist.

The documentation for the plugin at the official site http://gsgd.co.uk/sandbox/jquery/easing/ needs to be updated to explain and guide other developers around the breaking of the Bonus feature where easing 1.3.x is based on jQuery 1.x and 2.x and easing 1.4.x is based on jQuery 3.x.

It would be nice to also have this documentation in the README.md for https://github.com/gdsmith/jquery.easing

jQuery.easing.method()'s old signature no longer works the same in 1.4.x:

jQuery.easing.method(
	null†,
	current_time,
	start_value,
	end_value,
	total_time)

Wherever it is used directly in custom animations, the formula needs to be tweaked into this form:

// - x is (current_time / total_time), aka "percentage completed"
// - d is (end_value - start_value), aka "distance"
// - s is (start_value), if not zero
jQuery.easing.method(x) * d + s

One example of using jQuery.easing.method() directly is when creating window.scrollBy() smooth scroll animations. jQuery handles CSS animations easily, but doesn't quite fit for controlling window scrolling position, as far as I know.