The original projected named 'database-js' is abandoned. Acessing its project page returns a 404.

NPM has a policy about disputes that states This process is an excellent way to: - Adopt an "abandoned" package (...), among other things. So, I think this is a good opportunity to get the name database-js.

I have a test like:

async myFunction() {
...
try {
		conn = new Connection(connStr); 
		statement = conn.prepareStatement(orderIdsQuery);

		do {
			results = await statement.query();
		}
		while ([undefined, null].includes(results));

		let randomIndex = getRandomInt(0, results.length - 1);
		let orderId = results[randomIndex].Id;
		let multiDrive = results[randomIndex].DriverAmount === 1;

		statement = conn.prepareStatement(orderPeopleQuery);

		do {
			results = await statement.query(orderId);
		}
		while ([undefined, null].includes(results));

		result = {'orderId': orderId, 'multiDrive': multiDrive, 'people': results};
	}
	catch (reason) {
		console.log(reason);
	}
	finally {
		if (conn) {
			await conn.close();
		}
	}

	return result;
}

Before() {
...
let res = await myFunction();
...
}

Scenario() {
...
}.retry(1)

It is expected that test to work like this: If it fails - it starts again, completes request once more, and then goes to scenario steps, but I got this exception after test restarted:

Error: Global connection already exists. Call sql.close() first.
    at Object.connect (/Users/orkhan.mamedov/WebstormProjects/SravniClient/node_modules/database-js-mssql/node_modules/mssql/lib/base.js:1639:10)
    at MsSql._pool (/Users/orkhan.mamedov/WebstormProjects/SravniClient/node_modules/database-js-mssql/index.js:61:33)
    at MsSql.query (/Users/orkhan.mamedov/WebstormProjects/SravniClient/node_modules/database-js-mssql/index.js:73:31)
    at /Users/orkhan.mamedov/WebstormProjects/SravniClient/node_modules/database-js/lib/statement.js:69:38
    at new Promise (<anonymous>)
    at PreparedStatement.query (/Users/orkhan.mamedov/WebstormProjects/SravniClient/node_modules/database-js/lib/statement.js:60:16)
...

It seems as a bug, can you help me with that?

Currently, Connection currently receives a connectionString:

class Connection {
    constructor(connectionString, driver) {
        this.__base = ParseConnection(connectionString, driver);
        . . .
    }
  . . .
}

Sometimes it is desirable to create a connection passing parameters, such as in ConnectionObject, or maybe using a plain object.

So, to adjusting Connection's constructor to accept both a string or a ConnectionObject would be:

class Connection {
    constructor(conn, driver) {
        this.__base = 'string' === typeof conn ? ParseConnection(conn, driver) : conn;
        . . .
   }
   . . .
}

To receiving a plain object with connection properties, I think it would be better changing ConnectionObject instead of Connection. In this case, ConnectionObject could have a static constructor-like method:

class ConnectionObject {
   ...
   static fromPlain( obj, driver ) {
      return new ConnectionObject(
        obj[ 'driverName' ], 
        obj[ 'username' ],
        obj[ 'password' ],
        obj[ 'hostname' ],
        obj[ 'port' ],
        obj[ 'database' ],
        obj[ 'parameters' ],
        driver
      );
   }
  . . .
}

And then we could create a connection from a plain object:

let p = require( 'mydb.json' ); // a JSON file with database connection properties
let c = new Connection( ConnectionObject.fromPlain( p, driver ), driver );
// or just
let c = new Connection( ConnectionObject.fromPlain( require( 'mydb.json' ), driver ) );

Wouldn't it be nice?

Database-js has drivers as separated projects. It does not need to include them as dev dependencies.

On the other side, the drivers should include database-js as a dev dependency, for testing purposes (or they have to me maintained inside database-js, but never committed). However, database-js loads the drivers according to the driverName, including (with require) the respective file. Since the driver's index.js is not inside database-js, it is not able to find it and, thus, to load the driver.

There is a little hack, however, to solve this problem. I have used it in database-js-json, inside its mocha test file:

    var obj = {
        // hack to load the index of the driver as a module of database-js
        driverName: '../../../index', 
        . . .
    };
   var conn = new dbjs.Connection( obj );
   . . .

It would be nice having another solution to the driver loading problem. I the mean time, this hack can be useful to add proper tests in each driver project. @mlaanderson What do you think?

I think there is an error using a string connection , I had to change my password in order to make it work

for example my password : gwW^/0/L

was not working

I think it would be cool if you could receive an object so in that way the regex wont fail and it would be easier to pass the parameters

conn = new Connection("database-js-postgres://postgres:password@ip:5432/db"); try { statement = await conn.prepareStatement("SELECT * FROM connection WHERE name = ?"); rows = await statement.query('datasama'); console.log(rows); } catch (error) { console.log(error); } finally { await connection.close(); }

Activate this project in Travis, in order to let it check the build status. Then we can add an image of the build status to the README.md file.

@mlaanderson I've already added the file .travis.yml to the project.

Instead of using database-js-driver://, the project could adopt just driver://.

Examples (JDBC-like):

• mysql for MySQL databases (currently database-js-mysql)
• postgresql for PostgreSQL databases (currently database-js-postgres)
• sqlite for SQLite databases (currently database-js-sqlite)
• firebase for Firebase databases (currently database-js-firebase)
• ado for ActiveX Data Objects, like MS Excel tables and MS Access databases (currently database-js-adodb)
• ini for INI files (currently database-js-ini)

Other examples (for future use?):

• json for JSON files
• xml for XML files
• odbc for ODBC access to databases
• oracle for Oracle databases
• sqlserver for MS SQL Server databases
• firebirdsql for Firebird databases
• mariadb for MariaDB (as an alternative driver to MySQL)

Please, Can you provide better examples, how to use database-js? Something like this https://www.w3schools.com/nodejs/nodejs_mysql_create_db.asp How to create database, create table, insert into table a single row and insert multiple rows from array, update data, delete data ... database-je nice because support a lot of different drivers.

Thanks in advance, VladanO

QuoteString() uses the string.replace() method to escape special characters, but passes the patterns to it as strings. When the pattern is given as a string, only the first instance of the pattern is replaced.

The patterns need to be converted to regex patterns/objects in order for every instance to be replaced properly. For example, string = string.replace("'", "''"); becomes string = string.replace(/'/g, "''");.

I'm preparing a PR and will be submitting it soon if you'd be willing to accept it.

When trying to search "database-js" in NPM, the subprojects don't appear. Maybe adding the keyword database-js to them would make they do.

So, in order to improve the discoverability of database-js and subprojects, I suggest that:

• [x] Every subproject receive database-js as a keyword;
  • [x] database-js-mysql
  • [x] database-js-postgres
  • [x] database-js-sqlite
  • [x] database-js-adodb
  • [x] database-js-firebase
  • [x] database-js-ini
  • [x] database-js-xlsx
  • [x] database-js-csv
  • [X] database-js-json
• [x] Database-js receive subprojects' names as keywords (e.g. database-js-mysql, etc.). DONE

NPM uses the keywords from package.json.

Proposal

database-js-txt

Virtual Columns

Text files could have these virtual columns:

1. line (any line of the file)
2. line_number

Examples:

# Line starting with Hello
SELECT `line_number`, `line` WHERE `line` LIKE "Hello%"

# First line in the file
SELECT `line` WHERE `line_number` = 1

# Number of lines in the file
SELECT COUNT( `line` )

# Number of lines in the file, different way
SELECT MAX( `line_number` )

# Last line in the file
SELECT `line` WHERE `line_number` = COUNT( `line` )

# Content from some lines
SELECT `line` WHERE `line_number` BETWEEN 5 AND 10

# Content from some lines, different way (needed?)
SELECT `line` OFFSET 5 LIMIT 5

Basic Operators

=, <>, >, >=, <, <=, LIKE, NOT, AND, OR, BETWEEN

Basic Constructions

WHERE, ORDER BY

Basic Functions

COUNT, MAX

Expected future enhancements

• MATCHES operator, for matching a given regular expression. E.g., SELECT * WHERE line MATCHES "^Created at [0-9]{1,2}:[0-9]{1,2}"