I have set up husky commit hooks to run on commit and push, it works for me and another dev, but for one dev the commit hooks do not get run. Not sure what the issue is here

So after adding Husky to my local project, all my local commits are now taking an eternity when using GitKraken. Note, I believe this issue is specific to GitKraken, so it's unlikely that it's a Husky issue per-se, but it might be nice if the two teams had an issue in which to discuss getting it fixed?

I've spoken to the GitKraken team and given them as much information as possible (including giving them a link to this issue). But perhaps some of the Husky team might be able to give some pointers as to where to start looking for the cause?

Just have upgraded from v4.3.8 to v5.0.9 and got the error

have tried to uninstall/install husky, remove npde_modules - nothing helped

> git -c user.useConfigOnly=true commit --quiet --allow-empty-message --file -
error Command "husky-run" not found.

I have a postinstall script in a NPM package:

"postinstall": "is-ci || husky install",

If I download the repository using Github UI (Code -> Download ZIP), after extracting it, executing npm install raises Error: .git can't be found:

> [email protected] postinstall /.../simple-icons-font-develop
> is-ci || husky install

/.../simple-icons-font-develop/node_modules/husky/lib/commands/install.js:20
        throw new Error(".git can't be found");
        ^

Error: .git can't be found
    at Object.install (/.../simple-icons-font-develop/node_modules/husky/lib/commands/install.js:20:15)
    at Object.<anonymous> (/.../simple-icons-font-develop/node_modules/husky/lib/bin.js:43:19)

I can prevent the error doing something like this:

"postinstall": "node -e \"if(require('fs').existsSync('.git')){process.exit(1)}\" || is-ci || husky install",

But it seems a bit hacky. What would be the recommended way to solve this?

OS: MacOS 10.15.2 (19C57) Git: git version 2.24.1

❯ which git /usr/local/bin/git

❯ node -v v13.5.0

❯ which node /usr/local/bin/node

❯ which npx /usr/local/bin/npx

Node.js installed with brew package manager

    "husky": "^4.0.6",

When making commit in VSCode GUI

Can't find npx in PATH: /usr/local/Cellar/git/2.24.1/libexec/git-core:/usr/bin:/bin:/usr/sbin:/sbin
Skipping pre-commit hook
Can't find npx in PATH: /usr/local/Cellar/git/2.24.1/libexec/git-core:/usr/bin:/bin:/usr/sbin:/sbin
Skipping prepare-commit-msg hook
Can't find npx in PATH: /usr/local/Cellar/git/2.24.1/libexec/git-core:/usr/bin:/bin:/usr/sbin:/sbin
Skipping commit-msg hook
Can't find npx in PATH: /usr/local/Cellar/git/2.24.1/libexec/git-core:/usr/bin:/bin:/usr/sbin:/sbin
Skipping post-commit hook

Everything works fine when making commit from VSCode terminal.

Version 3 works fine. Sample output from v3:

Info: can't find node in PATH, trying to find a node binary on your system
husky > pre-commit (node v13.5.0)
Stashing changes... [started]
Stashing changes... [skipped]
→ No partially staged files found...
Running tasks... [started]
Running tasks for *.{js,ts,tsx,css,md} [started]
tslint --fix [started]
tslint --fix [completed]
prettier --write [started]
prettier --write [completed]
git add [started]
git add [completed]
Running tasks for *.{js,ts,tsx,css,md} [completed]
Running tasks... [completed]

After upgrade to husky v5, git commit from vscode always fail (via terminal is ok).

> git -c user.useConfigOnly=true commit --quiet --allow-empty-message --file -
.husky/pre-commit: line 4: npx: command not found
husky - pre-commit hook exited with code 127 (error)

npm version: 7.5.1 node version: 15.8.0

Hooks

// pre-commit
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npx lint-staged

Husky 4.0.0 isn't working in Git Bash for Windows 10, triggering a stdin is not a tty error for every git operation that triggers a hook.

Versions

OS: Windows 10 1903 Shell: Git Bash (GNU bash, version 4.4.23(1)-release (x86_64-pc-msys)) Git: git 2.24.1.windows.2

HUSKY_DEBUG=1 npm install husky --save-dev

$ HUSKY_DEBUG=1 npm install husky --save-dev

> [email protected] install C:\dev\test\husky4-tty-test\node_modules\husky
> node husky install

husky > Setting up git hooks
husky:debug Current working directory is C:\dev\test\husky4-tty-test\node_modules\husky
husky:debug INIT_CWD is set to C:\dev\test\husky4-tty-test
husky:debug Git rev-parse command returned:
husky:debug   --git-common-dir: undefined
husky:debug   --show-prefix:
The "path" argument must be of type string. Received type undefined
husky:debug TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
    at validateString (internal/validators.js:112:11)
    at Object.resolve (path.js:139:9)
    at getDirs (C:\dev\test\husky4-tty-test\node_modules\husky\lib\installer\bin.js:27:49)
    at run (C:\dev\test\husky4-tty-test\node_modules\husky\lib\installer\bin.js:62:62)
    at Object.<anonymous> (C:\dev\test\husky4-tty-test\node_modules\husky\lib\installer\bin.js:85:1)
    at Module._compile (internal/modules/cjs/loader.js:959:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Function.Module._load (internal/modules/cjs/loader.js:727:14)
    at Module.require (internal/modules/cjs/loader.js:852:19)
husky > Failed to install

> [email protected] postinstall C:\dev\test\husky4-tty-test\node_modules\husky
> opencollective-postinstall || exit 0

Thank you for using husky!
If you rely on this package, please consider supporting our open collective:
> https://opencollective.com/husky/donate

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN [email protected] No description
npm WARN [email protected] No repository field.

+ [email protected]
added 48 packages from 22 contributors and audited 48 packages in 2.047s

3 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

HUSKY_DEBUG=1 git commit

Note: on the fresh test repo, this command worked because the first command failed so the hooks did not install properly. On an existing repo with existing hooks, it looks like this:

husky:debug husky v4.0.0 (created at 1/7/2020, 1:24:18 PM)
husky:debug pre-commit hook started
husky:debug Current working directory is /c/dev/test/existing-repo
husky:debug pre-commit hook started
stdin is not a tty
husky:debug yarn husky-run exited with 1 exit code

I just tried to husky a prepush script and nothing happened. Looking at .git/hooks/pre-push I see that I already have a hook there:

#!/bin/sh
command -v git-lfs >/dev/null 2>&1 || { echo >&2 "\nThis repository is configured for Git LFS but 'git-lfs' was not found on your path. If you no longer wish to use Git LFS, remove this hook by deleting .git/hooks/pre-push.\n"; exit 2; }
git lfs pre-push "$@"

Running node node_modules/husky/bin/install.js doesn't help:

husky
setting up hooks
skipping pre-push hook (existing user hook)
done

I guess that's good, as I don't want Git LFS to break and get some large files in the repo without noticing...

Is there a husky solution for having a prepush while also using git-lfs?

I'm trying to use husky precommit with sourcetree. The precommit command is run but i get the following error:

Does anybody know what's wrong? I'm using n.

OS: macOS Mojave 10.14 Node: 10.13 $ which node: /usr/local/bin/node npm: 6.4.1 $ whick npm: /usr/local/bin/npm

When running yarn add husky --dev, the git hooks do not get set up. I have to run the install script manually, and then it works fine.

Yarn version: 0.17.9

Today I've noticed that Husky hooks suddenly stopped working in a monorepo. After investigating I've found out that file husky.local.sh inside .git\hooks had an entry on last line cd "packages/shared/". After removing this line Husky hooks started to work again.

My folder structure is like: root: -package.json (with Husky hooks setup) -.git --packages ---shared -----package.json ---web ------package.json

Could this happen when I ran yarn add/install or lerna clean && lerna bootstrap from a sub-directory? Is Husky aware of lerna/yarn workspaces? One solution to always use the right directory would be to check package.json for husky key.

OS: Windows 10 Terminal: webstorm, CMD, cygwin Since issue was pinpointed I'm not including command's outputs.

Troubleshoot

• [x] Before creating an issue, please check:

Context

Github action log:

  . postinstall$ husky install
  . postinstall: sh: 1: husky: Permission denied
  . postinstall: Failed

Everything works fine in my project at vuepress-theme-hope untill I add node-linker=hosited to .npmrc for testing (I am using pnpm)

Since other packages which has postinstall (like esbuild) are not metting permission issues, I think that the fix may need to be applied here.

I did not look in through husky code yet, and I am not sure if the maintainer would like to check this first. I would be happy if you want more information, Thank you!

Troubleshoot

• [x] Before creating an issue, please check: https://typicode.github.io/husky/#/?id=troubleshoot

Context (This is a minor issue: Functionality isn't affected.)

Scripts generated by husky add contain the line:

. "$(dirname -- "$0")/_/husky.sh"

Shellcheck, the popular shell script linter, doesn't care for that line. It complains:

Not following: ./_/husky.sh was not specified as input (see shellcheck -x). shellcheck(SC1091)

The rule in question, SC1091, is complaining about Shellcheck not being able to access the referenced file. I can't think of a way to satisfy the rule, so it may be that the best solution is to have husky add emit a shellcheck disable directive above it:

# shellcheck disable=SC1091
. "$(dirname -- "$0")/_/husky.sh"

Of course, another solution would be for developers to simply ignore the warning, but I believe it's very common for devs who use VS Code to have the Shellcheck extension installed (it has 500,000+ downloads) and enabled by default, so an extra line to silence the warning might avoid some confusion. Or maybe there's a more Shellcheck-friendly way to run husky.sh.

VS Code can get into a weird state where husky pre-commits will fail with command not found but the solution is to simply restart VS Code. see https://stackoverflow.com/a/73635509/5504797

I scoured a lot of GitHub issues and Stack Overflow problems. The difficulty in just using:

export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"

is that - by default - nvm.sh will run the default Node version which isn't necessarily the project's node version. This still won't save anybody manually bouncing between Node versions within different projects, but .nvmrc is a very common practice and this should assuage people who run Husky in a project using an .nvmrc file that differs from their NVM default.

Hello there 👋🏽

At my company, especially in big repositories, we encountered a lot of cases when a developer's machine has already set his hooks, but the file _/husky.sh has moved or not exists. For example when migrating between husky versions and the place of _/husky.sh changed.

On this PR, the file will check for the existence of _/husky.sh and if not exists it will install the file through husky install. In case the husky package is not installed yet (on the node_modules) we set the || exist 0

Another option is to set npx husky install instead of husky install || exit 0, what do you think? At the moment, at my company, we set the sensitive repositories to work with husky install || exit 0 and it really reduced the questions of developers stuck while trying to pull from other branches where they got breaking changes in husky setup.