Since i've started using this plugin, I'm seeing more and more this screen. Is there any known issue that causes this?

Once it happens, I have to close & open the tab again. Refresh doesnt work.

Thanks in advance

I'm getting the following error in IE 11:

 `expires` parameter cannot be converted to a valid Date instance

I've tracked the error down to the _isValidDate method evaluating to [object Array Iterator] instead of [object Date]. As far as I can tell this is happening when the testKey is removed in the _areEnabled method.

Hey Scott,

I've added a noConflict method so that multiple versions/instances of Cookies can be included in the same context safely. I'm currently using it in a third-party JavaScript library that developers can include on their site. I don't want the Cookies version I'm using to conflict with a version already being included by the developer. Other major libraries like Underscore and jQuery include a noConflict method if you'd like to compare implementations.

I've only made changes to the source and added tests. I haven't minified, updated the README, or anything else.

Let me know if you have any questions or comments. Thanks!

Very nice library. Having split feelings about its by-default JSON encoding of the cookie value, however. This causes simple string literal cookie values to be saved with wrapped double-quotes around 'em. If you use this library for both reading and saving values - not such a big problem. The thing about cookies - they are usually accessed by a server-side technology too and that's where things get weird. You need to run an additional json-decode on the server-side to remove "extra" double quotes.

It would be nice if there were a way to disable by-default JSON encoding through options.

It looks like the later versions of jsDom aren't playing nicely with Cookies. Per your example, I've tried the following:

import {jsdom} from 'jsdom'

let Cookies
if (process.env.NODE_ENV === 'test') {
  Cookies = require('cookies-js')(jsdom().defaultView)
} else {
  Cookies = require('cookies-js')
}
export default Cookies

Cookies.method() work as expected in production and development, but Cookies is undefined when I run my unit tests. Is there something I'm missing?

Thanks

Specify what files to include in npm releases - this way tests and bower.json don't get included in the packaged version. (See https://docs.npmjs.com/files/package.json#files)

Hello

I have used your library for detecting cookie is disabled or not. But i am always get true Below is the my sample code

<script src="./src/cookies.js"></script>   
<script>
    (function() {
       var testKey = 'cookies.js';
         var areEnabled = Cookies.set(testKey, 1).get(testKey) === '1';
         Cookies.expire(testKey);
         alert(areEnabled);
    })();

Hi there,

Was working with this library on Safari and Chrome (local environment) and was unsuccessful in setting cookies when I explicitly defined "domain" and "expires" options.

It is successful in setting cookie without options. Is this a known behavior or perhaps user error?

Would like to talk more, thanks and looking forward to your reply. Best, Isa

Semver is tricky: moving src/x to dist/x without a symlink is a breaking change.

Why? Because on a (published) package level, the "interface" is actually the files that others "require". You haven't changed your library's interface, but that's not the only interface.

So given you're in "before-1.0.0" mode, this should have been a minor bump, not a patch bump.

In Google Chrome, if input data is incorrect, 'decodeURIComponent' method throws an exception with error string 'URIError: URI malformed'. This error causes cookie reading through 'Cookies' to stop working.

Actual behavior: code throws an error

Expected behavior: cookies with incorrect value not being returned. (possible solution: catch errors when '_getKeyValuePairFromCookieString' function is called or add error handling callback to Cookies API)

Environment: Chrome 33

To reproduce this error: invoke 'decodeURIComponent('%D0%EE%F1%F1%E8%FF')' in Chrome 33

I have two requests for this project:

a) change the Cookie.set function, so that not only a key and value as paramters are possible but also a single key-value object containing several cookie values.

i.e. Cookie.set({ option: true, option2: false }, { domain: '/' });

b) change the Cookie.set and get function, so that JSON values are accepted and parsed accordingly.

There is a quite popular Node.js cookie library called cookies on npm that – absolutely justified – declares a "cookies" TypeScript module. This complicates things in isomorphic applications where both libraries are included. A very good example for this is redux-persist-cookie-storage – I've seen people ts-ignoring because of this :cry:

@ScottHamper I would be super-glad if you could have a quick look at this one! Thanks :)

I want to be able to set an expiry date to the cookie and add some data to that cookie on certain events without resetting the expiry of it .. how can that be achieved using this library?

Cookies.get("name") - if "name" not exist return undefined Cookies.get("name", 7) - if "name" not exist return 7

Would be nice to have an optional default parameter for the get function. If the cookie is undefined then the default would be returned instead.

var c = Cookies.get("some-cookie");

if(typeof c === "undefined") {
  c = "default value";
}

vs.

var c = Cookies.get("some-cookie", "default value");

Note that the current implementation uses undefined as the default, so there really is no performance hit from doing this.

https://github.com/ScottHamper/Cookies/blob/master/src/cookies.js#L41