I think waiting a set amount of time before capturing a snapshot is not ideal.

Instead I think using Page.waitForSelector() might work better. This means that once the data is loaded and rendered you can capture it without wasting any time. To use this option there'd be a flag like --selector (and perhaps -s) that is passed to the function above directly.

I would be happy to try implementing this but before I would like some opinions on some details:

1. Should there also be an option for Page.waitForXPath()? (--xpath?)
2. Timeout
   1. Should it timeout at some point? After 10s or more?
   2. Should it throw on timeout?

Personally, I don't see the need for XPath.
I think it should timeout, but maybe after 30s or so by default and be overridable with --wait.
I'm not too sure about throwing, but it might be beneficial to know that it timed out.

Run:

npx puppeteer-heap-snapshot query -f './heap.heapsnapshot' -p full_name --debug and got:

TypeError: Cannot read properties of undefined (reading 'graph')
    at compileGraphNodeObject (/usr/local/lib/node_modules/puppeteer-heap-snapshot/dist/cjs/src/build-object.js:88:11)
    at /usr/local/lib/node_modules/puppeteer-heap-snapshot/dist/cjs/src/build-object.js:68:79
    at Array.reduce (<anonymous>)
    at compileGraphNodeObject (/usr/local/lib/node_modules/puppeteer-heap-snapshot/dist/cjs/src/build-object.js:65:26)
    at /usr/local/lib/node_modules/puppeteer-heap-snapshot/dist/cjs/src/build-object.js:68:79
    at Array.reduce (<anonymous>)
    at compileGraphNodeObject (/usr/local/lib/node_modules/puppeteer-heap-snapshot/dist/cjs/src/build-object.js:65:26)
    at /usr/local/lib/node_modules/puppeteer-heap-snapshot/dist/cjs/src/build-object.js:68:79
    at Array.reduce (<anonymous>)
    at compileGraphNodeObject (/usr/local/lib/node_modules/puppeteer-heap-snapshot/dist/cjs/src/build-object.js:65:26)

Heap snapshot https://drive.google.com/file/d/1BHiPsK4bVA-v0vPFvS-2siFrHWFyWS6Y/view?usp=sharing

Hi, I'm testing with Win10 and Node and got this error.

[Error: EISDIR: illegal operation on a directory, open 'C:\puppeteer-heap-snapshot']

how to fix?

This PR brings following changes:

1. extends options object that can be passed to query (both from CLI and as direct dependency) with depth value (to have ability explicitly limit recursions) (CLI: depth / prop: maxDepth) and unwanted node names list^ (CLI: exclude / prop: unwantedNodeNames);
2. enables stricter ts rules;
3. rest of little minor changes.

^ These changes can help to overcome situations like one that described in #1.

Example of usage: npx puppeteer-heap-snapshot.js query -u https://polypane.app/css-specificity-calculator/ -p href -e Location,HTMLAnchorElement,URL,HTMLLinkElement,SVGGradientElement,SVGFilterElement -d 1.

Hi,

I am trying to capture hrefs from the website below :

https://www.sarenza.com

with following code snippet :

const Puppeteer = require("puppeteer");
const { captureHeapSnapshot, findObjectsWithProperties } = require("puppeteer-heap-snapshot");

const start = async () => {
    const browser = await Puppeteer.launch();
    const page = await browser.newPage();

    await page.goto("https://www.sarenza.com");

    let heapSnapshot = await captureHeapSnapshot(await page.target());

    console.log('heapSnapshot:', findObjectsWithProperties(heapSnapshot, ['href']));
}

start();

I got this issue :

(node:38964) UnhandledPromiseRejectionWarning: Error: Unknown or unsupported object with type 'Location'
    at compileGraphNodeObject (C:\ws\white-label\code\test\pupeteer-heap-snapshot\node_modules\puppeteer-heap-snapshot\dist\cjs\src\build-object.js:75:19) 
    at buildObjectFromNodeId (C:\ws\white-label\code\test\pupeteer-heap-snapshot\node_modules\puppeteer-heap-snapshot\dist\cjs\src\build-object.js:34:12)  
    at C:\ws\white-label\code\test\pupeteer-heap-snapshot\node_modules\puppeteer-heap-snapshot\dist\cjs\src\query.js:16:57
    at Array.map (<anonymous>)
    at findObjectsWithProperties (C:\ws\white-label\code\test\pupeteer-heap-snapshot\node_modules\puppeteer-heap-snapshot\dist\cjs\src\query.js:14:20)     
    at start (C:\ws\white-label\code\test\pupeteer-heap-snapshot\index.js:16:34)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:38964) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:38964) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Thanks for replies.