Overview

What does this PR do? Why?

• disable user text selection around the game area
• prevent scenarios where text selection is triggered due to long-tapping buttons on mobile

PR Checklist

• [x] Fixes #26
• [x] I have run this code to verify it works
• [ ] This PR includes unit tests for the code change

This repo's part of https://github.com/FullScreenShenanigans/EightBittr/issues/186 & https://github.com/FullScreenShenanigans/EightBittr/issues/296.

Overview

What does this PR do? Why?

• a small change to .gitignore to ignore temporary files generated by vim
• prevent these temporary files (*~, *.swp, *.swo) to be pushed
• this should not affect any feature/logic

PR Checklist

• [ ] Fixes #
• [x] I have run this code to verify it works
• [x] This PR includes unit tests for the code change

Overview

Adds information to the README.md about lib/ and dist/, most notably opening mentioning lib/index.html as something you can open.

Also adds missing <!-- Development --> & <!-- /Development --> comments that are needed for shenanigans-manager's hydrate command to refresh the file.

PR Checklist

• [x] This repo's side of: https://github.com/FullScreenShenanigans/EightBittr/issues/336
• [x] I have run this code to verify it works
• [x] This PR includes unit tests for the code change

Overview

Despite the high relevancy of the Konami Code to this retro game project, there is no such easter egg in the game or on the site at all. Shame.

I'm also the creator+maintainer of https://www.npmjs.com/package/konamimojisplosion so I'd like to include that script as a fun, quick easter egg.

One complication is that https://unpkg.com/konamimojisplosion/dist/global.js takes up 11.7 kB uncompressed. This game's site is already at 254 kB uncompressed. I'd like to keep to a 256 kB performance budget if possible (it's announced on Twitter, even). So there has to be about 10 kB of savings somewhere to make this work.

Overview

What does this PR do? Why? It adds the libraries a user has visited to itemsholder and if all libraries have been visited they get a nice surprise ;)

PR Checklist

• [ ] Fixes #
• [ ] I have run this code to verify it works
• [ ] This PR includes unit tests for the code change

Overview

Brings in https://github.com/FullScreenShenanigans/EightBittr/pull/331 with some touchscreen buttons for mobile support.

Also simplifies the interface settings a bit.

PR Checklist

• [x] Fixes #2
• [x] I have run this code to verify it works
• [ ] This PR includes unit tests for the code change 🥲

Overview

Per #16, replaces the sceneplayr package with a single callback on Library actors.

PR Checklist

• [x] Fixes #1
• [x] I have run this code to verify it works
• ~[ ] This PR includes unit tests for the code change~

Overview

What does this PR do? Why?

Adds an nice little console log for people.

PR Checklist

• [x] Fixes https://github.com/FullScreenShenanigans/EightBittr/issues/315, just for this repo
• [x] I have run this code to verify it works
• ~[ ] This PR includes unit tests for the code change~

Overview

Uses :empty to set up the preview.png added in #11 as the game element's background image.

PR Checklist

• [x] Fixes #3
• [x] I have run this code to verify it works
• ~[ ] This PR includes unit tests for the code change~

Overview

Adds a bunch of meta tags for OpenGraph and Twitter, as well as a preview.png image used as the preview.

PR Checklist

• [x] Fixes #11
• [x] I have run this code to verify it works
• ~[ ] This PR includes unit tests for the code change~

Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.

🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.

Detected Package Files

• .circleci/config.yml (circleci)
• package.json (npm)

Configuration

🔡 Renovate has detected a custom config for this PR. Feel free to ask for help if you have any doubts and would like it reviewed.

Important: Now that this branch is edited, Renovate can't rebase it from the base branch any more. If you make changes to the base branch that could impact this onboarding PR, please merge them manually.

What to Expect

With your current configuration, Renovate will create 9 Pull Requests:

❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section. If you need any further assistance then you can also request help here.

This PR has been generated by Mend Renovate. View repository job log here.

Overview

I noticed in #24's video report that the header looks like this:

The page should use a CSS media query to make the header's font size smaller on mobile devices. That way the full Choose Your Framework text will always be visible.

As with #26, src/index.css is the place to write styles. They'll need to be copied to lib/index.css to be seen when running the game locally from lib/index.html.

I know adding sound effect is tricky since the app starts right away, and browser requires user interaction before playing audio. Not sure "WASD" keypress consider interaction or not 🤔

But this is just a "good to have" features 😁

https://www.reddit.com/r/javascript/comments/wxrm7m/comment/ilthbwe/?utm_source=share&utm_medium=web2x&context=3:

Walk to the table then walk all the way to the right

https://www.reddit.com/r/javascript/comments/wxrm7m/comment/ilud77h/?utm_source=share&utm_medium=web2x&context=3:

I was able to walk around the table to the right (out of frame), but Oak has no dialog assigned to him :(

...how are people doing this? It's a bug that should be fixed.