This pull request was originated from this issue.

The existing VolumeViewport class was refactored and all common functionality was extracted to an abstract base class called BaseVolumeViewport. Then both the existing VolumeViewport class and the new VolumeViewport3D extend it.

Besides that, a new utility function was added to allow easily applying a preset to a viewport.

You can try it here https://deploy-preview-281--cornerstone-3d-docs.netlify.app/live-examples/volumeviewport3d

Hello, I've been trying to use the crosshair tool while following the exemple available but I could'nt rotate the views. When I try to rotate on any axes and move the mouse this error occur : Otherwise all of the others features such as slabThickness are working.

Maybe you got and idea for this problem.

You can see an overview of my crosshair tool :

Hey, I really love this repository and especially the improved API in the new version. I created this tool for my personal use, its purpose is mostly to act like a linking of camera position and showing a reference to what your cursor is currently hovering over. It also helps a lot when you have multiple series which are not in the same Orientation, to have a feel for what you are looking at in different orientations. This is somewhat similar to the crosshair that exists, but it also works with Stack viewports, which I use it mostly for. Would there be an interest in adding this tool, I would take the time to write tests as well if that is the case. Thank you for your great library anyway! Niclas

p.s. here is a small video https://user-images.githubusercontent.com/32524613/199220760-a20ea8e2-9efb-4335-a763-0325ecba5f43.mp4

I ran into an issue while doing the examples and trying to use steaming-wadors

in all the Volume examples, imageIds are created and cached with the createImageIdsAndCacheMetaData helper function and 'VOLUME' (upper case string) for type. https://github.com/cornerstonejs/cornerstone3D-beta/blob/659888db44ab70d562f7f52872c822feb5c1db03/packages/core/examples/multiVolumeAPI/index.ts#L214

After closer inspection of the helper function you, which prefix is determined here

https://github.com/cornerstonejs/cornerstone3D-beta/blob/main/utils/demo/helpers/createImageIdsAndCacheMetaData.js#L51

but VOLUME constant is
const VOLUME = 'volume';

When I fix the constant to 'VOLUME' the streaming loader fails to initialize with the following exception... "Error: cornerstoneWADOImageLoader requires a copy of Cornerstone to work properly."

1. Bind mouseButton through setToolActive method, but it has no effect. Is it because VolumeRotateMouseWheelTool can only be operated through MouseWheel?
2. Whether a method similar to createVOISynchronizer is provided to realize simultaneous rotation of three faces of the image, because the VolumeRotateMouseWheelTool method can only rotate a single image const voiSynchronizer = createVOISynchronizer(ctVoiSynchronizerId);

TLDR: How to set proper orientation for a VolumeViewport when ImageOrientationPatient metadata doesn't match the provided constant orientations? ---

Hi, I'm having issues with finding out the proper Orientation values to set, when I'm rendering a volume with ImageOrientation metadata values different than the usual Axial/Sagital/Coronal values.

I believe that the ImageOrientation values map to orientations like this:

    coronalImageOrientationPattern = [1, 0, 0, 0, 0, -1];
    // sliceNormal: <Point3>[0, 1, 0],
    // viewUp: <Point3>[0, 0, 1],

    sagittalImageOrientationPattern = [0, 1, 0, 0, 0, -1];
    // sliceNormal: <Point3>[1, 0, 0],
    // viewUp: <Point3>[0, 0, 1],

    axialImageOrientationPattern = [1, 0, 0, 0, 1, 0];
    // sliceNormal: <Point3>[0, 0, -1],
    // viewUp: <Point3>[0, -1, 0],

But when the ImageOrientation value is different(like below), the standard orientations don't result in the expected Axial/Coronal/Sagital views. [0.85005025920695,-0.5267015823236,2.1648092e-8,0.00883004239504,0.01425087456269,-0.9998594615872].

I think cornerstone doesn't have any instructions about what to do in such case.

So I attempted to create a custom orientation based on the ImageOrientation, I found out that the sliceNormal part is created by crossing the ImageOrientation like this: sliceNormal = cross(imageOrientation.slice(0, 3), imageOrientation.slice(3, 6)), though I'm not sure if it's correct. And for the ViewUp part I have no idea how I should set it properly... When using the calculated SliceNormal and some viewUp from the constant orientations, the view seems like it's correct, except for the camera. It's often positioned wrongly. For example, for these views to be correct, we'd need to: flip the camera horizontally / move the camera to the back of the image instead of the front etc. Cornerstone doesn't give us functionalites like that tho, and even if it did, it'd be hard to dynamically decide what camera operations need to be done to make the specific view correct.

So my question is, how to set the orientation for volumes with custom ImageOrientationPatient metadata?

Volume rendered with Orientation Coronal

Volume rendered with Orientation Axial

Volume rendered with custom orientation - sliceNormal = cross(imageOrientation.slice(0, 3), viewUp = [0, 0, 1]
(in this case the problem is left=right)

Used DICOM files - series-000001.zip

This line in the code causes CINE to be in an infinite loop and render the same frame over and over. It happens when you activate the CINE tool and you are on the last image of a series.

    if (newImageIdIndex >= imageCount) {
      newImageIdIndex = 0;
    }

and since delta is const delta = newImageIdIndex - stackData.targetImageIdIndex; It causes it to go in the negative when it should always be 1 from my understanding.

        if (newImageIdIndex !== stackData.targetImageIdIndex) {
            const delta = newImageIdIndex - stackData.targetImageIdIndex;
            viewport.scroll(delta, debounced, loop);
        }
    };

If you would like to replicate the issue, visit this study

https://v3-demo.ohif.org/viewer?StudyInstanceUIDs=1.3.6.1.4.1.25403.345050719074.3824.20170126083429.2

load any series and go to the last image in it by scrolling, so 53/53 for example, and trigger the CINE tool, you will notice it freezes, and it's frozen not because it's stopped but it's just really rendering the same frame over and over.

You can check by recording the performance and looking at the call stack, or you will just notice the CPU usage rising up.

After removing those lines the issue doesn't happen anymore since the calculation for delta comes out with 1 instead of negative values, so 53- 52 = 1, with the previous code it would've been 0-52 = -52 which makes it get stuck.

The way I fixed it could be wrong, so feel free to fix it some other way, but it's an issue to lookout for anyway.

Unfortunately, that's the only piece of information that I get. Using a debugger, I have linked it to simply importing @cornerstonejs/core.

My current setup is as follows:

• Windows 10
• Vite: 2.7.2
• React: 17.0.2
• Typescript: 4.4.4
• Node: 16.13.2

Cornerstone-Related Library Versions:

- @cornerstonejs/calculate-suv: 1.0.2
- @cornerstonejs/core: 0.7.0
- @cornerstonejs/streaming-image-volume-loader: 0.2.24
- @cornerstonejs/tools: 0.10.1
- @kitware/vtk.js 24.0.0
- detect-gpu 4.0.20
- gl-matrix 3.4.3

Notable Actions: Similar to #80 , I had issues with peer dependencies and used --force when installing @cornerstonejs/tools and @cornerstonejs/streaming-image-volume-loader.

This may be related: #64

We have application based on CornerStone3D-beta library. The application can work properly with CT, PT images. The applications can't display images For X-Ray images(CR, DX, XO,) The question is following: Can CornerStone3D-beta library render and display X-Ray Images ?

If answer is positive can you give us the link of working code to display X-Ray images(CR, DX, XO) CornerStone3D- library.

Thanks in advance

When I try to display a DR image (size 4048x4932) a get the error message ‘Texture.js: 1054 WebGL: INVALID_VALUE: texImage3D: width, height or depth out of range’. I guess this is due to the webgl limit: ‘MAX_3D_TEXTURE_SIZE’, which is 2048 on my system (chrome). Does this mean that it is not possible to display simple DR images with one dimension larger than 2048? Unfortunately, we have many of them. Is it necessary to use a 3D texture for plain DR images?

Any idea what might be causing the image to be cropped? I've seen similar issues in the older version, but a lot of the API has changed, and I am unsure how to approach it. I've tried changing the camera options but it doesn't appear to do anything for the stack version.

The image currently looks like this:

It should look like this:

This is a stack view. I've added the zoom and pan tool, but it seems like the image is still cropped. Changing the properties or camera through setCamera and setProperties doesn't appear to do anything. I tried directly setting sHeight and sWidth, but that also doesn't appear to help.

Possibly Software Versions:

    "@cornerstonejs/calculate-suv": "1.0.2",
    "@cornerstonejs/core": "0.8.1",
    "@cornerstonejs/streaming-image-volume-loader": "0.2.24",
    "@cornerstonejs/tools": "0.15.4",
    "@kitware/vtk.js": "24.0.0",
    "react": "17.0.2",
    "vite": "2.7.2"

These are the current viewport settings:

These are the metadata associated with the image using a custom metadataprovider with cornerstonewebimageloader (not a real patient below)

accessionNumber: 7974669
acquisitionDate: 20150519
acquisitionNumber: 25
acquisitionTime: "082223"
additionalPatientHistory: ""
angleOfFirstView: 0
biopsyPosition: 0
biopsyRefLocation: 0
biopsyTLocation: 0
bitsAllocated: 16
bitsStored: 16
cellNumberAtTheta: 389.75
cellSpacing: 1.0239
centerACoordOfPlaneImage: 47.5999985
centerRCoordOfPlaneImage: 2.5999999
centerSCoordOfPlaneImage: -135.75
columns: 512
contentDate: 20150519
contentTime: "082225"
convolutionKernel: "STANDARD"
correctedAfterglowTerms: 0
dasAdInput: 0
dasCalMode: 0
dasFpaGain: 0
dasOutputSource: 0
dasTriggerSource: 0
dataCollectionDiameter: 500
degreeOfRotation: 362.926819
degreesOfAzimuth: 87
deltaStartTime: 0
dependantOnNumberOfViewsProcessed: 2
distanceSourceToDetector: 949.075012
distanceSourceToPatient: 541
durationOfXrayOn: 1
exposure: 37
exposureTime: 1000
filterType: "BODY FILTER"
firstScanRas: "S"
focalSpots: 1.2
frameOfReferenceUid: "1.3.6.1.4.1.5962.99.1.2260725868.1504138972.1445369770092.7.0"
fullFidelity: "CT_LIGHTSPEED"
gantryDetectorTilt: 0
gantryPeriod: 1
generatorPower: 36000
highBit: 15
horizontalFrameOfReference: 640.039978
imageActualDate: 1432023674
imageFromWhichPrescribed: 2
imageOrientationPatient: (6) [1, '0.000000', '0.000000', '0.000000', 1, '0.000000']
imagePositionPatient: (3) [-131.1, -176.1, -135.75]
imageType: (3) ['ORIGINAL', 'PRIMARY', 'AXIAL']
instanceCreationDate: 20150519
instanceCreationTime: "082225"
instanceNumber: 200
institutionName: "Stanford"
kvp: 120
lastScanRas: "I"
manufacturer: "GE MEDICAL SYSTEMS"
manufacturerModelName: "Discovery ST"
maxOverrangesInAView: 0
midScanFlag: 1
midScanTime: 56.425903
modality: "CT"
nameOfPhysiciansReadingStudy: ""
noViewsRefChannelsBlocked: 0
normalACoord: -0
normalRCoord: 0
normalSCoord: 1
numberOfCellsInDetector: 912
numberOfOverranges: -1
numberOfTriggers: 992
operatorsName: "JL"
patientAge: "068Y"
patientBirthDate: 19470328
patientId: 8907068
patientName: "Kim^SphericalMets"
patientPosition: "HFS"
patientSex: "F"
patientWeight: 70
performedProcedureStepDescription: "Radiation Oncology CT"
performedProcedureStepId: "PPS ID  21429"
performedProcedureStepStartDate: 20150519
performedProcedureStepStartTime: "081652"
photometricInterpretation: "MONOCHROME2"
pixelData: null
pixelPaddingValue: -2000
pixelRepresentation: 1
pixelSpacing: (2) [0.501953, 0.501953]
planeType: 2
positionReferenceIndicator: "OM"
privateCreator: "GEMS_HELIOS_01"
privateScanOptions: 2
productId: "Discovery ST"
protocolName: "2.3 STEREO BRAIN"
raCoordOfTargetReconCentre: (2) [2.6, 47.599998]
reconPostProcessingFlag: 1
reconstructionDiameter: 257
referenceChannels: 0
referencedImageSequence: [{…}]
referencedPatientSequence: [{…}]
referencedStudySequence: [{…}]
referringPhysicianName: ""
requestAttributesSequence: [{…}]
rescaleIntercept: -1024
rescaleSlope: 1
rescaleType: "HU"
rotationDirection: "CW"
rows: 512
samplesPerPixel: 1
scanFovType: 16
scanOptions: "AXIAL MODE"
scanPitchRatio: ""
scoutType: 0
segmentNumber: 0
seriesContrast: 0
seriesDate: 20150519
seriesDescription: "STEREO BRAIN"
seriesFromWhichPrescribed: 1
seriesInstanceUid: "1.3.6.1.4.1.5962.99.1.2260725868.1504138972.1445369770092.6.0"
seriesNumber: 2
seriesTime: "082114"
sliceLocation: -135.75
sliceThickness: 1.25
smartScanOnOffFlag: 0
softwareVersions: "CyberKnife Information System 2.6.0.8"
sopClassUid: "1.2.840.10008.5.1.4.1.1.2"
sopInstanceUid: "1.3.6.1.4.1.5962.99.1.2260725868.1504138972.1445369770092.189.0"
startScanToXrayOnDelay: 0
startTimeSecsInFirstAxial: 1432023687.773211
stationName: "stct"
studyDate: 20150519
studyDescription: "Radiation Oncology CT"
studyId: 21429
studyInstanceUid: "1.3.6.1.4.1.5962.99.1.2260725868.1504138972.1445369770092.2.0"
studyTime: "081652"
suiteId: "STCT"
tableEndLocation: 0
tableHeight: 176
tableSpeed: 0
tableStartLocation: 0
totalSegmentsRequested: 0
triggerFrequency: 984
triggerOnPosition: 147.926682
uniqueImageIdentifier: null
unknownTagData: ""
viewCompressionFactor: 1
vmaClip: 0
vmaMamp: 0
vmaMod: 0
windowCenter: 40
windowValue: 400
windowWidth: 400
xRayTubeCurrent: 300
xrayChain: 99

AngleTool will be broken after annotation cancellation, because it tries to get the annotationId of a non-existing annotation.

Fixed this issue by setting angleStartedNotYetCompleted to false upon cancellation.

Depending on https://github.com/cornerstonejs/cornerstoneWADOImageLoader/pull/504

Previously we had a whole new image loader called SharedArrayBufferImageLoader for the Streaming Volume Loader, which whole purpose was to not create the image object since it don't use it, it only uses the pixel data to fill and replace the texture in GPU.

Based on the initial profiling createImage takes 4ms for each image which is not much but for large number of images it can be a bottleneck

having a new option to skipCreateImage will make the it 0.17 ms on average; we can achieve the same functionality without any added complexity of new image loaders.

import * as cornerstoneTools from '@cornerstonejs/tools';

In Vue3, after all dependencies are installed and Cornerstone is introduced, the error of vec2 is reported

When using wado-uri or file system to load an ultrasound 8-bit image with with "Photometric Interpretation (0028,0004)" "RGB" and "Samples Per Pixel (0028,0002)" "3" the image rendering is corrupted.

There are different rendering results using CPU or WebGL, You can try this in the Examples:

1. DICOM P10 from local file system (CPU): image is completely corrupted
2. DICOM P10 from local file system: Image is rendered correctly but the W/L values are off. Compare this when applying the same WW/WC on other DICOM viewer (desktop or OHIF WADO-RS)

CPU Example Result:

WebGL Example Result:

Desktop Viewer (notice the non-organ part is black):

Hi,

Working on using cornerstone3d in a Vite project, ran into an issue when running the project. I think I have narrowed it down to a possibly circular dependency in packages/tools/src/tools/CrosshairsTool.ts when importing liangBarksyClip Happy to provide an example minimal repository with the error to verify.

Console error

cornerstonejs.bd843ac7.js:18089 Uncaught ReferenceError: Cannot access 'index' before initialization
    at cornerstonejs.bd843ac7.js:18089:29

with index being

...
const { RENDERING_DEFAULTS } = CONSTANTS;
const { liangBarksyClip } = index;
function defaultReferenceLineColor() {
  return "rgb(0, 200, 0)";
}
...