Testing edit, updating status,clear all completed:

• An executed unit test case for editing the task description function.
• An executed unit test case for updating an item's 'completed' status function.
• An executed unit test case for the "Clear all completed" function.

Make sure the webpack is working correctly

• Add module folder
• Add event listener to the checkbox
• Create function.js for functionality store for localStorage and for the task.
• Add checkbox for completed todo
• Update items object's value for completed key upon user actions
• When u click clear all completed tasks must delete.

Make sure the webpack is working correctly

• Add module folder
• Create function.js for functionality store for localStorage and for the task.
• Add checkbox for completed todo
• Add delete
• When u click clear all completed tasks must delete.

ToDoList structure

• Setup linters
• Setup webpack
• Create index.html, style.css, index.js inside the src
• Setup structure by html and stylize css
• Give some functions by js

Required Changes 🔁

Hello @NurkaAmre 😄

This is @Nejjari001, your colleague.

Good job so far 👏 👏 Your Project is almost on point. There are a few changes you could effect to make it superb 😃.

Highlights:

• All linters passing. ✅

• Professional readme. ✅

• Good commit message. ✅

• type checks. ✅

• naming. ✅

• simplicity. ✅

• DRY. ✅

Required Changes ♻️

Please, check the comment below for required changes. 🙃

Optional suggestions:

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

-N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me [@Nejjari001] in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

https://github.com/NurkaAmre/ToDoList-Structure/blob/556ba2b4990e58f062a3d2e7df96987cdb665253/src/index.html#L12-L33

• [ ] Please, make your code more semantic, by adding main instead Div tags as appropriate 👍 💯 .

https://github.com/NurkaAmre/ToDoList-Structure/blob/556ba2b4990e58f062a3d2e7df96987cdb665253/src/style.css#L94

• [ ] Kindly, make your code more cleaner by removing unused comments 😃

Use the appropriate tags for each element (e.g., links, titles, etc.) and use HTML5 semantic tags (e.g., header, nav) over divs. ✅

Avoid lines of code that are too long (100 characters or more). ✅

Be careful with blank lines and indentation. ✅

Do not add blank lines, spaces, or indentations without a reason. ❌ http://joxi.ru/82Qnn5lc8n7kEA For readability, add blank lines to separate large or logical code blocks. ✅ For readability, add two spaces of indentation. Do not use the tab key. ✅ on some code editors, you can set the tab button to do an X amount of spaces. Close all HTML elements. ✅

use

#intro1 {color: #3498db; font-size: 10px; font-weight: bold;}
header {color: #3498db; font-size: 20px; background-color: green;}
#banner {color: #3498db; font-size: 30px; background-image: url(images/static.jpg);}

JavaScript best practices

General practices

1. Keep all the JavaScript code in JS files, not in the script tag. ✅
2. Keep your code clean following this advice about:

• type checks. ✅
• naming. ✅
• simplicity. ✅
• DRY. ✅

3. If you use node modules, .lock files should be in the repository to avoid problems with future versions of the dependencies. ✅
4. If you use ES6, use object destructuring to get the values from an object. This way you can avoid repeating a lot of code. ✅

JavaScript in the browser

1. Do not commit console.log to your repo. It’s ugly, it kills performance and it can make confidential data visible to anyone using the browser tools to look at your website. ✖️
2. Do not use window.alert() or window.confirm(). It’s ugly, and impossible to style, it stops code execution and displays differently on different browsers. Use a custom modal instead. ✅
3. Keep the number of changes/updates to the DOM as low as possible, they are very expensive for the browser. ✅
4. Keep the application logic separated from DOM manipulation tasks. ✅
5. Do not use document.write or eval ✅
6. Add node_modules dir to your .gitignore file as all those files are not needed in your repo (each team member will install all packages thanks to your package.json file). ✅
7. Do not commit old pieces of code as inline comments. They will make your project look messy. If you need to review a previous version of your code, you can always use git history.