Describe the bug The plugin crashes unexpectedly when not destructuring the result of calling useForm.

To Reproduce

1. The code you are going to lint.

const { useForm } = require('react-hook-form')
export function Component() {
  const formMethods = useForm()
  return null
}

2. Your ESlint config

{
  ...
  'react-hook-form/no-nested-object-setvalue': ['error', { bracketAsArrayIndex: true }],
}

Expected behavior I expect the React Hook Form Eslint plugin to not crash.

Actual behavior The React Hook Form ESLing plugin crashes with the following error message:

TypeError: Cannot read property 'find' of undefined
Occurred while linting my-project/components/TestComponent.jsx:3
    at check (my-project/node_modules/eslint-plugin-react-hook-form/lib/rules/no-nested-object-setvalue.js:48:53)
    at my-project/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (my-project/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (my-project/node_modules/eslint/lib/linter/node-event-generator.js:254:26)
    at NodeEventGenerator.applySelectors (my-project/node_modules/eslint/lib/linter/node-event-generator.js:283:22)
    at NodeEventGenerator.enterNode (my-project/node_modules/eslint/lib/linter/node-event-generator.js:297:14)
    at CodePathAnalyzer.enterNode (my-project/node_modules/eslint/lib/linter/code-path-analysis/code-path-analyzer.js:711:23)
    at my-project/node_modules/eslint/lib/linter/linter.js:952:32
    at Array.forEach (<anonymous>)

Enviornment (please complete the following information):

• Eslint version: 7.12.1
• Node version: v14.18.3
• React-Hook-Form version: 6.15.8
• eslint-plugin-react-hook-form version: 0.2.2

Additional context n/a

Describe the bug The plugin crashes unexpectedly when using ...rest syntax in the destructuring of the result of calling useForm.

To Reproduce

1. The code you are going to lint.

const { useForm } = require('react-hook-form')
export function Component() {
  const { watch, ...restFormMethods } = useForm()
  return null
}

2. Your ESlint config

{
  ...
  'react-hook-form/no-nested-object-setvalue': ['error', { bracketAsArrayIndex: true }],
}

Expected behavior I expect the React Hook Form Eslint plugin to not crash.

Actual behavior The React Hook Form ESLing plugin crashes with the following error message:

TypeError: Cannot read property 'name' of undefined
Occurred while linting my-project/components/TestComponent.jsx:3
    at my-project/node_modules/eslint-plugin-react-hook-form/lib/rules/no-nested-object-setvalue.js:49:24
    at Array.find (<anonymous>)
    at check (my-project/node_modules/eslint-plugin-react-hook-form/lib/rules/no-nested-object-setvalue.js:48:53)
    at my-project/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (my-project/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (my-project/node_modules/eslint/lib/linter/node-event-generator.js:254:26)
    at NodeEventGenerator.applySelectors (my-project/node_modules/eslint/lib/linter/node-event-generator.js:283:22)
    at NodeEventGenerator.enterNode (my-project/node_modules/eslint/lib/linter/node-event-generator.js:297:14)
    at CodePathAnalyzer.enterNode (my-project/node_modules/eslint/lib/linter/code-path-analysis/code-path-analyzer.js:711:23)

Enviornment (please complete the following information):

• Eslint version: 7.12.1
• Node version: v14.18.3
• React-Hook-Form version: 6.15.8
• eslint-plugin-react-hook-form version: 0.2.2

Additional context n/a

Hi, thanks for this library. It would have saved me some trouble if I knew about it yesterday. I noticed some typos in the error message, so this PR cleans them up. I don't think useDestuctor is user-facing, but I fixed that anyway.

Describe the bug react-hook-form/no-nested-object-setvalue is thrown with message Avoid passing object or array as second argument in setValue since this is less performant, when using the following syntax:

setValue("someName", myFunctionReturningANumber())

To Reproduce

1. The code you are going to lint.

function Component() {
  const {useValue} = useForm();

  const myFunctionReturningANumber = () => 5

  setValue("someName", myFunctionReturningANumber())

  return null;
}

2. Your ESlint config

{
  ...
  'react-hook-form/no-nested-object-setvalue': ['error', { bracketAsArrayIndex: true }],
}

Expected behavior Expect react-hook-form/no-nested-object-setvalue not to throw an error.

Actual behavior react-hook-form/no-nested-object-setvalue throws with message Avoid passing object or array as second argument in setValue since this is less performant

Enviornment (please complete the following information):

• Eslint version: 7.12.1
• Node version: v14.18.3
• React-Hook-Form version: 6.15.8
• eslint-plugin-react-hook-form version: 0.2.3

Additional context n/a

Describe the bug ESLint exits with fatal error.

To Reproduce

1. The code you are going to lint.

for (const element of array) {
  bar(element);
}

2. Your ESlint config

{
  "parserOptions": {
    "ecmaVersion": "latest"
  },

  "plugins": ["react-hook-form"],

  "rules": {
    "react-hook-form/destructuring-formstate": "error"
  }
}

Expected behavior No fatal error.

Actual behavior

Oops! Something went wrong! :(

ESLint: 8.6.0

TypeError: Cannot read property 'type' of null
Occurred while linting /example/example.js:1
Rule: "react-hook-form/destructuring-formstate"
    at check (/example/node_modules/eslint-plugin-react-hook-form/lib/rules/destructuring-formstate.js:45:19)
    at ruleErrorHandler (/example/node_modules/eslint/lib/linter/linter.js:1079:28)
    at /example/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/example/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/example/node_modules/eslint/lib/linter/node-event-generator.js:297:26)
    at NodeEventGenerator.applySelectors (/example/node_modules/eslint/lib/linter/node-event-generator.js:326:22)
    at NodeEventGenerator.enterNode (/example/node_modules/eslint/lib/linter/node-event-generator.js:340:14)
    at CodePathAnalyzer.enterNode (/example/node_modules/eslint/lib/linter/code-path-analysis/code-path-analyzer.js:795:23)
    at /example/node_modules/eslint/lib/linter/linter.js:1110:32

Enviornment (please complete the following information):

• Eslint version: 8.6.0
• Node version: 14.18.2
• React-Hook-Form version: 0.2.1

Additional context

• VariableDeclarator.id may have different kinds of types. What we are interested in is the ObjectPattern. Add this condition to avoid errors in #13 and #14 . (Reference: https://github.com/estree/estree/blob/master/es2015.md#patterns)
• Upgrade the ecma version to 9 to support RestElement (References: https://github.com/estree/estree/blob/master/es2018.md#patterns)

fix: #13 #14

VariableDeclarator.init will be null if this declarator isn't initialized. In particular, if the declarator hasn't been assigned by any value, the property init will be null. Thus, the pattern like const a will be failed. We fix the issue by using ES6 optional chaining.

fix #11

Since we are going to leverage the squash-based workflow, it's no longer needed to lint every commit. Instead, all we need to lint is the PR title, which is going to be the commit message of the squash-merged commit.

Add more conditions to the target variable formState:

• Check if the initializer is useForm()
• Check the alias. e.g. {formState: fs}
• Support useFormState()