Hi

Thanks for this convenient library that allows me to use a single codebase on browser & node! I'm using this with browserify, but I've had to remove a few things from request.js:

• require('./xmlhttprequest') — that file is not in the current directory
• The check for XHR.name !== 'cXMLHttpRequest'
• I also added a browserify key to package.json. A main key would help as well here.

Do you understand the issues or do you want me to draft a pull request?

this removes almost everything, including the xmlhttprequest polyfill. I couldn't make heads or tails of the previous build system (required ruby and makefiles).

this adds browserling tests, and will make it a lot easier to contribute to this repo. we'll need to add back a cross browser xhr polyfill, but it can be done in a sane way with tests this time.

at this time iriscouch/browser-request doesn't work in FF but this one does

Given a cross domain request:

request({url: "http://pizza.com/api"}, function(e,r,b) {
  console.log(e,r,b)
})

e and b are null

request({url: "http://pizza.com/api", json:true}, function(e,r,b) {
  console.log(e,r,b)
})

e is a JSON parse syntax error and b is null

Would it be possible to detect and return an error about the single origin policy?

In Chrome the following code works. In Firefox I get the error : Error: CORS request rejected With the code :

use strict';
var request =require('browser-request');
var url = 'http://docs.google.com/spreadsheets/export?id=1-on_GfmvaEcOk7HcWfKb8B6KFRv166RkLN2YmDEtDn4&exportFormat=csv';
request(url, function (error, response, body) {
    if (!error && response.statusCode == 200) {
        console.log('success fetch');
        console.log(response.statusCode);
        console.log(body);
    }else{
        console.log(error + ' ' + response.statusCode );
    }
});

this bumps the version to 0.3.0 so we can publish to npm. also fixes urls for the testling badge

can you add em as a collaborator to this repo and also npm owners add browser-request maxogden? cheers

Some encoding issue

---------------------------------702453823
Content-Disposition: form-data; name="profile_picture"

[object Object]
---------------------------------702453823--

hi, I tried the normal request module and browserified it. Everything worked fine in the browser. Am I missing something? Why would one use browser-request instead of request?

Thank you

• check for the existence of global.XMLHttpRequest directly
• reference global.XMLHttpRequest constructor instead of the constructor that was dereferenced when the library was first parsed
• reference global.XMLHttpRequest status properties directly instead of the properties of the prototype of the constructor that was dereferenced when the library was first parsed

This will allow mocking libraries that rely on being able to replace the reference to global.XMLHttpRequest with a mock XMLHttpRequest object that can be programmatically manipulated.

Such libraries include the jasmine-ajax plugin. I'm sure there are others.

It's a little more typing, but it fixes a big bug.

With 30 Issues Opened and 31 Pull requests, I am wondering if this library is still maintained by anyone and if not, what could be the implications of using it in the long-term?

Hi there, how hard would it be to support proxy option, that is supported in the node request?

I was thinking, we would just need to replace the host address in URL of each request with the proxy host/ip address and it should work, am I wrong?

Use case: We're trying to switch from request to browser-request because of HTTP/2 support. We use this in Electron, so we have both node and browser environments.

Following the Usage instructions it seems like I should be able to avoid using Browserify by loading the browser-request JS file directly in HTML like so <script src="node_modules/browser-request/index.js"></script> and then in another JS file that is loaded beneath it, using browser-request by calling window.request (HTML comment in Usage instructions reads "Assigns the module to window.request"). Apparently I am misinterpreting that because window.request is undefined. Can someone please explain to me how to use this without needing to use Node's require() and Browserify? I have confirmed that node_modules/browser-request/index.js is being loaded by the browser.

Thank you.

By default browser-request is async but I don't see any obvious way to make it sync. I have two functions, getHTTP and HTTPExists, but I also want to make getHTTPSync and HTTPExistsSync.

What are my options to make them sync?

function HTTPExists(url, cb) {
  request({ url: resolve(url), method: 'HEAD' }, function(err, res) {
    if (err) return cb(null, false);
    cb(null, /4\d\d/.test(res.statusCode) === false);
  });
}

function getHTTP(url, cb) {
  request(resolve(url), function (error, response, body) {
    if (!error && response.statusCode == 200) {
      cb(null, body);
    } else {
      cb(error, body)
    }
  })
}

Two fixes here:

1. Method can be manually set via method: 'post', so we need the method check to be not case sensitive #63
2. Sometimes form data is required for PUT requests