Description

Package              Current Wanted Latest Package Type    URL
@babel/core          7.19.0  7.19.6 7.19.6 dependencies    https://babel.dev/docs/en/next/babel-core
@babel/eslint-parser 7.18.9  7.19.1 7.19.1 dependencies    https://babel.dev/
eslint               8.23.0  8.26.0 8.26.0 devDependencies https://eslint.org
yargs                17.5.1  17.6.0 17.6.0 dependencies    https://yargs.js.org/

Description

Package                          Current Wanted Latest Package Type    URL                                                              
@babel/core                      7.18.13 7.19.0 7.19.0 dependencies    https://babel.dev/docs/en/next/babel-core
eslint                           8.22.0  8.23.0 8.23.0 devDependencies https://eslint.org
eslint-plugin-simple-import-sort 7.0.0   7.0.0  8.0.0  devDependencies https://github.com/lydell/eslint-plugin-simple-import-sort#readme

Description

Package     Current Wanted  Latest  Package Type    URL                                      
@babel/core 7.18.9  7.18.13 7.18.13 dependencies    https://babel.dev/docs/en/next/babel-core
eslint      8.20.0  8.22.0  8.22.0  devDependencies https://eslint.org

Description

Closes #1. If a user specified podModulePrefix in their config/environment.js, they can pass the argument --pod-path to the codemod. At the moment, the --pod-path argument affects only Ember apps.

Note, the name podPath came from the emberjs/ember.js repo. The value refers to the "difference" between podModulePrefix and modulePrefix. For example, if a user has the following config/environment.js:

/* config/environment.js */
'use strict';

module.exports = function (environment) {
  let ENV = {
    modulePrefix: 'my-app',
    podModulePrefix: 'my-app/pods',
    ...
  };

  return ENV;
};

then:

podPath = 'my-app/pods' - 'my-app' = 'pods'

So the user will need to enter the following command:

npx ember-codemod-pod-to-octane --pod-path=pods --type=app

Due to a change in APIs, this pull request unfortunately became large. There may be opportunities to refactor code. Let's do so in a separate issue and pull request.

Description

Closes #4. The codemod can move .scss files that were created as a result of using ember-css-modules-sass.

Note, I'm uncertain how ember-css-modules-sass is supposed to work in addons and engines, as I didn't have real-life examples. I guessed how the migration should work. If this results in a bug, we can create an issue then.

Description

Closes #3. migrateEmberApp() can now find services that are placed in a pod directory and move them to app/services.

In a production app (with many addons and engines), I found only one example of a service that had been placed in a custom directory. To reduce the scope of work and future maintenance, I didn't add a migration strategy for addons and engines.

The codemod supports ember-css-modules, which then supports Sass. Update the migration strategies for stylesheets by checking for the file extension .scss.

I didn't realize that the file location of a service is also affected by the pod structure. Add a migration strategy for Ember apps ~(possibly, for engines too)~.

❯ ember g service my-route
installing service
  create app/my-route/service.js
installing service-test
  create tests/unit/my-route/service-test.js

Currently, the codemod assumes that podModulePrefix: '<my-app-name>' (i.e. equal to the value of modulePrefix). However, it's possible that a team has set another value such as '<my-app-name>/pods'.

/* config/environment.js */
'use strict';

module.exports = function (environment) {
  let ENV = {
    modulePrefix: 'my-app',
    podModulePrefix: 'my-app/pods',
    ...
  };

  return ENV;
};

❯ ember g component my-component --gc

installing component
  create app/pods/components/my-component/component.js
  create app/pods/components/my-component/template.hbs
installing component-test
  create tests/integration/pods/components/my-component/component-test.js

❯ ember g route my-route
installing route
  create app/pods/my-route/route.js
  create app/pods/my-route/template.hbs
installing route-test
  create tests/unit/pods/my-route/route-test.js

❯ ember g controller my-route
installing controller
  create app/pods/my-route/controller.js
installing controller-test
  create tests/unit/pods/my-route/controller-test.js